From: "H.J. Lu" <hjl.tools@gmail.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: sandra@codesourcery.com, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Document -fexcess-precision=16 in tm.texi
Date: Fri, 30 Sep 2022 15:51:02 -0700 [thread overview]
Message-ID: <CAMe9rOrrSA0VfNksC688bJwh_=8HH-VN8XSs2H2S_hV0Q8ku=Q@mail.gmail.com> (raw)
In-Reply-To: <mhng-fca4319e-6aa8-4676-ad68-f592aeeab784@palmer-ri-x1c9>
On Fri, Sep 30, 2022 at 3:25 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Sat, 24 Sep 2022 19:13:36 PDT (-0700), sandra@codesourcery.com wrote:
> > On 9/18/22 02:47, Palmer Dabbelt wrote:
> >> On Fri, 09 Sep 2022 02:46:40 PDT (-0700), Palmer Dabbelt wrote:
> >>> I just happened to stuble on this one while trying to sort out the
> >>> RISC-V bits.
> >>>
> >>> gcc/ChangeLog
> >>>
> >>> * doc/tm.texi (TARGET_C_EXCESS_PRECISION): Add 16.
> >>> ---
> >>> gcc/doc/tm.texi | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi
> >>> index 858bfb80cec..7590924f2ca 100644
> >>> --- a/gcc/doc/tm.texi
> >>> +++ b/gcc/doc/tm.texi
> >>> @@ -1009,7 +1009,7 @@ of the excess precision explicitly added. For
> >>> @code{EXCESS_PRECISION_TYPE_FLOAT16}, and
> >>> @code{EXCESS_PRECISION_TYPE_FAST}, the target should return the
> >>> explicit excess precision that should be added depending on the
> >>> -value set for @option{-fexcess-precision=@r{[}standard@r{|}fast@r{]}}.
> >>> +value set for
> >>> @option{-fexcess-precision=@r{[}standard@r{|}fast@r{|}16@r{]}}.
> >>> Note that unpredictable explicit excess precision does not make sense,
> >>> so a target should never return @code{FLT_EVAL_METHOD_UNPREDICTABLE}
> >>> when @var{type} is @code{EXCESS_PRECISION_TYPE_STANDARD},
> >>
> >> Just pinging this one as I'm not sure if it's OK to self-approve -- no
> >> rush on my end, I already figured it out so I don't need the
> >> documentation any more.
> >
> > This is fine, looks like a trivial correction.
>
> Thanks, committed.
tm.texi is a generated file. I am checking in this patch to restore bootstrap.
--
H.J.
--
diff --git a/gcc/target.def b/gcc/target.def
index 4d49ffc2c88..a3d3b04a165 100644
--- a/gcc/target.def
+++ b/gcc/target.def
@@ -6181,7 +6181,7 @@ of the excess precision explicitly added. For\n\
@code{EXCESS_PRECISION_TYPE_FLOAT16}, and\n\
@code{EXCESS_PRECISION_TYPE_FAST}, the target should return the\n\
explicit excess precision that should be added depending on the\n\
-value set for @option{-fexcess-precision=@r{[}standard@r{|}fast@r{]}}.\n\
+value set for @option{-fexcess-precision=@r{[}standard@r{|}fast@r{|}16@r{]}}.\n\
Note that unpredictable explicit excess precision does not make sense,\n\
so a target should never return @code{FLT_EVAL_METHOD_UNPREDICTABLE}\n\
when @var{type} is @code{EXCESS_PRECISION_TYPE_STANDARD},\n\
next prev parent reply other threads:[~2022-09-30 22:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 9:46 Palmer Dabbelt
2022-09-18 8:47 ` Palmer Dabbelt
2022-09-25 2:13 ` Sandra Loosemore
2022-09-30 22:25 ` Palmer Dabbelt
2022-09-30 22:51 ` H.J. Lu [this message]
2022-09-30 22:58 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrrSA0VfNksC688bJwh_=8HH-VN8XSs2H2S_hV0Q8ku=Q@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=palmer@dabbelt.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).