From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-396223-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 12533 invoked by alias); 28 Apr 2015 16:22:34 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 12471 invoked by uid 89); 28 Apr 2015 16:22:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-oi0-f44.google.com
Received: from mail-oi0-f44.google.com (HELO mail-oi0-f44.google.com) (209.85.218.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 28 Apr 2015 16:22:28 +0000
Received: by oift201 with SMTP id t201so120524242oif.3        for <gcc-patches@gcc.gnu.org>; Tue, 28 Apr 2015 09:22:26 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.182.144.226 with SMTP id sp2mr14879668obb.11.1430238146221; Tue, 28 Apr 2015 09:22:26 -0700 (PDT)
Received: by 10.76.54.14 with HTTP; Tue, 28 Apr 2015 09:22:26 -0700 (PDT)
In-Reply-To: <20150428162049.GA62528@msticlxl7.ims.intel.com>
References: <20150319092404.GA73948@msticlxl7.ims.intel.com>	<20150323160222.GB10265@msticlxl7.ims.intel.com>	<20150324134311.GA40649@msticlxl57.ims.intel.com>	<20150428162049.GA62528@msticlxl7.ims.intel.com>
Date: Tue, 28 Apr 2015 16:59:00 -0000
Message-ID: <CAMe9rOrtVsNA6V3WA5mFS3ULtdNkR9+MNk59CgWAkCx43akM=Q@mail.gmail.com>
Subject: Re: [PATCH, PR65915] Fix float conversion split.
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Tocar <tocarip.intel@gmail.com>
Cc: Kirill Yukhin <kirill.yukhin@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>, 	Uros Bizjak <ubizjak@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg01763.txt.bz2

On Tue, Apr 28, 2015 at 9:20 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > I've renamed EXT_SSE_REG_P into EXT_REX_SSE_REG_P for consistency.
>> > Ok for stage1?
>> Patch is OK for stage1.
>>
>> --
>> Thanks, K
>>
>>
>> > On 19 Mar 12:24, Ilya Tocar wrote:
>> > > Hi,
>> > >
>> > > There were some discussion about "x" constraints being too conservative
>> > > for some patterns in i386.md.
>> > > Patch below fixes it. This is probably stage1 material.
>> > >
>> > > ChangeLog:
>> > >
>> > > gcc/
>> > >
>> > 2015-03-23  Ilya Tocar  <ilya.tocar@intel.com>
>> >
>> >     * config/i386/i386.h (EXT_REX_SSE_REG_P): New.
>> >     * config/i386/i386.md (*cmpi<FPCMP:unord><MODEF:mode>_mixed): Use "v"
>> >     constraint.
>> >     (*cmpi<FPCMP:unord><MODEF:mode>_sse): Ditto.
>> >     (*movxi_internal_avx512f): Ditto.
>> >     (define_split): Check for xmm16+, when splitting scalar float_extend.
>> >     (*extendsfdf2_mixed): Use "v" constraint.
>> >     (*extendsfdf2_sse): Ditto.
>> >     (define_split): Check for xmm16+, when splitting scalar float_truncate.
>> >     (*truncdfsf_fast_sse): Use "v" constraint.
>> >     (fix_trunc<MODEF:mode><SWI48:mode>_sse): Ditto.
>> >     (*float<SWI48:mode><MODEF:mode>2_sse): Ditto.
>> >     (define_peephole2): Check for xmm16+, when converting scalar
>> >     float_truncate.
>> >     (define_peephole2): Check for xmm16+, when converting scalar
>> >     float_extend.
>> >     (*fop_<mode>_comm_mixed): Use "v" constraint.
>> >     (*fop_<mode>_comm_sse): Ditto.
>> >     (*fop_<mode>_1_mixed): Ditto.
>> >     (*sqrt<mode>2_sse): Ditto.
>> >     (*ieee_s<ieee_maxmin><mode>3): Ditto.
>> >
>> >
>
> Hi,
>
> Looks like I missed some splits, which caused PR65915.
> Patch below fixes it.
> Ok for trunk?
>
> 2015-04-28  Ilya Tocar  <ilya.tocar@intel.com>
>
>         * config/i386/i386.md (define_split): Check for xmm16+,
>         when splitting scalar float conversion.
>

Need a testcase and PR# in ChangeLog.


-- 
H.J.