From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-414872-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 38913 invoked by alias); 21 Nov 2015 19:19:26 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 38890 invoked by uid 89); 21 Nov 2015 19:19:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: mail-ob0-f175.google.com
Received: from mail-ob0-f175.google.com (HELO mail-ob0-f175.google.com) (209.85.214.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 21 Nov 2015 19:19:24 +0000
Received: by obbnk6 with SMTP id nk6so109776021obb.2;        Sat, 21 Nov 2015 11:19:22 -0800 (PST)
MIME-Version: 1.0
X-Received: by 10.60.220.135 with SMTP id pw7mr13223393oec.51.1448133562190; Sat, 21 Nov 2015 11:19:22 -0800 (PST)
Received: by 10.76.72.3 with HTTP; Sat, 21 Nov 2015 11:19:22 -0800 (PST)
In-Reply-To: <20151121182014.GA23753@troutmask.apl.washington.edu>
References: <20151120005836.GA53763@troutmask.apl.washington.edu>	<20151120200947.GA61350@troutmask.apl.washington.edu>	<CAGkQGi+bvMEzo_xk_=Ugu5GdrtV28peFvOQHnAAqAUoSTJaVxw@mail.gmail.com>	<20151121162657.GA23304@troutmask.apl.washington.edu>	<CAMe9rOqOJKti4JRKbRMB-QRRJ1HMCdNTL8F14GYo9uNNgOQBSQ@mail.gmail.com>	<20151121182014.GA23753@troutmask.apl.washington.edu>
Date: Sat, 21 Nov 2015 19:26:00 -0000
Message-ID: <CAMe9rOrv0tj2r6c1W482gcqj+BGdkYrPVS04AQGiVnrpdb8RcA@mail.gmail.com>
Subject: Re: [PATCH] (Partial) Implementation of simplificaiton of CSHIFT
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Paul Richard Thomas <paul.richard.thomas@gmail.com>, 	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-11/txt/msg02588.txt.bz2

On Sat, Nov 21, 2015 at 10:20 AM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Sat, Nov 21, 2015 at 10:07:35AM -0800, H.J. Lu wrote:
>> On Sat, Nov 21, 2015 at 8:26 AM, Steve Kargl
>> <sgk@troutmask.apl.washington.edu> wrote:
>> > On Sat, Nov 21, 2015 at 11:41:51AM +0100, Paul Richard Thomas wrote:
>> >>
>> >> Just a couple of small typos:
>> >> "Unexpected expr_type cause an ICE" ;  causes?
>> >> "! An array of derived types workd too." ; works?
>> >>
>> >> Apart from that it's OK for trunk.
>> >>
>> >> Thanks for the patch
>> >>
>> >
>> > Thanks for the the review.  I don't have a clue as
>> > to how to do simplification for rank > 2. :(
>> >
>>
>> It breaks bootstrap:
>>
>>   int dm;
>>
>>   /* DIM is only useful for rank > 1, but deal with it here as one can
>>      set DIM = 1 for rank = 1.  */
>>   if (dim)
>>     {
>>       if (!gfc_is_constant_expr (dim))
>> return NULL;
>>       dm = mpz_get_si (dim->value.integer);
>>     }
>>   else
>>     dm = 1;
>>
>> dm is set, but never used.
>>
>
> Perhaps, bootstrap needs to set appropriate warning levels.

https://gcc.gnu.org/ml/gcc-regression/2015-11/msg00648.html

-- 
H.J.