From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by sourceware.org (Postfix) with ESMTPS id 2512D386F82C for ; Sat, 20 Jun 2020 13:40:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2512D386F82C Received: by mail-il1-x142.google.com with SMTP id x18so11915316ilp.1 for ; Sat, 20 Jun 2020 06:40:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xxCJI8WqFT3osuz2fkCJaeF/Cx8U4YOuGljyYkF+qag=; b=HjWoxR22Er4X5Hg2rt2S0cQf41yhR/X3ma8mws/v0d3fZy4M9Psb0KjbTEYIO8RgL/ eWrLx380S8GEuTu/1+RFdeLfXTEVs4Pv2mDFH3bWkpxKjznY7+2d8XHPeQU37jdkwqEL sdQ+faHzS2ikK7zzyEtGmzrTwdlxiVs/Vq+07ozsfXA89m2qFL1Mmn8XZzlf16P2CrWc EmUxyTEWC2vUlpkD7ndVrlSYkdV1ad0uM/3fgHb+o7esk22/40R6dllluPai1N7pLu5W 3BkVbHSvuKEK5rM5CoHBM1i1NdgIIHgUMhuWS2MD8DhIlWNiaVSXTw3t2ny16Bu/A+D8 jKdw== X-Gm-Message-State: AOAM531BKt1f99D15mSmOJuYqthkwcMccLmnzzqyv1EE7Bl3NA5q4RjP l0ysIKKDHpBjzMS1GFDcIyuaNbT2arE+4rO3j8s= X-Google-Smtp-Source: ABdhPJxtqwmvRRpF5UdraEaYqkbEPH1pBfqQN1KWL9GH4tS/12XBtucI3PuCsuMxOrzqf0uNBRzL3fIuLzZilbJIv2w= X-Received: by 2002:a05:6e02:1350:: with SMTP id k16mr7662179ilr.213.1592660399447; Sat, 20 Jun 2020 06:39:59 -0700 (PDT) MIME-Version: 1.0 References: <20200518115853.3468-1-hjl.tools@gmail.com> <6696000c-63b6-949a-1203-e696c1d743d0@suse.cz> <210e1e83-0d4c-ee59-71c0-07671d80a1ad@suse.cz> In-Reply-To: From: "H.J. Lu" Date: Sat, 20 Jun 2020 06:39:23 -0700 Message-ID: Subject: Re: PING^2: V5 [PATCH] x86: Move cpuinfo.h from libgcc to common/config/i386 To: =?UTF-8?Q?Martin_Li=C5=A1ka?= , Uros Bizjak , GCC Patches Cc: Jan Hubicka , Jakub Jelinek , Jeffrey Law , Richard Biener Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2020 13:40:01 -0000 On Tue, Jun 16, 2020 at 10:11 AM H.J. Lu wrote: > > On Tue, Jun 9, 2020 at 9:35 AM H.J. Lu wrote: > > > > On Tue, May 26, 2020 at 6:27 AM Martin Li=C5=A1ka wrot= e: > > > > > > On 5/26/20 1:59 PM, H.J. Lu wrote: > > > > On Tue, May 26, 2020 at 2:30 AM Martin Li=C5=A1ka = wrote: > > > >> > > > >> On 5/25/20 7:42 PM, H.J. Lu wrote: > > > >>> Here is the updated patch. OK for master? > > > >> > > > >> Thank you for the updated patch. > > > >> > > > >> I have still few nits: > > > >> > > > >> 1) I would make all the: > > > >> > > > >>> + has_sse3 =3D has_feature (FEATURE_SSE3); > > > >> > > > >> a macro. The local variable seems to superfluous. > > > > > > > > Done. > > > > > > Thanks! > > > > > > > > > > >> 2) can we automatically deduce option name: > > > >> > > > >>> + ISA_NAMES_TABLE_ENTRY("rdpid", FEATURE_RDPID, P_ZERO, "-mrdpid= ") > > > >>> + ISA_NAMES_TABLE_ENTRY("rdrnd", FEATURE_RDRND, P_ZERO, "-mrdrnd= ") > > > >> > > > >> I mean "-m" + "rdrnd" =3D=3D "-mrdrnd" ? > > > > > > > > The new option field serves 2 purposes: > > > > > > > > 1. Not all features have a corresponding command-line option > > > > > > > > ISA_NAMES_TABLE_ENTRY("cmov", FEATURE_CMOV, P_ZERO, NULL) > > > > > > > > for (i =3D 0; i < ARRAY_SIZE (isa_names_table); i++) > > > > if (isa_names_table[i].option) > > > > > > > > 2. Some feature has a different name in the command-line option. > > > > > > > > ISA_NAMES_TABLE_ENTRY("fxsave", FEATURE_FXSAVE, P_ZERO, "-mfxsr"= ) > > > > > > I noticed that, one can theoretically use "" for an option that does = not > > > have a flag. And NULL for these which have option equal to "-m" + nam= e. > > > Anyway, that's a nit. > > > > > > I support the patch! > > > Martin > > > > > > > > > > > Here is the updated patch. OK for master? > > > > > > > > Thanks. > > > > > > > > > > > PING: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/546522.html > > > > PING. Hi, We have patches like https://gcc.gnu.org/pipermail/gcc-bugs/2020-June/705851.html queued up because of this prerequisite patch. Are there any objections to this patch? --=20 H.J.