From: "H.J. Lu" <hjl.tools@gmail.com>
To: Ilya Enkovich <enkovich.gnu@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Maxim Kuvyrkov <maxim@codesourcery.com>
Subject: Re: [PATCH, i386, Android] Add Android support for i386 target
Date: Mon, 16 Apr 2012 16:15:00 -0000 [thread overview]
Message-ID: <CAMe9rOrzmGUkjW13mVgJvzNtMMAMGvPYj4Uw+gEss4jMK=NgFw@mail.gmail.com> (raw)
In-Reply-To: <CAMbmDYYKaswyycfwJMXyXbQGjm-fQ-i6VEvgoro02xhAYt5z+g@mail.gmail.com>
On Mon, Apr 16, 2012 at 9:08 AM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
>> On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
>>>>
>>>> Maybe it is better to break it into 2 patches:
>>>>
>>>> 1. Introduce config/i386/linux-common.h with any new functionalities
>>>> 2. Add Android support.
>>>>
>>>> Thanks.
>>>>
>>>>
>>>> H.J.
>>>> ---
>>> Hi,
>>>
>>> The first part will just add empty file. What is the reason to do it?
>>> Testing will not even reveal if I added it incorrectly.
>>>
>>
>> It should contain everything, minus any new Android changes,
>> which should be in the second patch.
>
> It has nothing but defines for Android. It did not move any existing
> code to this file.
>
Adding linux-common.h to i386 backend needs approval from
i386 backend maintainer. If a patch also adds Android support,
i386 backend maintainer may not feel comfortable to review it.
However, if you simplify add linux-common.h with XXX_SPEC,
i386 backend maintainer can review it easily.
--
H.J.
next prev parent reply other threads:[~2012-04-16 16:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 15:34 Ilya Enkovich
2012-04-16 15:38 ` H.J. Lu
2012-04-16 16:01 ` Ilya Enkovich
2012-04-16 16:06 ` H.J. Lu
2012-04-16 16:08 ` Ilya Enkovich
2012-04-16 16:15 ` H.J. Lu [this message]
2012-04-17 10:16 ` Ilya Enkovich
2012-04-17 13:16 ` Uros Bizjak
2012-04-17 13:22 ` Uros Bizjak
2012-04-17 14:32 ` Ilya Enkovich
2012-04-17 19:49 ` Maxim Kuvyrkov
2012-04-18 8:33 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMe9rOrzmGUkjW13mVgJvzNtMMAMGvPYj4Uw+gEss4jMK=NgFw@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=enkovich.gnu@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=maxim@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).