From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2e.google.com (mail-vs1-xe2e.google.com [IPv6:2607:f8b0:4864:20::e2e]) by sourceware.org (Postfix) with ESMTPS id 30D1B383A62F for ; Sun, 29 May 2022 05:04:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 30D1B383A62F Received: by mail-vs1-xe2e.google.com with SMTP id i186so7884381vsc.9 for ; Sat, 28 May 2022 22:04:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AjtZfopUvvSLwYw07dhmPzt7Y4rlv8cxIHOl1Zf0rd0=; b=jjE8GH7PNvRrsjDk+S7VX3etzvcl4TxrAGVfgR7PKZH51hUmPgUyc7qxz/gfw73pU3 FY4uALi02Yl7YKuRcONFtiH5kZV8I7fVdsDrGKVRCSX2EMN9LcfTGxrYHRXZC9kWxpyt Lnxy6yohnh36XCfoh7LDAe51eoip46WvU9BoeEc9V0VZHunao42fXwRHoWiPr4c99obr M1aTsiKlvovBQnBsbh1yu2lrOVSaD37Wml2vXJr1xt4yOv+fZIlSIAfa9tOq5c+V5uzg 7oftFRdz3C6eNyX9JfSJk4aSOy/tcgB8BCAMsEj60b0UW0gyA1ts+ONOUpEMV6e6Przm OonA== X-Gm-Message-State: AOAM531eKJtk5FVO/3Va3xOC7STg3bXAa7ITR4O24B/dmDPbEaPAjS75 ez9doKbWRfo4iCNqj9xHQ8EZxBbb6xh3pIy2rS9q0veiQHUYFw== X-Google-Smtp-Source: ABdhPJycinAP1nQcphowH48nVtD/87eH4NzeFSTpimT8RFm0nBEIKqtdPnpPhr1xpgg6qtGXEItx1QYLYwu0qg/Tw48= X-Received: by 2002:a05:6102:9d1:b0:32c:be9e:11bb with SMTP id g17-20020a05610209d100b0032cbe9e11bbmr19684884vsi.28.1653800667494; Sat, 28 May 2022 22:04:27 -0700 (PDT) MIME-Version: 1.0 References: <4bddccab-1713-6691-920b-0bf5a20a7efb@gmail.com> In-Reply-To: <4bddccab-1713-6691-920b-0bf5a20a7efb@gmail.com> From: Eric Gallager Date: Sun, 29 May 2022 01:04:16 -0400 Message-ID: Subject: Re: [PATCH] sourcebuild.texi: Document new toplevel directories [PR82383] To: Jeff Law Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 May 2022 05:04:30 -0000 On Sat, May 28, 2022 at 2:30 PM Jeff Law via Gcc-patches wrote: > On 5/24/2022 11:32 AM, Eric Gallager via Gcc-patches wrote: > > This patch adds entries for the c++tools, gotools, libbacktrace, > > libcc1, libcody, liboffloadmic, and libsanitizer directories into the > > list of toplevel source directories in sourcebuild.texi. I also > > removed the entry for boehm-gc (which is no longer in-tree), and fixed > > the alphabetization for libquadmath while I was at it. Any style nits > > I need to fix before committing (with a proper ChangeLog entry)? > I think this is fine. If you're looking for a good cleanup, removing > liboffloadmic would be useful IMHO. MIC is dead. > OK thanks, committed as r13-817. I'll leave removing the liboffloadmic directory for someone else to do, as it still has stuff in it.