From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id B278A3858D37 for ; Mon, 23 Oct 2023 05:19:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B278A3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B278A3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::930 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698038356; cv=none; b=HhubiObTStrpKA3Qmfuc6+ZEFEDCuqf1v5pzwtFLMnGWggNM5v9HIFleocAWHl/5Gu+2wL3j8kyFWz3dSQ079xjYKfiUZsaXf4YwF88sRg75TWi0KUMBwQgOXNt0yFkWe/iPR0nfsonz0rUyiBjLidz19xJpyA+7uqwuNIyNJT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698038356; c=relaxed/simple; bh=mFKt7L7wuhL66EeEuz2kd/XC4lPLt/D8+rze0MK8MV4=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=meHtgeLqdWzCZCK7czav0Dv6rNv8FQmTQzcFX8eyFQtcuNYKfDV5Re8AK65jKq8yGTJa/O3+FadfPk5FF5Pus876cXNSnbvypCiRZ5DGHrhWHSKTIGI9bsVTy9BrIec84k+eI/5qPVFQGVaf4u6hLe/ZPmUnt53b9cuMeTlEYAg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-7b7205bc5a3so899130241.2 for ; Sun, 22 Oct 2023 22:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1698038354; x=1698643154; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DPKNsYw47vEU08LvLMgxXuyAW0YiYMmyg4gd050CiD0=; b=cNFeup0ck8frd9Kjep3t9EMtMduw1/d1xOFTkmWl28mYowQ+iMOgDX++5KjhEToe0Z YDpQDqb86C8opaYaIReyAOwcB3ZIPMLGQ6LAl8tdWSBMhlcLTTiZcgjrmpc6kuUVEN0g zrB2dtPvIeRgrZ5ZiORP4c2chFlWkyROaEWGakuuKOByNYHDFYGUMztzv6070TKEMC9W 2J+mr5q2Fk254BMjAzjqAuLnMQisYbn3xh/5wKO0SOinMOLBVBLJ3oYhI6wGrExeqsqe jc5Qcl8TNntEybbnw7DMe/YVOr5OAKe0oH7EfE6xgV5scmPHzDGfJb0xPsUD7RDtMS91 pBng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698038354; x=1698643154; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DPKNsYw47vEU08LvLMgxXuyAW0YiYMmyg4gd050CiD0=; b=DbB6bwoAgi5KHkjgodvER7U9OfgbNlqqqwO10BH6hvEOPsGdBMjU00IuUI9G68l/pj zr827EWYvCzo7M7JMkp6+hrH/Ig3tGDzcex1+ieKRFvvDSBVDlMb2tmAvmAcaq9Z4DnE uG6WS6m+t2WaGurcMPUrrFJc59k2FzT5AUzk3vQYNpmnYdApxwwk9DN61mZ4PrWPsmQm W+vMY/i/vBjrJAei8wZTRg8IKgOqkPc4pV21rJ8fzTnk2LbLQW29y6uXmwKLU73vOCzM 1niuWhRrehOJEcnfMWpwm3eNgmM55N33JSnX/NVBVWTofN+VeKu9NnZBY0kaiRVU+/5J /lHQ== X-Gm-Message-State: AOJu0Yzw0UM0hsR+i9d8ld7X29vxsuAsYroX/pl3+cMLAu3jUW5ypI99 y7OjHaotpJQXreTtxPTkqYMPez2hs6TzazL7GblG3A== X-Google-Smtp-Source: AGHT+IEh6O5HX3O6bl7YbAamdDTtMciz3awzt2ARYdDjbYU12YPU+XbGQCu2nw5h2MHEdeM5mI/xBn2w4BcOndf5v3Q= X-Received: by 2002:a67:c003:0:b0:457:e2cf:2a6 with SMTP id v3-20020a67c003000000b00457e2cf02a6mr8088241vsi.8.1698038354028; Sun, 22 Oct 2023 22:19:14 -0700 (PDT) MIME-Version: 1.0 References: <8718a8a3-1e62-0e2b-09d0-7bce3155b045@roeck-us.net> <20230906215327.18a45c89@gandalf.local.home> <4af7c904-ac36-44c9-83c4-2cb30c732672@kadam.mountain> <20230907110409.GH19790@gate.crashing.org> <20230907123016.GJ19790@gate.crashing.org> In-Reply-To: From: Eric Gallager Date: Mon, 23 Oct 2023 01:19:02 -0400 Message-ID: Subject: Re: [MAINTAINERS/KERNEL SUMMIT] Trust and maintenance of file systems To: Richard Biener Cc: Segher Boessenkool , Dan Carpenter , Steven Rostedt , Dave Chinner , Guenter Roeck , Christoph Hellwig , ksummit@lists.linux.dev, linux-fsdevel@vger.kernel.org, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 12, 2023 at 5:53=E2=80=AFAM Richard Biener via Gcc-patches wrote: > > On Thu, Sep 7, 2023 at 2:32=E2=80=AFPM Segher Boessenkool > wrote: > > > > On Thu, Sep 07, 2023 at 02:23:00PM +0300, Dan Carpenter wrote: > > > On Thu, Sep 07, 2023 at 06:04:09AM -0500, Segher Boessenkool wrote: > > > > On Thu, Sep 07, 2023 at 12:48:25PM +0300, Dan Carpenter via Gcc-pat= ches wrote: > > > > > I started to hunt > > > > > down all the Makefile which add a -Werror but there are a lot and > > > > > eventually I got bored and gave up. > > > > > > > > I have a patch stack for that, since 2014 or so. I build Linux wit= h > > > > unreleased GCC versions all the time, so pretty much any new warnin= g is > > > > fatal if you unwisely use -Werror. > > > > > > > > > Someone should patch GCC so there it checks an environment variab= le to > > > > > ignore -Werror. Somethine like this? > > > > > > > > No. You should patch your program, instead. > > > > > > There are 2930 Makefiles in the kernel source. > > > > Yes. And you need patches to about thirty. Or a bit more, if you want > > to do it more cleanly. This isn't a guess. > > > > > > One easy way is to add a > > > > -Wno-error at the end of your command lines. Or even just -w if yo= u > > > > want or need a bigger hammer. > > > > > > I tried that. Some of the Makefiles check an environemnt variable as > > > well if you want to turn off -Werror. It's not a complete solution a= t > > > all. I have no idea what a complete solution looks like because I ga= ve > > > up. > > > > A solution can not involve changing the compiler. That is just saying > > the kernel doesn't know how to fix its own problems, so let's give the > > compiler some more unnecessary problems. > > You can change the compiler by replacing it with a script that appends > -Wno-error > for example. I personally would find the original proposal of an IGNORE_WERROR environment variable much simpler than any of the alternative proposed solutions, especially for complicated build systems where I can't tell where the "-Werror" is getting inserted from. Often times I'm not actually the developer of the package I'm trying to compile, so saying "fix your code" in such a case doesn't make sense, since it's not actually my code to fix in the first place. It would be much easier for end-users in such a situation to just set an environment variable, rather than asking them to try to become developers themselves, which is what some of these alternative proposals (such as "write your own script!") seem to be asking. > > > > > Or nicer, put it all in Kconfig, like powerpc already has for examp= le. > > > > There is a CONFIG_WERROR as well, so maybe use that in all places? > > > > > > That's a good idea but I'm trying to compile old kernels and not the > > > current kernel. > > > > You can patch older kernels, too, you know :-) > > > > If you need to not make any changes to your source code for some crazy > > reason (political perhaps?), just use a shell script or shell function > > instead of invoking the compiler driver directly? > > > > > > Segher > > > > Segher