On Tue, Oct 12, 2021 at 3:56 PM Eric Gallager wrote: > > On Tue, Oct 12, 2021 at 9:18 AM Jeff Law wrote: > > > > > > > > On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: > > > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager wrote: > > >> On 10/13/16, Jeff Law wrote: > > >>> On 10/06/2016 07:21 AM, Eric Gallager wrote: > > >>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS > > >>>> targets in their Makefiles. The attached patch causes them to be > > >>>> skipped when running `make tags`. > > >>>> > > >>>> ChangeLog entry: > > >>>> > > >>>> 2016-10-06 Eric Gallager > > >>>> > > >>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing > > >>>> TAGS target. > > >>>> * Makefile.in: Regenerate. > > >>>> > > >>> OK. Please install. > > >>> > > >>> Thanks, > > >>> Jeff > > >>> > > >> > > >> I'm still waiting to hear back from about my request > > >> for copyright assignment, which I'll need to get sorted out before I > > >> can start committing stuff (like this patch). > > >> > > >> Thanks, > > >> Eric > > > Update: In the intervening years, I got my copyright assignment filed > > > and have recently become able to commit again; is your old approval > > > from 2016 still valid, Jeff, or do I need a re-approval? > > > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html > > It's still valid. Just re-test and commit. > > > > jeff > > While re-testing, it seems that the `etags` command on my computer > can't be found any longer; I'm thinking gcc/Makefile.in should be > updated to stop hardcoding etags and use a variable that can be > overridden instead... should I do a separate patch for that, or > combine it with this one? Well, anyways, this is what I've ended up committing for now: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=4ca446a46bef8c127d7aaeb2d4bb4625edc7f84e