From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 76A6B3858C54 for ; Sun, 28 Jan 2024 21:26:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 76A6B3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 76A6B3858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::82e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706477167; cv=none; b=AEmODiJjW2gZGoqFvdV2IrPSDcovXNDzEJxjGiUNS28H32NpD1jJD1FTL8xevveY0gmuVgfh9akH8dl1VlORFInrkwZTfJIsOd1rfqzcpt2uyvBvAGH17nQ62HyDbMjtHDOcNCjmx6jZNoXljyRh7Qeph9CBFRLdjjsYVnMyWRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706477167; c=relaxed/simple; bh=uS4mN9jpYsXxZ4bs1E+kJGFSGprKTnj9ZQWhTEe+9KI=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=N4GO+oXklVbsOLt/CIVN6cZX+ad/lXliQpc2wzmiWADHqp21pI/quh6KKFuO6K+cckkl9MAb1fBXvbs7ihdffnrpfDuUn/qjBJXMT+fwJwzSlmJm8ZCBD2dEPA44bWlyTTucRQOM6RpMdSV4dH0eboMKo8ugARk8e7N0dr7CdcQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qt1-x82e.google.com with SMTP id d75a77b69052e-42a8a398cb2so21013191cf.1 for ; Sun, 28 Jan 2024 13:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1706477165; x=1707081965; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H3D/hky/YDJAyRYqBJl3GP9jwnEaSybojX+GGXgjfXI=; b=IBo3WPgseMW+CjzWhc0o/VcftjGUBabnu3Tz99YqebQywDLMsRVyC8/cQCzQNpbWqf WE/Pv7s3BU7LC+J+s08TZNtuqWmoKS3/VQDVRSscuR2aSXhODpvs1fuOBK8fLKqK83ok JU/fTVtEAU87ehb5RjMAWXG3h+45OpMCaL6JBJ9LKrGFK+x5jvI71hA6qknMS+QL/hT5 8a/x5sJf0JcY/+8hxOl6ezmS8YyUBfMnYjwfjuF4U5/83OsWZCJBSQ4TK1NngzzjaK4a CblOkW6Lmlus5H3H21e4yuLzScJyZAxYmdwY2OUhmHMI+y2A09cK3Hs9SO/iS02YbWkn DAKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706477165; x=1707081965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H3D/hky/YDJAyRYqBJl3GP9jwnEaSybojX+GGXgjfXI=; b=q7SGHFDwnQYKlNYhUfq/0K5Ft8JHF4lNUgoV1jh2FGXuz7227fJW/skpHHbF3hUBjL PPqtqQireIH0+X5Llmcf/FhtBh2VtqfV92f84bYu7hIVBBpO60sl6NuSCWJ++bvchqVu X61iTJwi5CLW/L7BNkEozoz4I1FCxPrIzjwtmSzJ5sMM2FuCsFqsCIIhetIrqO38XdvV S3HtQ3mgAlasbs/xkdP22SJbW083eX30rz0rMX4g/t+MVdzUh+IRiFS4hD8CwQ5w2f1c SegtEOOGWuOaQkkFdnEhPq0PeCdpVVTfcjWRcnlCstY3EkORoV8DygR7V+1K4/25UAck /FFw== X-Gm-Message-State: AOJu0YxFAeC+5M9g8TNGityTTRr95Q6mnNa/v8fAV6/LiunEkgkejUi0 9jFodRQLpI0pDzZoCEibcGPoadXa7Gpqb33twUOF4NmsL9L9gI3IL0xQjHwLKYpXBF4z7LPvyo0 c+CFO8aQlnzxsGJZe9NH04ZUQ8CTl1g6IwHKd X-Google-Smtp-Source: AGHT+IGsDQQNGFbCx6B8IAk1sBHMAMttXfnhQiCzEaGWaClOy0/0xY980EaX7nuw/MzTpJWttnz1gdivPA4TOaAOGhM= X-Received: by 2002:a05:6214:1bce:b0:685:2a3c:f732 with SMTP id m14-20020a0562141bce00b006852a3cf732mr5137333qvc.75.1706477164685; Sun, 28 Jan 2024 13:26:04 -0800 (PST) MIME-Version: 1.0 References: <20240128114424.35213-1-iain@sandoe.co.uk> In-Reply-To: <20240128114424.35213-1-iain@sandoe.co.uk> From: Eric Gallager Date: Sun, 28 Jan 2024 16:25:53 -0500 Message-ID: Subject: Re: [PATCH] jit: Ensure ssize_t is defined. To: iain@sandoe.co.uk Cc: gcc-patches@gcc.gnu.org, dmalcolm@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jan 28, 2024 at 6:45=E2=80=AFAM Iain Sandoe w= rote: > > Tested on i686, x86_64 Darwin, x86_64 Linux, > OK for trunk? > > --- 8< --- > > On some targets it seems that ssize_t is not defined by any of the > headers transitively included by . This leads to a bootstrap > fail when jit is enabled. > > The fix proposed here is to include sys/types.h when it is available > since that is where Posix specifies that ssize_t is defined. > > gcc/jit/ChangeLog: > > * libgccjit.h: Conditionally include where it is > available to ensure declaration of ssize_t. > > Signed-off-by: Iain Sandoe > --- > gcc/jit/libgccjit.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gcc/jit/libgccjit.h b/gcc/jit/libgccjit.h > index 235cab053e0..db4f27a48bf 100644 > --- a/gcc/jit/libgccjit.h > +++ b/gcc/jit/libgccjit.h > @@ -21,6 +21,9 @@ along with GCC; see the file COPYING3. If not see > #define LIBGCCJIT_H > > #include > +#if __has_include() Is __has_include() something that we can use unconditionally? > +# include /* For ssize_t. */ > +#endif > > #ifdef __cplusplus > extern "C" { > -- > 2.39.2 (Apple Git-143) >