From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by sourceware.org (Postfix) with ESMTPS id 93F7E3858D3C for ; Wed, 17 Apr 2024 17:16:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93F7E3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93F7E3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::c2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713374217; cv=none; b=KQ86wZc7aWOAMRtXvdo0FluQVTuGZ7uYwDd06mHhdfu2Cz4pnek66e3/mACk9NHbCIp4FMzf2vcRhvfNls4fT+Rfu+97LiIlJwr/KfgtqYRmgaLLHnBc+zoB7u5jLZYo4aXdtzW22KpsjP8TBocVDCaOUksPY2l3sA0u9XQ2kEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713374217; c=relaxed/simple; bh=eGdI8udDA0zCY6DNBnNCZk3nIYkEU/kRLsSw3i8pl64=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SJT0tPbjFGWBn+jj/zLYKLkvts27dOzAAZUYUUbYomsoHlNAb6i18LDSsK1U2nzFceZkDnjuEDVcSbOgRXU267oIQzDzb4p1d+7vlw6DSxC4ThNIRMkXOTSk5GB7rGK4WWvA07fdij1zSpIdZNjtuEFYExFnztv3eJ8hMlorRhg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oo1-xc2e.google.com with SMTP id 006d021491bc7-5aa27dba8a1so3662278eaf.0 for ; Wed, 17 Apr 2024 10:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1713374215; x=1713979015; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0QW0NVyK1mKYk5XKDSk42U8WUi0mlTOxN3AjPRo/8mo=; b=KKJeB3LTOCexgunhAB9pEe3X0inep4jxMUCY5r9OZO7SUxzblrcuFEow5UPqW94V0g H3Jn/9eYm4YrnyAVkyoK+R54iN7pnz+L5eTQEC7ZYqurlQp4qA8TAUyv9OamHuATanPX 6Yys6dbaUv5HSXD6UUlEiimeYeTXJOHtuqdAKPkYGMLzmPHaAXDZ1PsHvo55zrHOObin xGcuI61Ly9YEd31FxgyuC72jOlDLmnkpqmGTP940O1mEB2Vfgp4HJNBaRjG9foDphdJ8 rCkIAHPCMMxtroXi/TJWDvcHW4NspwXuBjnSt+2NMOR925FHaDizivSTDGrvAJVJSoUA wUGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713374215; x=1713979015; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0QW0NVyK1mKYk5XKDSk42U8WUi0mlTOxN3AjPRo/8mo=; b=jMJnH5t2isokryXLcEt8/ZAxoWh616lFDIMzC56aOvHNRnMRmZUxLbmOMkdyEFFWQ/ pWbVTZ9IpmXXqkn8fPMnNijJ7+fjb+eUhnXEQ9H+Ss6Nzj1un5Nw3/C98wwbRez6ZmYu 6ZvhvHBCgz6OyC/SK8hsCORhcSF88w9Up8UOShIzu4QJcoD+j/1R0rH7IDbMQmuh4O3W YSY7PLB7E6PIGCTh1TJgmcjuUd1IcOyJZpQr4U3uXRyoVOSaOZuTVE/xeRF4SAsXjcy2 VVuGSqOKCXoUPaikrM0sm1ciK5x8UgCiXM2lowqLXaTwQv+nhUkjeW3e7VsJBF1Wm0uz mE7g== X-Gm-Message-State: AOJu0YwYkUCOKIFriEwTFdWaAM2Kdxx++6KQafs/42XCuMZu29qygd/G uHVJvhWX8U3srT+AtzXnwchJAFio8xB/VnDa3NK/C8le75+KjMLU0+quvbyPG71VIWoTORnihwK j5J+hyMcBdBFDXEaaRGZjUdg9sWab57ORXxTy X-Google-Smtp-Source: AGHT+IFWH/0jox1CHd4fWzJtH5+28jYjgaRIwChiBcRorIneMaTIP4aoHZQtm2i8x3a7JpLmZuGsqUktxo7GlpPneGY= X-Received: by 2002:a05:6358:2510:b0:17c:263a:5b8e with SMTP id m16-20020a056358251000b0017c263a5b8emr17562658rwb.14.1713374214798; Wed, 17 Apr 2024 10:16:54 -0700 (PDT) MIME-Version: 1.0 References: <20240417140155.2062332-1-christophe.lyon@linaro.org> In-Reply-To: <20240417140155.2062332-1-christophe.lyon@linaro.org> From: Eric Gallager Date: Wed, 17 Apr 2024 13:16:43 -0400 Message-ID: Subject: Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748] To: Christophe Lyon Cc: gcc-patches@gcc.gnu.org, jakub@redhat.com, pinskia@gcc.gnu.org, arsen@gcc.gnu.org, dmalcolm@redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 17, 2024 at 10:03=E2=80=AFAM Christophe Lyon wrote: > > As discussed in the PR, aclocal.m4 and configure were incorrectly > regenerated at some point. > > 2024-04-17 Christophe Lyon > > PR preprocessor/114748 > libcpp/ > * aclocal.m4: Regenerate. > * configure: Regenerate. > --- > libcpp/aclocal.m4 | 1 + > libcpp/configure | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/libcpp/aclocal.m4 b/libcpp/aclocal.m4 > index 4fc81709622..4d898ea2c97 100644 > --- a/libcpp/aclocal.m4 > +++ b/libcpp/aclocal.m4 > @@ -26,6 +26,7 @@ m4_include([../config/lib-ld.m4]) > m4_include([../config/lib-link.m4]) > m4_include([../config/lib-prefix.m4]) > m4_include([../config/nls.m4]) > +m4_include([../config/override.m4]) > m4_include([../config/po.m4]) > m4_include([../config/progtest.m4]) > m4_include([../config/warnings.m4]) > diff --git a/libcpp/configure b/libcpp/configure > index 8a38c0546e3..32d6aaa3069 100755 > --- a/libcpp/configure > +++ b/libcpp/configure > @@ -2670,6 +2670,9 @@ ac_compiler_gnu=3D$ac_cv_c_compiler_gnu > > > > + > + > + So, this is kind of a minor style nitpick, but personally, it kind of bothers me when autotools goes and inserts a bunch of unnecessary blank newlines in the generated output scripts. Does anyone else think it'd be worth it to scatter around some of m4's "dnl" comments in the configure.ac scripts, to get autoconf to eat the unnecessary newlines? Just an idea, Eric Gallager > ac_aux_dir=3D > for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do > if test -f "$ac_dir/install-sh"; then > -- > 2.34.1 >