From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by sourceware.org (Postfix) with ESMTPS id 913623836662 for ; Sat, 11 Jun 2022 14:23:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 913623836662 Received: by mail-vs1-xe2f.google.com with SMTP id d39so1834493vsv.7 for ; Sat, 11 Jun 2022 07:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WHwiQWqO9+VqniEXevShlupfJ13PWDJdhTd6Czw3+Ag=; b=UjIQFA8RHJ8CCM7c2NnE9p6yKSxt4fnT76MwmyRniUekYSbVzhUWLEJIwazAvt1A69 bq8Y1K2r9uf21OIdtNyyQYmfBxXBfUt066ipKSvbRY75v02Nv799h8te8Qo/hKB7dzUA LDnqU2d4R+JipvyURX9lsT6akPYe9Ti19U9PFU3zj7DToPrGTbSfQhvqI6Bvqs9WUvpt 4MF5V7239kK6Yqep+yBCG6H63UzG0AC89AMP6hY0/9eQ/YffNOcEruQBpoF7k4L6D/1x 3KAruSe0Z7dZs/qe7gRZYsRjkMSJXkGRPvgb/ALOsur4Iol4YJI3qmLI3biefcVODho+ QP6Q== X-Gm-Message-State: AOAM530e8p9TGT2F6PhRYuiXoeuN7dwAZH8hCsdPql7Y3cnoGpayrDEt 7laGTGoVqVbVI825iMHHz4NS9AxEW/heZDbJN+B+qA== X-Google-Smtp-Source: ABdhPJzMhtjDjuXJBD/gDkN6xx6gbnh97HJA9Gil5zpBVBDaP9C/xyoLcp2zNqP1XBZ53vceRLmJc5V1heiAB6xXNYY= X-Received: by 2002:a05:6102:3e23:b0:34b:b6b0:2ae7 with SMTP id j35-20020a0561023e2300b0034bb6b02ae7mr14874090vsv.81.1654957404858; Sat, 11 Jun 2022 07:23:24 -0700 (PDT) MIME-Version: 1.0 References: <6b83d5a42ee91313c2d37da1f55a08819258e589.camel@xry111.site> In-Reply-To: <6b83d5a42ee91313c2d37da1f55a08819258e589.camel@xry111.site> From: Eric Gallager Date: Sat, 11 Jun 2022 10:23:13 -0400 Message-ID: Subject: Re: [PING][PATCH][WIP] have configure probe prefix for gmp/mpfr/mpc [PR44425] To: Xi Ruoyao Cc: gcc-patches , Paolo Bonzini , aoliva@gcc.gnu.org, neroden@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2022 14:23:32 -0000 On Fri, Jun 10, 2022 at 7:22 AM Xi Ruoyao wrote: > > On Thu, 2022-06-09 at 16:04 -0400, Eric Gallager via Gcc-patches wrote: > > Hi, I'd like to ping this patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596126.html > > (cc-ing the build machinery maintainers listed in MAINTAINERS this > > time) > > > > On Thu, Jun 2, 2022 at 11:53 AM Eric Gallager > > wrote: > > > > > > So, I'm working on fixing PR bootstrap/44425, and have this patch to > > > have the top-level configure script check in the value passed to > > > `--prefix=` when looking for gmp/mpfr/mpc. It "works" (in that > > > configuring with just `--prefix=` and none of > > > `--with-gmp=`/`--with-mpfr=`/`--with-mpc=` now works where it failed > > > before), but unfortunately it results in a bunch of duplicated > > > `-I`/`-L` flags stuck in ${gmplibs} and ${gmpinc}... is that > > > acceptable or should I try another approach? > > > Eric > > A patch should not edit configure directly. configure.ac should be > edited and configure should be regenerated from it. > That is precisely what the patch does: it edits configure.ac and regenerates configure from it. > -- > Xi Ruoyao > School of Aerospace Science and Technology, Xidian University