From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by sourceware.org (Postfix) with ESMTPS id BA26F3858CDB for ; Wed, 3 Aug 2022 11:51:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA26F3858CDB Received: by mail-vk1-xa29.google.com with SMTP id e3so6430714vkg.4 for ; Wed, 03 Aug 2022 04:51:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YS/BpSQCwbAzQk3pevf0ZCdds//onv8gxwQSNPOW0mE=; b=E2lh75nU/O+hw0XwQmGfH0p2A0BEonTr6aXCuP9lJqTUwzSULY4Gmm4jQ5NHCZ6LtS H85lPbl+C5HaZ37QqJiyV1I2k1dbMiP6Iazn7BSIDLZsFva3ONGeWKREQ4euWvTwxLNx DkqQw5xjSrJn1YdKeN1ZAvlQ/Fkpey3trObqphbAIbaroA0dkgbYZADNTmPCI3DwAi3c kLRnxAYxZrShjGYAbG+CERJcTyQIeHrt+T3Z72CXbcKTHRPM2oW50bNw1Taex0+tSCvf LHS1/BsgpLHThmnbfvOaQXRWk168/hY4GdL5HZuWg53JlBxSm4f4+B1aZ14PI3OmitbZ fsvQ== X-Gm-Message-State: ACgBeo1OQgdK7z9fRudMdcez939c+fMSPiN4/oaEgU3zdlONHIpuxnEY 0pK+6ez1aPd+thTgtScGQgcMq6CsZw3U/AyWQHELRA== X-Google-Smtp-Source: AA6agR4NjhNDHXefgiBVWz+DmylxFpI9mSQqyKPzR4+92xSX868wXDqj7rfjYFx76imriAlsvFmJkhA67cYZUFRoa4E= X-Received: by 2002:a1f:2012:0:b0:377:1f9e:57c6 with SMTP id g18-20020a1f2012000000b003771f9e57c6mr9025790vkg.16.1659527518136; Wed, 03 Aug 2022 04:51:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Gallager Date: Wed, 3 Aug 2022 07:51:46 -0400 Message-ID: Subject: Re: [PATCH] configure: respect --with-build-time-tools [PR43301] To: Alexandre Oliva Cc: Eric Gallager via Gcc-patches , Andreas Schwab , Paolo Bonzini , neroden@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2022 11:52:00 -0000 On Tue, Aug 2, 2022 at 11:33 PM Alexandre Oliva wrote: > > On Aug 2, 2022, Eric Gallager wrote: > > > On Tue, Aug 2, 2022 at 1:24 AM Alexandre Oliva wrote: > > >> -elif test -x as$build_exeext; then > >> +elif test -x as$build_exeext \ > >> + && { test "x$build_exeext" != "x" \ > >> + || test "x`grep '^# Invoke as, ld or nm from the build tree' \ > >> + as`" = "x"; }; then > >> > >> WDYT? > > > Hi, thanks for the feedback; I'm a bit confused, though: where exactly > > would this proposed change go? > > gcc/configure.ac, just before: > > # Build using assembler in the current directory. > gcc_cv_as=./as$build_exeext > OK, after reviewing the surrounding code, I think it makes sense; do you want to commit it, or should I? Thanks, Eric > -- > Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ > Free Software Activist GNU Toolchain Engineer > Disinformation flourishes because many people care deeply about injustice > but very few check the facts. Ask me about