From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id CFB0A3858D28 for ; Tue, 14 Dec 2021 18:33:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CFB0A3858D28 Received: by mail-wr1-x42e.google.com with SMTP id o13so33893628wrs.12 for ; Tue, 14 Dec 2021 10:33:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wCKPHLWWs5srUVW+OKSB2MOd00hMGjhN+OHThjR4W7k=; b=cYqJRJ4awoOfxr0LpQmkjyoN2tznl/iJPWd04fMDFTIPLR5V0fbjjpZAAtrplBs8sy 3iNrNzzLTt3zr1BE781WBaGO+2ZKpLOepdeHCc6NlSK+i4YBXQAEtPtS1Z4igWgnxhNN cR0fqxDF/SmRXZRZg6u03BZeYR/XF6NXDmEiGaU6vK9LJx+unRh4Hiv4jeO8kLpq4Rfn TasTcQz3auxpz/acnhTPenHxJ/TCxjYlBmywllfDIjqrp67f/8c+Egyn3uMlXSMpf4/I 304zzhBm1tKWSjo+CmK4I5hISYrz6W1MygIEq58Pdb7BbT/zQ9akZE367VWvfTTK7RBF APog== X-Gm-Message-State: AOAM532Ed+2CzC5erzefS+n3wI/Nim358Y28uDMSnJu7WNMbuji++zuk +HdaPnJjOXaEYZiaD7Srgvr50Rho/0cEOqfpoo6fYA== X-Google-Smtp-Source: ABdhPJwiaU1Rw6gyIj+Dl3XsrfyufBj/3qh3BZFG8pNUPnTkn0ZukGcS94vWAqVZ9WKEx5ig3X3+V1Uj3BRjSGWWryw= X-Received: by 2002:a5d:58f9:: with SMTP id f25mr789229wrd.206.1639506817758; Tue, 14 Dec 2021 10:33:37 -0800 (PST) MIME-Version: 1.0 References: <87wnkam8qx.fsf@autistici.org> In-Reply-To: From: Eric Gallager Date: Tue, 14 Dec 2021 13:33:26 -0500 Message-ID: Subject: Re: [PATCH] gcc/diagnostic.c: make -Werror message more helpful To: Martin Sebor Cc: Andrea Monaco , gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2021 18:33:41 -0000 On Mon, Dec 13, 2021 at 1:17 PM Martin Sebor via Gcc-patches wrote: > > On 12/12/21 3:13 AM, Andrea Monaco via Gcc-patches wrote: > > > > Hello. > > > > > > I propose to make that message more verbose. It sure would have helped > > me once. You don't always have a Web search available :) > > Warnings turned into errors have the [-Werror=...] tag at the end > so I'm not sure I see when reiterating -Werror at the end of output > would be helpful. Can you explain the circumstances when it would > have helped you? > > For what it's worth, a change here that I think might be more useful > is printing the number of diagnostics of each kind (e.g., 2 warnings > and 5 errors found). > I swear we already had a bug open for this suggestion, but after much searching I can't seem to find it anymore, so if anyone has any ideas of what keywords I forgot to try, feel free to send them... > > Andrea Monaco > > > > > > > > diff --git a/gcc/diagnostic.c b/gcc/diagnostic.c > > index 4ded1760705..8b67662390e 100644 > > --- a/gcc/diagnostic.c > > +++ b/gcc/diagnostic.c > > @@ -156,7 +156,7 @@ default_diagnostic_final_cb (diagnostic_context *context) > > /* -Werror was given. */ > > if (context->warning_as_error_requested) > > pp_verbatim (context->printer, > > - _("%s: all warnings being treated as errors"), > > + _("%s: all warnings being treated as errors (-Werror; disable with -Wno-error)"), > > If this change should move forward, -Werror needs to be quoted > (e.g., passed as an argument to %qs or surrounded in a pair of > %< and %> directives). The "disable with -Wno-error" part > is superfluous and would not be entirely accurate for warnings > promoted to errors by #pragma GCC diagnostic (those cannot be > demoted back to warnings by -Wno-error). > > Martin > > > progname); > > /* At least one -Werror= was given. */ > > else > > >