From: Eric Gallager <egall@gwmail.gwu.edu>
To: gcc-patches@gcc.gnu.org
Cc: ubizjak@gmail.com
Subject: [PING] Re: [PATCH, i386] Fix some warnings/errors that appear when enabling -Wnarrowing when building gcc
Date: Tue, 06 Sep 2016 15:58:00 -0000 [thread overview]
Message-ID: <CAMfHzOt5edm9+3-fn=nOd0eiw3+jY_xavHvDZdFPSjM20w7vLw@mail.gmail.com> (raw)
In-Reply-To: <CAMfHzOsroLrOKkM9RyiS8my5iG9zJ0NHbNPhRrGbuANAFqWBaA@mail.gmail.com>
Ping? CC-ing an i386 maintainer since the patch mostly touches
i386-specific files. Also, to clarify, I say "warnings/errors" because
they start off as warnings in stage 1 but then become errors in stage
2. Note also that my patch leaves out the part where I modify the
configure script to enable -Wnarrowing, because the rest of the code
isn't quite ready for that yet.
On 8/31/16, Eric Gallager <egall@gwmail.gwu.edu> wrote:
> In https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01526.html I tried
> enabling -Wnarrowing when building GCC and produced a log of the
> resulting (uniq-ed) warnings/errors. The attached patch here fixes
> some of them by using the 'U' suffix to make certain constants
> unsigned so they don't become negative when applying the '~' operator
> to them. After applying, there were still some narrowing issues
> remaining that would have required modifying gcc/optc-gen.awk to fix
> properly, but that looked too complicated so I'm avoiding it for now.
> Still, at least by patching the files I did patch, I allowed bootstrap
> to continue a little farther...
>
> Thanks,
> Eric Gallager
>
next prev parent reply other threads:[~2016-09-06 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 15:20 [PATCH] " Eric Gallager
2016-09-06 15:58 ` Eric Gallager [this message]
2016-09-06 17:34 ` [PING] Re: [PATCH, i386] " Uros Bizjak
2016-09-06 18:09 ` Eric Gallager
2016-09-07 15:16 ` Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMfHzOt5edm9+3-fn=nOd0eiw3+jY_xavHvDZdFPSjM20w7vLw@mail.gmail.com' \
--to=egall@gwmail.gwu.edu \
--cc=gcc-patches@gcc.gnu.org \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).