From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by sourceware.org (Postfix) with ESMTPS id BE10E3858D38 for ; Sun, 9 Oct 2022 17:02:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE10E3858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu Received: by mail-ua1-x92e.google.com with SMTP id p4so3243571uao.0 for ; Sun, 09 Oct 2022 10:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vpMX0lNBk3iDcwwWuxP6Ly3lS+S3YXCO4QvmA7EP9F4=; b=EyPQXsRTkJ0XrTZLIldBnujYEE/nrkW5y3CbYakVsAMpUl0HnWD7xyvr/xAZmB2UJP Jzlb2LMU5HbcWUfTY13yfjQAUVCB4fk2EGL8oy7WQ8y2KLreIOibKfIpjxkD36gutBzG +EVUZj1BDc1itVMfe56v8N/xYzGOHlUGwLJnJGuNc23x9zJmgtvuFcHEWMnK69zCpWZW KjNTST4EmTxVaTsXtTX+qjYoWiFeKq8GO4NG07yoDIa5yqFZxTmzkBeqGZF39FsWctuC Nsxd6qNDCJPPF6oT3fuAtTDk5iWGIKK+n3+dpCHXH5iiCOLhfc3KYjz9rY1CH965Xsiy jeqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vpMX0lNBk3iDcwwWuxP6Ly3lS+S3YXCO4QvmA7EP9F4=; b=QspZGJqWzpNYEQ1cpfRFOmC8y9tCha4Xd1CQQOZhGil/bTxzhZdWPErbt1j6KrvToY 6PXuDTVec64tkXzKKhsWX1qOY5vlFxGPbPtMw286bhrDUV2l+0mKy5KzW8FtvLEu660t 2/2JgGTAEaYdqyFAWPdT5sUC228e0PQ06QKE1lmtvJPegjxqXOfUhNQubmGUeWRT2sHh lVdlOAdPOytTMOk/olwE/+3ROQV1Z/479sVrDvWhv0jMM69T7/3e7S8/rhfePjeN7/lL vXWai/OXIZnZINNpAljWjBwJJXypx5KntEXKi6iB1KE8Qj+w+r3m/Dv6K1Qy+PUqqMZS xoFw== X-Gm-Message-State: ACrzQf2iOo+rOL8OXRjeVFLM9XCNK70lG9V3XeQ8tO5DTUdujOF523Jk y7UuBwtFV7QusaY791cEbiYEoMXNRL5qAtDG1DfENQ== X-Google-Smtp-Source: AMsMyM44x9dZjxfcZF5i8gHEzAvUNEUX/XIM2ZLb6Uae9i+qugHzYb71UuIhUALa1jhPJIFzL551gM7trUV8UJnnY+0= X-Received: by 2002:ab0:48c8:0:b0:3d1:fe6:2b1c with SMTP id y8-20020ab048c8000000b003d10fe62b1cmr6923864uac.74.1665334971058; Sun, 09 Oct 2022 10:02:51 -0700 (PDT) MIME-Version: 1.0 References: <20221004152132.GA1906@delia.home> In-Reply-To: <20221004152132.GA1906@delia.home> From: Eric Gallager Date: Sun, 9 Oct 2022 13:02:39 -0400 Message-ID: Subject: Re: [PATCH] Add --without-makeinfo To: Tom de Vries Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Oct 4, 2022 at 11:22 AM Tom de Vries via Gcc-patches wrote: > > Hi, > > Currently, we cannot build gdb without makeinfo installed. > > It would be convenient to work around this by using the configure flag > MAKEINFO=/usr/bin/true or some such, but that doesn't work because top-level > configure requires a makeinfo of at least version 4.7, and that version check > fails for /usr/bin/true, so we end up with MAKEINFO=missing instead. > > What does work is this: > ... > $ ./configure > $ make MAKEINFO=/usr/bin/true > ... > but the drawback is that it'll have to be specified for each make invocation. > > Fix this by adding support for --without-makeinfo in top-level configure. > > Tested by building gdb on x86_64-linux, and verifying that no .info files > were generated. > > OK for trunk? > > Thanks, > - Tom > > Add --without-makeinfo > > ChangeLog: > > 2022-09-05 Tom de Vries > > * configure.ac: Add --without-makeinfo. > * configure: Regenerate. > > --- > configure | 4 ++++ > configure.ac | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/configure b/configure > index f14e0efd675..eb84add60cb 100755 > --- a/configure > +++ b/configure > @@ -8399,6 +8399,9 @@ fi > done > test -n "$MAKEINFO" || MAKEINFO="$MISSING makeinfo" > > +if test $with_makeinfo = "no"; then > +MAKEINFO=true > +else > case " $build_configdirs " in > *" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;; > *) > @@ -8414,6 +8417,7 @@ case " $build_configdirs " in > ;; > > esac > +fi > > # FIXME: expect and dejagnu may become build tools? > > diff --git a/configure.ac b/configure.ac > index 0152c69292e..e4a2c076674 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -3441,6 +3441,9 @@ case " $build_configdirs " in > esac > > AC_CHECK_PROGS([MAKEINFO], makeinfo, [$MISSING makeinfo]) A new configure flag starting with the "--with-" prefix should use the AC_ARG_WITH autoconf macro, along with the AS_HELP_STRING macro so that it shows up in `./configure --help`. Check other places where AC_ARG_WITH is used in configure.ac to see how it's done. Also, the new option should be documented in install.texi as well. > +if test $with_makeinfo = "no"; then > +MAKEINFO=true > +else > case " $build_configdirs " in > *" texinfo "*) MAKEINFO='$$r/$(BUILD_SUBDIR)/texinfo/makeinfo/makeinfo' ;; > *) > @@ -3456,6 +3459,7 @@ changequote(,) > ;; > changequote([,]) > esac > +fi > > # FIXME: expect and dejagnu may become build tools? >