From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <egall@gwmail.gwu.edu>
Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com
 [IPv6:2a00:1450:4864:20::42f])
 by sourceware.org (Postfix) with ESMTPS id F11A23858423
 for <gcc-patches@gcc.gnu.org>; Fri, 29 Oct 2021 22:04:08 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F11A23858423
Received: by mail-wr1-x42f.google.com with SMTP id d27so864863wrb.6
 for <gcc-patches@gcc.gnu.org>; Fri, 29 Oct 2021 15:04:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=RKHcWmvuv0lBjZ+3JTwnywTzrkUN7b3o71QWm8InRgE=;
 b=OwZeAQ1ltX9ebBHdoeRCu1ki0Sog+7Xqz0Qp05dfYpa2w2zSaaBzu7d7vRDL7FFozj
 1WFEraaND/RgJ2umHkPXhqsjZBK/drxpTiKS7kV4GM/xNg8t6FNDAH01HW8l8jC17V8h
 A3rNm+bCc6nRcgunf/Gv8UoaUlulapd4WO545xdN4t5fNlIqjoL94Dq3Wn9fRfgwweTG
 OAhOpvc8mCwRLkqJ5JLSIazQeD5bo1E4UF+JUvuVOghDm57wEjz8k9tqFoM2uIeOmVcQ
 arkf67lm47Tljx9vW5fKUOogELQLrcsueTQKJyLz3kc6CTsC4kyLHehxi08WVFrjfha1
 Zsxw==
X-Gm-Message-State: AOAM5326p09xhKPsnmU9bDsF1R7usAAAifjgm/Rqp3rIH4MMdP2cvq5/
 H3m0jDdwG+SdQU+EaR8VMs34/D6uIiDUbPvrqZa3VA==
X-Google-Smtp-Source: ABdhPJwzqygxTSAqWX9eZBEt40/PdeF9N9xG3a2oReFdk5qbQ+ZlqMk/bsbRpU57TyyMHvf1KnU+GpWLLul6g9tGW5Y=
X-Received: by 2002:a05:600c:4a27:: with SMTP id
 c39mr1638510wmp.101.1635545047920; 
 Fri, 29 Oct 2021 15:04:07 -0700 (PDT)
MIME-Version: 1.0
References: <20211021164722.500302-1-hjl.tools@gmail.com>
In-Reply-To: <20211021164722.500302-1-hjl.tools@gmail.com>
From: Eric Gallager <egall@gwmail.gwu.edu>
Date: Fri, 29 Oct 2021 18:03:56 -0400
Message-ID: <CAMfHzOtPmEkP_FHdXQ9xGo3+nCGYhpTCfJ01ZSVMyUDLZG0-aw@mail.gmail.com>
Subject: Re: [PATCH] x86: Document -fcf-protection requires i686 or newer
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Oct 2021 22:04:10 -0000

On Thu, Oct 21, 2021 at 12:49 PM H.J. Lu via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
>
>         PR target/98667
>         * doc/invoke.texi: Document -fcf-protection requires i686 or
>         new.
> ---
>  gcc/doc/invoke.texi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
> index c66a25fcd69..71992b8c597 100644
> --- a/gcc/doc/invoke.texi
> +++ b/gcc/doc/invoke.texi
> @@ -15542,7 +15542,8 @@ which functions and calls should be skipped from instrumentation
>  (@pxref{Function Attributes}).
>
>  Currently the x86 GNU/Linux target provides an implementation based
> -on Intel Control-flow Enforcement Technology (CET).
> +on Intel Control-flow Enforcement Technology (CET) which works for
> +i686 processor or newer.

I think "processor" should be pluralized to "processors"? Also,
possibly a missing comma after "(CET)"?

>
>  @item -fstack-protector
>  @opindex fstack-protector
> --
> 2.32.0
>