From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46193 invoked by alias); 6 Sep 2016 18:06:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 46184 invoked by uid 89); 6 Sep 2016 18:06:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.5 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=promotes, sk:bc0570d, optsc, i386.c X-HELO: mail-oi0-f65.google.com Received: from mail-oi0-f65.google.com (HELO mail-oi0-f65.google.com) (209.85.218.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Sep 2016 18:06:25 +0000 Received: by mail-oi0-f65.google.com with SMTP id w78so10554216oie.0 for ; Tue, 06 Sep 2016 11:06:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xDOaG02w3+vsWfVoq7NIgDgEIxU/dPzluzpGUQsdltU=; b=SJhISyIK0Osmfn11twaNTwoZ6CYrC48BFx+NHSDDtzmHawuM8jDfTjvQGTeDUcCDV7 kCnBDDdSDLm4qk4PtSsMxGoXgUUJvw57l4b2VS4jrF7eanhnhMYOasUDkOuiXngiDFu3 /rlA9wzrvPD6rX+TFtRg2wX1RgCXCKDhpasJDoPo1n1WZsfE49k4C8oZ3qXgoWtgBqQk D9oWhNJW5SeFLLw8Kn7JpquJv1twVkCO1iOtimQhTxfMO1uzdZlag46hahIqrnJ/K3iS c1SCqjpqqpBSjgjvsvmg6YwjeWCajCrulD4CsxLoivivcuw73FCYnUyhVn6wWRwiHvNw l+gw== X-Gm-Message-State: AE9vXwNtfvM/U2WITrWrw5YMtS86kYbHriCJmdE7ZO7xI3RYgCRJDVLiLsZki15Pb+G3x0d5o/Hxlx+6tE5x9iyj X-Received: by 10.36.40.130 with SMTP id h124mr31240358ith.89.1473185183797; Tue, 06 Sep 2016 11:06:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.98.148 with HTTP; Tue, 6 Sep 2016 11:06:23 -0700 (PDT) In-Reply-To: References: From: Eric Gallager Date: Tue, 06 Sep 2016 18:09:00 -0000 Message-ID: Subject: Re: [PING] Re: [PATCH, i386] Fix some warnings/errors that appear when enabling -Wnarrowing when building gcc To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" Content-Type: multipart/mixed; boundary=001a1143ee8e91c5e0053bdaa7f3 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00324.txt.bz2 --001a1143ee8e91c5e0053bdaa7f3 Content-Type: text/plain; charset=UTF-8 Content-length: 1201 On 9/6/16, Uros Bizjak wrote: > On Tue, Sep 6, 2016 at 5:33 PM, Eric Gallager wrote: >> Ping? CC-ing an i386 maintainer since the patch mostly touches >> i386-specific files. Also, to clarify, I say "warnings/errors" because >> they start off as warnings in stage 1 but then become errors in stage >> 2. Note also that my patch leaves out the part where I modify the >> configure script to enable -Wnarrowing, because the rest of the code >> isn't quite ready for that yet. > > You are probably referring to [1]? It looks OK, modulo: > > +DEF_TUNE (X86_TUNE_QIMODE_MATH, "qimode_math", ~(0U)) > > where parenthesis are not needed. > > > Please resubmit the patch with a ChangeLog entry, as instructed in [2] > > [1] https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02129.html > [2] https://gcc.gnu.org/contribute.html#patches > > Uros. > Okay, reattached. Here's a ChangeLog entry to put in gcc/ChangeLog: 2016-09-06 Eric Gallager * config/i386/i386.c: Add 'U' suffix to constants to avoid -Wnarrowing. * config/i386/x86-tune.def: Likewise. * opts.c: Likewise. (Please also note that I don't have commit access.) Thanks, Eric --001a1143ee8e91c5e0053bdaa7f3 Content-Type: text/plain; charset=US-ASCII; name="patch-gcc-Wnarrowing-issues.diff" Content-Disposition: attachment; filename="patch-gcc-Wnarrowing-issues.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 Content-length: 7036 IGdjYy9jb25maWcvaTM4Ni9pMzg2LmMgICAgICAgfCA2MCArKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogZ2NjL2NvbmZp Zy9pMzg2L3g4Ni10dW5lLmRlZiB8ICA2ICsrLS0tCiBnY2Mvb3B0cy5jICAg ICAgICAgICAgICAgICAgIHwgIDQgKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDM1 IGluc2VydGlvbnMoKyksIDM1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2djYy9jb25maWcvaTM4Ni9pMzg2LmMgYi9nY2MvY29uZmlnL2kzODYvaTM4 Ni5jCmluZGV4IDQ1MzE2NDcuLjE4MWZjMzkgMTAwNjQ0Ci0tLSBhL2djYy9j b25maWcvaTM4Ni9pMzg2LmMKKysrIGIvZ2NjL2NvbmZpZy9pMzg2L2kzODYu YwpAQCAtMjE2Miw0NSArMjE2Miw0NSBAQCBjb25zdCBzdHJ1Y3QgcHJvY2Vz c29yX2Nvc3RzICppeDg2X3R1bmVfY29zdCA9ICZwZW50aXVtX2Nvc3Q7CiBj b25zdCBzdHJ1Y3QgcHJvY2Vzc29yX2Nvc3RzICppeDg2X2Nvc3QgPSAmcGVu dGl1bV9jb3N0OwogCiAvKiBQcm9jZXNzb3IgZmVhdHVyZS9vcHRpbWl6YXRp b24gYml0bWFza3MuICAqLwotI2RlZmluZSBtXzM4NiAoMTw8UFJPQ0VTU09S X0kzODYpCi0jZGVmaW5lIG1fNDg2ICgxPDxQUk9DRVNTT1JfSTQ4NikKLSNk ZWZpbmUgbV9QRU5UICgxPDxQUk9DRVNTT1JfUEVOVElVTSkKLSNkZWZpbmUg bV9MQUtFTU9OVCAoMTw8UFJPQ0VTU09SX0xBS0VNT05UKQotI2RlZmluZSBt X1BQUk8gKDE8PFBST0NFU1NPUl9QRU5USVVNUFJPKQotI2RlZmluZSBtX1BF TlQ0ICgxPDxQUk9DRVNTT1JfUEVOVElVTTQpCi0jZGVmaW5lIG1fTk9DT05B ICgxPDxQUk9DRVNTT1JfTk9DT05BKQorI2RlZmluZSBtXzM4NiAoMVU8PFBS T0NFU1NPUl9JMzg2KQorI2RlZmluZSBtXzQ4NiAoMVU8PFBST0NFU1NPUl9J NDg2KQorI2RlZmluZSBtX1BFTlQgKDFVPDxQUk9DRVNTT1JfUEVOVElVTSkK KyNkZWZpbmUgbV9MQUtFTU9OVCAoMVU8PFBST0NFU1NPUl9MQUtFTU9OVCkK KyNkZWZpbmUgbV9QUFJPICgxVTw8UFJPQ0VTU09SX1BFTlRJVU1QUk8pCisj ZGVmaW5lIG1fUEVOVDQgKDFVPDxQUk9DRVNTT1JfUEVOVElVTTQpCisjZGVm aW5lIG1fTk9DT05BICgxVTw8UFJPQ0VTU09SX05PQ09OQSkKICNkZWZpbmUg bV9QNF9OT0NPTkEgKG1fUEVOVDQgfCBtX05PQ09OQSkKLSNkZWZpbmUgbV9D T1JFMiAoMTw8UFJPQ0VTU09SX0NPUkUyKQotI2RlZmluZSBtX05FSEFMRU0g KDE8PFBST0NFU1NPUl9ORUhBTEVNKQotI2RlZmluZSBtX1NBTkRZQlJJREdF ICgxPDxQUk9DRVNTT1JfU0FORFlCUklER0UpCi0jZGVmaW5lIG1fSEFTV0VM TCAoMTw8UFJPQ0VTU09SX0hBU1dFTEwpCisjZGVmaW5lIG1fQ09SRTIgKDFV PDxQUk9DRVNTT1JfQ09SRTIpCisjZGVmaW5lIG1fTkVIQUxFTSAoMVU8PFBS T0NFU1NPUl9ORUhBTEVNKQorI2RlZmluZSBtX1NBTkRZQlJJREdFICgxVTw8 UFJPQ0VTU09SX1NBTkRZQlJJREdFKQorI2RlZmluZSBtX0hBU1dFTEwgKDFV PDxQUk9DRVNTT1JfSEFTV0VMTCkKICNkZWZpbmUgbV9DT1JFX0FMTCAobV9D T1JFMiB8IG1fTkVIQUxFTSAgfCBtX1NBTkRZQlJJREdFIHwgbV9IQVNXRUxM KQotI2RlZmluZSBtX0JPTk5FTEwgKDE8PFBST0NFU1NPUl9CT05ORUxMKQot I2RlZmluZSBtX1NJTFZFUk1PTlQgKDE8PFBST0NFU1NPUl9TSUxWRVJNT05U KQotI2RlZmluZSBtX0tOTCAoMTw8UFJPQ0VTU09SX0tOTCkKLSNkZWZpbmUg bV9TS1lMQUtFX0FWWDUxMiAoMTw8UFJPQ0VTU09SX1NLWUxBS0VfQVZYNTEy KQotI2RlZmluZSBtX0lOVEVMICgxPDxQUk9DRVNTT1JfSU5URUwpCi0KLSNk ZWZpbmUgbV9HRU9ERSAoMTw8UFJPQ0VTU09SX0dFT0RFKQotI2RlZmluZSBt X0s2ICgxPDxQUk9DRVNTT1JfSzYpCisjZGVmaW5lIG1fQk9OTkVMTCAoMVU8 PFBST0NFU1NPUl9CT05ORUxMKQorI2RlZmluZSBtX1NJTFZFUk1PTlQgKDFV PDxQUk9DRVNTT1JfU0lMVkVSTU9OVCkKKyNkZWZpbmUgbV9LTkwgKDFVPDxQ Uk9DRVNTT1JfS05MKQorI2RlZmluZSBtX1NLWUxBS0VfQVZYNTEyICgxVTw8 UFJPQ0VTU09SX1NLWUxBS0VfQVZYNTEyKQorI2RlZmluZSBtX0lOVEVMICgx VTw8UFJPQ0VTU09SX0lOVEVMKQorCisjZGVmaW5lIG1fR0VPREUgKDFVPDxQ Uk9DRVNTT1JfR0VPREUpCisjZGVmaW5lIG1fSzYgKDFVPDxQUk9DRVNTT1Jf SzYpCiAjZGVmaW5lIG1fSzZfR0VPREUgKG1fSzYgfCBtX0dFT0RFKQotI2Rl ZmluZSBtX0s4ICgxPDxQUk9DRVNTT1JfSzgpCi0jZGVmaW5lIG1fQVRITE9O ICgxPDxQUk9DRVNTT1JfQVRITE9OKQorI2RlZmluZSBtX0s4ICgxVTw8UFJP Q0VTU09SX0s4KQorI2RlZmluZSBtX0FUSExPTiAoMVU8PFBST0NFU1NPUl9B VEhMT04pCiAjZGVmaW5lIG1fQVRITE9OX0s4IChtX0s4IHwgbV9BVEhMT04p Ci0jZGVmaW5lIG1fQU1ERkFNMTAgKDE8PFBST0NFU1NPUl9BTURGQU0xMCkK LSNkZWZpbmUgbV9CRFZFUjEgKDE8PFBST0NFU1NPUl9CRFZFUjEpCi0jZGVm aW5lIG1fQkRWRVIyICgxPDxQUk9DRVNTT1JfQkRWRVIyKQotI2RlZmluZSBt X0JEVkVSMyAoMTw8UFJPQ0VTU09SX0JEVkVSMykKLSNkZWZpbmUgbV9CRFZF UjQgKDE8PFBST0NFU1NPUl9CRFZFUjQpCi0jZGVmaW5lIG1fWk5WRVIxICgx PDxQUk9DRVNTT1JfWk5WRVIxKQotI2RlZmluZSBtX0JUVkVSMSAoMTw8UFJP Q0VTU09SX0JUVkVSMSkKLSNkZWZpbmUgbV9CVFZFUjIgKDE8PFBST0NFU1NP Ul9CVFZFUjIpCisjZGVmaW5lIG1fQU1ERkFNMTAgKDFVPDxQUk9DRVNTT1Jf QU1ERkFNMTApCisjZGVmaW5lIG1fQkRWRVIxICgxVTw8UFJPQ0VTU09SX0JE VkVSMSkKKyNkZWZpbmUgbV9CRFZFUjIgKDFVPDxQUk9DRVNTT1JfQkRWRVIy KQorI2RlZmluZSBtX0JEVkVSMyAoMVU8PFBST0NFU1NPUl9CRFZFUjMpCisj ZGVmaW5lIG1fQkRWRVI0ICgxVTw8UFJPQ0VTU09SX0JEVkVSNCkKKyNkZWZp bmUgbV9aTlZFUjEgKDFVPDxQUk9DRVNTT1JfWk5WRVIxKQorI2RlZmluZSBt X0JUVkVSMSAoMVU8PFBST0NFU1NPUl9CVFZFUjEpCisjZGVmaW5lIG1fQlRW RVIyICgxVTw8UFJPQ0VTU09SX0JUVkVSMikKICNkZWZpbmUgbV9CRFZFUgko bV9CRFZFUjEgfCBtX0JEVkVSMiB8IG1fQkRWRVIzIHwgbV9CRFZFUjQpCiAj ZGVmaW5lIG1fQlRWRVIgKG1fQlRWRVIxIHwgbV9CVFZFUjIpCiAjZGVmaW5l IG1fQU1EX01VTFRJUExFIChtX0FUSExPTl9LOCB8IG1fQU1ERkFNMTAgfCBt X0JEVkVSIHwgbV9CVFZFUiBcCiAJCQl8IG1fWk5WRVIxKQogCi0jZGVmaW5l IG1fR0VORVJJQyAoMTw8UFJPQ0VTU09SX0dFTkVSSUMpCisjZGVmaW5lIG1f R0VORVJJQyAoMVU8PFBST0NFU1NPUl9HRU5FUklDKQogCiBjb25zdCBjaGFy KiBpeDg2X3R1bmVfZmVhdHVyZV9uYW1lc1tYODZfVFVORV9MQVNUXSA9IHsK ICN1bmRlZiBERUZfVFVORQpkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZy9pMzg2 L3g4Ni10dW5lLmRlZiBiL2djYy9jb25maWcvaTM4Ni94ODYtdHVuZS5kZWYK aW5kZXggMzFhODdiOS4uOGM3YTE0ZCAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZp Zy9pMzg2L3g4Ni10dW5lLmRlZgorKysgYi9nY2MvY29uZmlnL2kzODYveDg2 LXR1bmUuZGVmCkBAIC01MzUsMTUgKzUzNSwxNSBAQCBERUZfVFVORSAoWDg2 X1RVTkVfQVZPSURfRkFMU0VfREVQX0ZPUl9CTUksICJhdm9pZF9mYWxzZV9k ZXBfZm9yX2JtaSIsCiAgICBvbiBzaW11bGF0aW9uIHJlc3VsdC4gQnV0IGFm dGVyIFA0IHdhcyBtYWRlLCBubyBwZXJmb3JtYW5jZSBiZW5lZml0CiAgICB3 YXMgb2JzZXJ2ZWQgd2l0aCBicmFuY2ggaGludHMuICBJdCBhbHNvIGluY3Jl YXNlcyB0aGUgY29kZSBzaXplLgogICAgQXMgYSByZXN1bHQsIGljYyBuZXZl ciBnZW5lcmF0ZXMgYnJhbmNoIGhpbnRzLiAgKi8KLURFRl9UVU5FIChYODZf VFVORV9CUkFOQ0hfUFJFRElDVElPTl9ISU5UUywgImJyYW5jaF9wcmVkaWN0 aW9uX2hpbnRzIiwgMCkKK0RFRl9UVU5FIChYODZfVFVORV9CUkFOQ0hfUFJF RElDVElPTl9ISU5UUywgImJyYW5jaF9wcmVkaWN0aW9uX2hpbnRzIiwgMFUp CiAKIC8qIFg4Nl9UVU5FX1FJTU9ERV9NQVRIOiBFbmFibGUgdXNlIG9mIDhi aXQgYXJpdGhtZXRpYy4gICovCi1ERUZfVFVORSAoWDg2X1RVTkVfUUlNT0RF X01BVEgsICJxaW1vZGVfbWF0aCIsIH4wKQorREVGX1RVTkUgKFg4Nl9UVU5F X1FJTU9ERV9NQVRILCAicWltb2RlX21hdGgiLCB+MFUpCiAKIC8qIFg4Nl9U VU5FX1BST01PVEVfUUlfUkVHUzogVGhpcyBlbmFibGVzIGdlbmVyaWMgY29k ZSB0aGF0IHByb21vdGVzIGFsbCA4Yml0CiAgICBhcml0aG1ldGljIHRvIDMy Yml0IHZpYSBQUk9NT1RFX01PREUgbWFjcm8uICBUaGlzIGNvZGUgZ2VuZXJh dGlvbiBzY2hlbWUKICAgIGlzIHVzdWFsbHkgdXNlZCBmb3IgUklTQyB0YXJn ZXRzLiAgKi8KLURFRl9UVU5FIChYODZfVFVORV9QUk9NT1RFX1FJX1JFR1Ms ICJwcm9tb3RlX3FpX3JlZ3MiLCAwKQorREVGX1RVTkUgKFg4Nl9UVU5FX1BS T01PVEVfUUlfUkVHUywgInByb21vdGVfcWlfcmVncyIsIDBVKQogCiAvKiBY ODZfVFVORV9BREpVU1RfVU5ST0xMOiBUaGlzIGVuYWJsZXMgYWRqdXN0aW5n IHRoZSB1bnJvbGwgZmFjdG9yIGJhc2VkCiAgICBvbiBoYXJkd2FyZSBjYXBh YmlsaXRpZXMuIEJkdmVyMyBoYXJkd2FyZSBoYXMgYSBsb29wIGJ1ZmZlciB3 aGljaCBtYWtlcwpkaWZmIC0tZ2l0IGEvZ2NjL29wdHMuYyBiL2djYy9vcHRz LmMKaW5kZXggYmMwNTcwZC4uODZiNDIyYSAxMDA2NDQKLS0tIGEvZ2NjL29w dHMuYworKysgYi9nY2Mvb3B0cy5jCkBAIC0xNDcxLDkgKzE0NzEsOSBAQCBj b25zdCBzdHJ1Y3Qgc2FuaXRpemVyX29wdHNfcyBzYW5pdGl6ZXJfb3B0c1td ID0KICAgU0FOSVRJWkVSX09QVCAocmV0dXJucy1ub25udWxsLWF0dHJpYnV0 ZSwgU0FOSVRJWkVfUkVUVVJOU19OT05OVUxMX0FUVFJJQlVURSksCiAgIFNB TklUSVpFUl9PUFQgKG9iamVjdC1zaXplLCBTQU5JVElaRV9PQkpFQ1RfU0la RSksCiAgIFNBTklUSVpFUl9PUFQgKHZwdHIsIFNBTklUSVpFX1ZQVFIpLAot ICBTQU5JVElaRVJfT1BUIChhbGwsIH4wKSwKKyAgU0FOSVRJWkVSX09QVCAo YWxsLCB+MFUpLAogI3VuZGVmIFNBTklUSVpFUl9PUFQKLSAgeyBOVUxMLCAw LCAwIH0KKyAgeyBOVUxMLCAwVSwgMFVMIH0KIH07CiAKIC8qIFBhcnNlIGNv bW1hIHNlcGFyYXRlZCBzYW5pdGl6ZXIgc3Vib3B0aW9ucyBmcm9tIFAgZm9y IG9wdGlvbiBTQ09ERSwK --001a1143ee8e91c5e0053bdaa7f3--