From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x930.google.com (mail-ua1-x930.google.com [IPv6:2607:f8b0:4864:20::930]) by sourceware.org (Postfix) with ESMTPS id F3A1A385B512 for ; Fri, 18 Aug 2023 03:38:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3A1A385B512 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-79b4d2c0621so152584241.2 for ; Thu, 17 Aug 2023 20:38:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1692329891; x=1692934691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BS/BqfCpDiUjMYspmnnFtBip5L7/HDTurSfbYmihk+k=; b=F4vENNjzVis9zWImWG4mFzbN3vcRhSLFEMaMkIgh0Yyzmvjovf3FXIlQddx8KD2F2l 2zAJBu0f7z6gLON9n5shR9ZOrlPhTxXskOPAl7ii4Klcd7PrtaDRdrowlx9Cedtw+BJ9 OQN6bzU3OzAKtXjdIi+WRJWQXVM/bpzbhLp6Z6SAoXXEC4UbWhXB4Gp57NRVOdFOGcrL L3FrhTByzAHdIC9jCQWKBV5/bSNZpnj3lB6ZQTgqi9jQFvXE2prjPkF1u1n4aLSjwPSV p4DEG+RVaCpPE53JG1l1i0bp0onOz4lpn74iTcxuowF2b0ltJjb/lEoFLDbePPGcsT6A QDzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692329891; x=1692934691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BS/BqfCpDiUjMYspmnnFtBip5L7/HDTurSfbYmihk+k=; b=igqoorRH0ixTVIOjmwMLNdM82BVyy+oeJLQMNjx/Mh5bprX836+52aukEo2YVAruZ0 zIlZcG3qogzbT7WtvOZtGwvvpawmU8yDILE9C6BQn4XpoRBhE720UCs/Cofe3D+FFZaY 3JKzDzn5LPi3f7W4F7l7c79SmOqJjIfsbdkoWjkJDl8a6c0utCRBKxEjpuIE2Llsxwsd 9pOUwUAcdabOsL4ckB29SY+8yMK3x8R3KKLuH/DO+STApwGsj0ei9ywdb4gUtmlnr++f Up9oInRn9BzOO9ne0r/gOfLYQFvkLxiyh2EKHJm3nzIXKtssrCcDcTDzfqnaOX6Hfcrc YUoA== X-Gm-Message-State: AOJu0YwKONQrI/5nM3k/nWnx40xeA3UqujdcCsWEI+TX7HSdsy6PHqFm lPzEVCh8mfEf/W67Di1Vr+2dqU0fM3F8DD80ifVWznY9utr6kZ08 X-Google-Smtp-Source: AGHT+IFDY1RnRsOu/GX9Dn5xeFFqhbk53M/FmY2ycUp/IrKSJJZxzR4MsoKGFxnqyqmKIlbD7n2Fv4U+6VAO4iDD7sU= X-Received: by 2002:a67:f943:0:b0:447:779b:a357 with SMTP id u3-20020a67f943000000b00447779ba357mr1378818vsq.32.1692329891046; Thu, 17 Aug 2023 20:38:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Gallager Date: Thu, 17 Aug 2023 23:38:00 -0400 Message-ID: Subject: Re: [PATCH] improve error for when /usr/include isn't found [PR90835] To: Iain Sandoe Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Aug 17, 2023 at 4:05=E2=80=AFPM Iain Sandoe wro= te: > > Hi Eric, > > thanks for working on this. > > > On 17 Aug 2023, at 20:35, Eric Gallager wrote: > > > > This is a pretty simple patch that ought to help Darwin users understan= d > > better why their build is failing when they forget to pass the > > --with-sysroot=3D flag to configure. > > > > gcc/ChangeLog: > > > > PR target/90835 > > * Makefile.in: improve error message when /usr/include is > > missing > > 1. the main issue with this approach is that the error does not happen un= til after the > user has waited for the whole of the stage 1 build. > > (I had in mind the idea that top level configure can identify that the= platform > is Darwin, and that there is no sysroot configured; > then [for bootstrap] complain if there is no /use/include > els [for non-bootstrap] complain always) > > - this would mean that the fail occurs at initial configure time. > > 2. if we went with this patch as an incremental improvement: > > + case ${build_os} in \ > + darwin*) \ > + echo "(on darwin this usually means you need to pass th= e --with-sysroot flag to configure to point it to where the system headers = are actually put)" >&2; \ > > I think we need to put this in terms that relate to the system and things= the user can find, so ; > =E2=80=9Con Darwin this usually means you need to pass the --with-sysroot= =3D flag to point to a valid MacOS SDK=E2=80=9D > OK, so would it be ok with that change in wording? > (In practice, the headers cause the first fail, but we also need to find = the libraries when linking) > > Iain > > >