From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fFb/=EF=gwmail.gwu.edu=egall@sourceware.org>
Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31])
	by sourceware.org (Postfix) with ESMTPS id 12E723858C62
	for <gcc-patches@gcc.gnu.org>; Sun, 20 Aug 2023 03:59:41 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12E723858C62
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu
Received: by mail-vk1-xa31.google.com with SMTP id 71dfb90a1353d-48d165bd108so17278e0c.0
        for <gcc-patches@gcc.gnu.org>; Sat, 19 Aug 2023 20:59:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gwmail.gwu.edu; s=google; t=1692503980; x=1693108780;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:from:to:cc:subject:date
         :message-id:reply-to;
        bh=zQqTOcF/B/oaGxTlIOeU+m4nUITVnCpGHpmiCrrIyfw=;
        b=aYHrbASwduEEG0EDX2cSP+FRYskAteH3OUy6pugYHZZJfHMMeuRron0LN2cgAU9JXa
         5JFNFwEAUdyvN65Q02iIYh2Ea7BgO9uTsvBmJXmu0ONwZjodyNGR7zCpgmCN7+KkrmC3
         WqBt8ttCFqBmx/d/JV4F6lBbO3GRGdr76Vu6w2gUhRmYdoqrUQuFsFiy59IjsHWGKh5r
         yWLTabBOfDdwptWNtkbGEIOofmx+WpTgwwjPR9qLIKqnp1jd47DjivB62hmOPuRBRUzV
         wATEhlYv8kMWR7W7hJ+m97Mc2IrDQqyDw/mUXuKJn0kRE7WsZJ9suc2rGXaZh3Sjnbd1
         VvDA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1692503980; x=1693108780;
        h=content-transfer-encoding:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=zQqTOcF/B/oaGxTlIOeU+m4nUITVnCpGHpmiCrrIyfw=;
        b=XgkmnW/G8OeNGJIGjR1Ve52DEJZmMU8I3fk6tr3PpQiTIITZxoD2qDYiWg0AUqKo94
         ey/2ShNy7IyTNCh5o0KfeXqz9wBhAHlY7HT5/qbet5mRMxTyy/rhw/6SJkgT5Opd0xvF
         w05N40Ytq6v9is4WFzzEqPXoa12SDQdesGRYtXBUeb4GRdwGWdvOS+bEd7ry0SVJPcA9
         133dVxY+3pBUUXMw8W5IVZgg9eI9nQZuojelzv2AkrrXriZchkx+KmVctIwGqD4ifMO6
         5ZRksSW45/bunbE3LIwLfIhkqv45EDlccD62kBieRUvtE/km/hFGqruaVdqNY4nEp4RJ
         3zjg==
X-Gm-Message-State: AOJu0YzHLdjXAHbDGeGO8jyPwiIGZDbvEMwKlgBgSdXQQ4LR5R+wQfwb
	hxvsGVXUdevQJh7k18eNU782/AgZv1wVtJ6s4d3MUg==
X-Google-Smtp-Source: AGHT+IGIeBV9Oyx1amva5vyhd4KujEruYaBWSnS9t9xsDedU4XZdBQLq+38FSbkwJlCzdx40Ca52INUkhatLopkW6Z0=
X-Received: by 2002:a67:fdd3:0:b0:440:d726:c8f0 with SMTP id
 l19-20020a67fdd3000000b00440d726c8f0mr1126486vsq.17.1692503980387; Sat, 19
 Aug 2023 20:59:40 -0700 (PDT)
MIME-Version: 1.0
References: <20230817185942.93988-1-egallager@gcc.gnu.org> <9cae2b4c-458e-3c49-bc29-105f21267b70@gmail.com>
In-Reply-To: <9cae2b4c-458e-3c49-bc29-105f21267b70@gmail.com>
From: Eric Gallager <egall@gwmail.gwu.edu>
Date: Sat, 19 Aug 2023 23:59:29 -0400
Message-ID: <CAMfHzOuBKe5c8OQZHyyvx6AUOgZ6RSNd8CEzx0P3nVD+djnxzg@mail.gmail.com>
Subject: Re: [PATCH] improve error when /usr/include isn't found [PR90835]
To: Jeff Law <jeffreyalaw@gmail.com>
Cc: Eric Gallager <egallager@gcc.gnu.org>, gcc-patches@gcc.gnu.org, iains@gcc.gnu.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Thanks, I committed the version with Iain's suggested change in wording:
https://gcc.gnu.org/pipermail/gcc-patches/2023-August/627796.html
https://gcc.gnu.org/git/?p=3Dgcc.git;a=3Dcommitdiff;h=3D9a5d1fceb86a61c9ead=
380df89ce3c4ba387d2e5
(sorry that this got sent multiple times; I thought the email hadn't
gone through properly...)

On Sat, Aug 19, 2023 at 4:11=E2=80=AFPM Jeff Law <jeffreyalaw@gmail.com> wr=
ote:
>
>
>
> On 8/17/23 12:59, Eric Gallager via Gcc-patches wrote:
> > Subject:
> > [PATCH] improve error when /usr/include isn't found [PR90835]
> > From:
> > Eric Gallager via Gcc-patches <gcc-patches@gcc.gnu.org>
> > Date:
> > 8/17/23, 12:59
> >
> > To:
> > gcc-patches@gcc.gnu.org
> > CC:
> > iains@gcc.gnu.org, Eric Gallager <egallager@gcc.gnu.org>
> >
> >
> > This is a pretty simple patch that ought to help Darwin users understan=
d
> > better why their build is failing when they forget to pass the
> > --with-sysroot=3D flag to configure.
> >
> > gcc/ChangeLog:
> >
> >          PR target/90835
> >          * Makefile.in: improve error message when /usr/include is
> >          missing
> OK.
> jeff