From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id C4108385840C for ; Wed, 1 Dec 2021 17:26:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4108385840C Received: by mail-wm1-x32e.google.com with SMTP id 137so21047388wma.1 for ; Wed, 01 Dec 2021 09:26:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yJciBgiI8OhvwsPefvjFA6zb0s3GyhKXMceqko1t0wk=; b=f2upG4yTqCfB1gPUUk86+XSxuN/wXjS/YA0BHNRZXsvAYEPzGe2RNL7be0FeRK9N8p hwHqitKWbPlqm2M2d/P4ZF4Skawrl5F2oW4Ms7b2MbwT3yS2iJAqvTfb5H5C5vaEO40m 9HN0YyWmzEBlLua8b5xRSVaEtv2/BqOjoDtx3dxab90fRfXtNaNaWiR6JPCHNTAfFR/n J+0T29Xr5aQEFGwauQySPLXkibSjxC7w1nWapKsnNFJuaJxDfZhBUJOWcaFs/Pbj0F3p HG/0GDIakbg9yr8RhV+0S12xiPV7gq5/GAwPpey3Zp59NYrSkI0TuLwkMYcjFXn3yyOU VxtA== X-Gm-Message-State: AOAM531Hr2hWDKWBtUUCC+W5evI3j2dh594KsaEpyLWpDU/68T4y5l32 Q/P1Tury/c6q7AeN/y0c7Q/MNBI6ynkXeGOALIdHfd+3YdyHng== X-Google-Smtp-Source: ABdhPJy/g8CnmpBcXDBUoN2JrhW9Kcw9q6YV3KssS2EhZKroUNInLFPmu5bFKRVm8r0rRb38fRmbueqPNQWmDn/W+j8= X-Received: by 2002:a1c:a503:: with SMTP id o3mr8888929wme.98.1638379578801; Wed, 01 Dec 2021 09:26:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Gallager Date: Wed, 1 Dec 2021 12:26:06 -0500 Message-ID: Subject: Re: [PATCH][wwwdocs] Update section on enormous source files in htdocs/projects/beginner.html To: Gerald Pfeifer Cc: gcc-patches Content-Type: multipart/mixed; boundary="000000000000cd777305d218f86f" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Dec 2021 17:26:22 -0000 --000000000000cd777305d218f86f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 1, 2021 at 10:54 AM Gerald Pfeifer wrote: > > Hi Eric, > > On Wed, 24 Nov 2021, Eric Gallager wrote: > > This next patch does more than just removing old stuff: it adds an > > extra sentence to describe a shell command used to generate a list, so > > to verify that I've got the shell command right, I'm asking for a > > review. > > -

There are several other files in this size range, which I have left > +

There are several other files in this size range, which are left > out because touching them at all is unwise (reload, the Fortran front > end). You can try, but I am not responsible for any damage to your > sanity which may result.

> > while we are touching this, how about toning the second half of this > paragraph down and moving away from first person? > > How about something like "...breaking them up likely may prove rather > difficult" (or similar, happy to leave this to you as native spaker)? > OK yeah I did remove the first instance of the first person in that paragraph, but couldn't think of a better wording for the second one, so that suggestion is helpful; thanks. > > +

Note that the list of large files in this section is generated with t= he > +following shell command, run from the gcc subdirectory:

> + > +
> +       du -sh *.{c,h,cc} */*.{c,h,cc} | sort -hr | grep -v fortran | hea=
d -n 14
> +
> > This looks like it does what you want it to do. > > (Pulling up the database courses I have given in a previous life, I'd pul= l > in the grep before the sort - O(n) filtering before O(n=C2=B7log n) proce= ssing > - but even on my notebook both are instantenous. ;-) ) > > > Please consider the two suggestions above and commit the result; just > share the final patch here (no review required). > > Thanks, > Gerald OK thanks, I committed the attached patch as f4b4d0f: https://gcc.gnu.org/git/?p=3Dgcc-wwwdocs.git;a=3Dcommitdiff;h=3Df4b4d0f7832= 46dd6f58944cdb542446d5e7589d3 --000000000000cd777305d218f86f Content-Type: application/octet-stream; name="patch-beginner-projects-02.diff" Content-Disposition: attachment; filename="patch-beginner-projects-02.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kwnsvwve0 ZGlmZiAtLWdpdCBhL2h0ZG9jcy9wcm9qZWN0cy9iZWdpbm5lci5odG1sIGIvaHRkb2NzL3Byb2pl Y3RzL2JlZ2lubmVyLmh0bWwKaW5kZXggNTg5YjQ3YzguLjVhZDAwYWQ4IDEwMDY0NAotLS0gYS9o dGRvY3MvcHJvamVjdHMvYmVnaW5uZXIuaHRtbAorKysgYi9odGRvY3MvcHJvamVjdHMvYmVnaW5u ZXIuaHRtbApAQCAtMTM1LDI1ICsxMzUsMzMgQEAgdG8gdGFrZSB0aG9zZSBwYXRjaGVzIHRvby48 L3A+CiB0YXJnZXRzOjwvcD4KIAogPHByZT4KLQk0MTNLIGNvbWJpbmUuYwotCTQwOEsgZHdhcmYy b3V0LmMKLQkzNzVLIGNwL3B0LmMKLQkzNjdLIGZvbGQtY29uc3QuYwotCTM1NksgbG9vcC5jCi0J MzQySyBjcC9kZWNsLmMKLQkyNzhLIGV4cHIuYwotCTIzOEsgY3AvY2xhc3MuYwotCTIzNEsgYy10 eXBlY2suYwotCTIzM0sgY3NlLmMKLQkyMzFLIGMtZGVjbC5jCi0JMjAwSyBjcC90eXBlY2suYwot CTE2OEsgZnVuY3Rpb24uYworCTEuNE0JY3AvcGFyc2VyLmMKKwkxMDAwSwlkd2FyZjJvdXQuYwor CTkzMksJY3AvcHQuYworCTY4NEsJYy9jLXBhcnNlci5jCisJNTc2SwljcC9kZWNsLmMKKwk1MTZL CWNwL21vZHVsZS5jYworCTUxMksJZm9sZC1jb25zdC5jCisJNTAwSwlnaW1wbGlmeS5jCisJNDky SwljL2MtdHlwZWNrLmMKKwk0ODRLCWNvbWJpbmUuYworCTQ2MEsJb21wLWxvdy5jCisJNDMySwl0 cmVlLmMKKwk0MDhLCWV4cHIuYworCTQwNEsJY3AvY2FsbC5jCiA8L3ByZT4KIAotPHA+VGhlcmUg YXJlIHNldmVyYWwgb3RoZXIgZmlsZXMgaW4gdGhpcyBzaXplIHJhbmdlLCB3aGljaCBJIGhhdmUg bGVmdAorPHA+VGhlcmUgYXJlIHNldmVyYWwgb3RoZXIgZmlsZXMgaW4gdGhpcyBzaXplIHJhbmdl LCB3aGljaCBhcmUgbGVmdAogb3V0IGJlY2F1c2UgdG91Y2hpbmcgdGhlbSBhdCBhbGwgaXMgdW53 aXNlIChyZWxvYWQsIHRoZSBGb3J0cmFuIGZyb250Ci1lbmQpLiAgWW91IGNhbiB0cnksIGJ1dCBJ IGFtIG5vdCByZXNwb25zaWJsZSBmb3IgYW55IGRhbWFnZSB0byB5b3VyCi1zYW5pdHkgd2hpY2gg bWF5IHJlc3VsdC48L3A+CitlbmQpLiAgWW91IGNhbiB0cnksIGJ1dCBicmVha2luZyB0aGVtIHVw IGxpa2VseSBtYXkgcHJvdmUgcmF0aGVyCitkaWZmaWN1bHQsIHNvIGJld2FyZSBvZiB0aGUgbGV2 ZWwgb2YgY2hhbGxlbmdlIGJlZm9yZSBhdHRlbXB0aW5nLjwvcD4KKworPHA+Tm90ZSB0aGF0IHRo ZSBsaXN0IG9mIGxhcmdlIGZpbGVzIGluIHRoaXMgc2VjdGlvbiBpcyBnZW5lcmF0ZWQgd2l0aCB0 aGUKK2ZvbGxvd2luZyBzaGVsbCBjb21tYW5kLCBydW4gZnJvbSB0aGUgZ2NjIHN1YmRpcmVjdG9y eTo8L3A+CisKKzxwcmU+CisJZHUgLXNoICoue2MsaCxjY30gKi8qLntjLGgsY2N9IHwgZ3JlcCAt diBmb3J0cmFuIHwgc29ydCAtaHIgfCBoZWFkIC1uIDE0Cis8L3ByZT4KIDwvbGk+CiAKIDxsaT5S ZW1vdmUgYXMgbXVjaCBjb2RlIGZyb20gcGFyc2VyIGFjdGlvbnMgYXMgcG9zc2libGUuCg== --000000000000cd777305d218f86f--