* [PATCH] libcody: add mostlyclean Makefile target
@ 2021-10-25 14:34 Martin Liška
2021-10-25 16:10 ` Eric Gallager
0 siblings, 1 reply; 5+ messages in thread
From: Martin Liška @ 2021-10-25 14:34 UTC (permalink / raw)
To: gcc-patches
Hello.
The patch adds missing Makefile mostlyclean.
Ready to be installed?
Thanks,
Martin
PR other/102657
libcody/ChangeLog:
* Makefile.in: Add mostlyclean Makefile target.
---
libcody/Makefile.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libcody/Makefile.in b/libcody/Makefile.in
index b8b45a2e310..d8f1e8216d4 100644
--- a/libcody/Makefile.in
+++ b/libcody/Makefile.in
@@ -111,7 +111,7 @@ maintainer-clean:: distclean
clean::
rm -f $(shell find $(srcdir) -name '*~')
-.PHONY: all check clean distclean maintainer-clean
+.PHONY: all check clean distclean maintainer-clean mostlyclean
CXXFLAGS/ := -I$(srcdir)
LIBCODY.O := buffer.o client.o fatal.o netclient.o netserver.o \
@@ -127,6 +127,8 @@ clean::
rm -f $(LIBCODY.O) $(LIBCODY.O:.o=.d)
rm -f libcody.a
+mostlyclean: clean
+
CXXFLAGS/fatal.cc = -DSRCDIR='"$(srcdir)"'
fatal.o: Makefile revision
--
2.33.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libcody: add mostlyclean Makefile target
2021-10-25 14:34 [PATCH] libcody: add mostlyclean Makefile target Martin Liška
@ 2021-10-25 16:10 ` Eric Gallager
2021-10-26 9:47 ` Martin Liška
0 siblings, 1 reply; 5+ messages in thread
From: Eric Gallager @ 2021-10-25 16:10 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches
On Mon, Oct 25, 2021 at 7:35 AM Martin Liška <mliska@suse.cz> wrote:
>
> Hello.
>
> The patch adds missing Makefile mostlyclean.
>
> Ready to be installed?
> Thanks,
> Martin
>
Generally the way the various "*clean" targets are arranged, in order
of cleanliness, from least clean to most clean, is:
mostlyclean
clean
distclean
maintainer-clean
...with each target depending on the previous one in the order. So
thus, instead of mostlyclean depending on clean, it'd be the other way
around, with clean depending on mostlyclean. See how the gcc/
subdirectory does it, for example. See the "Standard Targets for
Users" section of the GNU Coding Standards:
https://www.gnu.org/prep/standards/html_node/Standard-Targets.html#Standard-Targets
> PR other/102657
>
> libcody/ChangeLog:
>
> * Makefile.in: Add mostlyclean Makefile target.
> ---
> libcody/Makefile.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libcody/Makefile.in b/libcody/Makefile.in
> index b8b45a2e310..d8f1e8216d4 100644
> --- a/libcody/Makefile.in
> +++ b/libcody/Makefile.in
> @@ -111,7 +111,7 @@ maintainer-clean:: distclean
> clean::
> rm -f $(shell find $(srcdir) -name '*~')
>
> -.PHONY: all check clean distclean maintainer-clean
> +.PHONY: all check clean distclean maintainer-clean mostlyclean
>
> CXXFLAGS/ := -I$(srcdir)
> LIBCODY.O := buffer.o client.o fatal.o netclient.o netserver.o \
> @@ -127,6 +127,8 @@ clean::
> rm -f $(LIBCODY.O) $(LIBCODY.O:.o=.d)
> rm -f libcody.a
>
> +mostlyclean: clean
> +
> CXXFLAGS/fatal.cc = -DSRCDIR='"$(srcdir)"'
>
> fatal.o: Makefile revision
> --
> 2.33.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libcody: add mostlyclean Makefile target
2021-10-25 16:10 ` Eric Gallager
@ 2021-10-26 9:47 ` Martin Liška
2021-10-27 19:34 ` Eric Gallager
2021-10-28 14:56 ` Jeff Law
0 siblings, 2 replies; 5+ messages in thread
From: Martin Liška @ 2021-10-26 9:47 UTC (permalink / raw)
To: Eric Gallager; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1966 bytes --]
On 10/25/21 18:10, Eric Gallager wrote:
> On Mon, Oct 25, 2021 at 7:35 AM Martin Liška <mliska@suse.cz> wrote:
>>
>> Hello.
>>
>> The patch adds missing Makefile mostlyclean.
>>
>> Ready to be installed?
>> Thanks,
>> Martin
>>
>
> Generally the way the various "*clean" targets are arranged, in order
> of cleanliness, from least clean to most clean, is:
> mostlyclean
> clean
> distclean
> maintainer-clean
> ...with each target depending on the previous one in the order. So
> thus, instead of mostlyclean depending on clean, it'd be the other way
> around, with clean depending on mostlyclean. See how the gcc/
> subdirectory does it, for example. See the "Standard Targets for
> Users" section of the GNU Coding Standards:
> https://www.gnu.org/prep/standards/html_node/Standard-Targets.html#Standard-Targets
Thank you for the explanation.
There's updated version of the patch.
Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
Ready to be installed?
Thanks,
Martin
>
>> PR other/102657
>>
>> libcody/ChangeLog:
>>
>> * Makefile.in: Add mostlyclean Makefile target.
>> ---
>> libcody/Makefile.in | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/libcody/Makefile.in b/libcody/Makefile.in
>> index b8b45a2e310..d8f1e8216d4 100644
>> --- a/libcody/Makefile.in
>> +++ b/libcody/Makefile.in
>> @@ -111,7 +111,7 @@ maintainer-clean:: distclean
>> clean::
>> rm -f $(shell find $(srcdir) -name '*~')
>>
>> -.PHONY: all check clean distclean maintainer-clean
>> +.PHONY: all check clean distclean maintainer-clean mostlyclean
>>
>> CXXFLAGS/ := -I$(srcdir)
>> LIBCODY.O := buffer.o client.o fatal.o netclient.o netserver.o \
>> @@ -127,6 +127,8 @@ clean::
>> rm -f $(LIBCODY.O) $(LIBCODY.O:.o=.d)
>> rm -f libcody.a
>>
>> +mostlyclean: clean
>> +
>> CXXFLAGS/fatal.cc = -DSRCDIR='"$(srcdir)"'
>>
>> fatal.o: Makefile revision
>> --
>> 2.33.1
>>
[-- Attachment #2: 0001-libcody-add-mostlyclean-Makefile-target.patch --]
[-- Type: text/x-patch, Size: 1655 bytes --]
From fcad6039f910b49dfc4022d3b1eeb993025dabca Mon Sep 17 00:00:00 2001
From: Martin Liska <mliska@suse.cz>
Date: Mon, 25 Oct 2021 16:32:55 +0200
Subject: [PATCH] libcody: add mostlyclean Makefile target
PR other/102657
libcody/ChangeLog:
* Makefile.in: Add mostlyclean Makefile target.
---
libcody/Makefile.in | 20 ++++++++++++++------
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/libcody/Makefile.in b/libcody/Makefile.in
index b8b45a2e310..7eaf8ace8ce 100644
--- a/libcody/Makefile.in
+++ b/libcody/Makefile.in
@@ -60,6 +60,8 @@ vpath %.cc $(srcdir)
all:: Makefile
+mostlyclean::
+
clean:: Makefile
# FIXME: Delete
@@ -77,7 +79,9 @@ revision.stamp: $(srcdir)/.
revision: revision.stamp
@cmp -s $< $@ || cp -f $< $@
-clean::
+mostlyclean::
+
+clean:: mostlyclean
rm -f revision.stamp revision
distclean:: clean
@@ -102,16 +106,18 @@ endif
config.status: $(srcdir)/configure $(srcdir)/config.h.in
if test -x $@; then ./$@ -recheck; else $< @configure_args@; fi
+mostlyclean::
+
+clean:: mostlyclean
+ rm -f $(shell find $(srcdir) -name '*~')
+
distclean:: clean
rm -f config.h
maintainer-clean:: distclean
rm -f $(srcdir)/config.h.in
-clean::
- rm -f $(shell find $(srcdir) -name '*~')
-
-.PHONY: all check clean distclean maintainer-clean
+.PHONY: all check clean distclean maintainer-clean mostlyclean
CXXFLAGS/ := -I$(srcdir)
LIBCODY.O := buffer.o client.o fatal.o netclient.o netserver.o \
@@ -123,7 +129,9 @@ libcody.a: $(LIBCODY.O)
$(AR) -cr $@ $^
$(RANLIB) $@
-clean::
+mostlyclean::
+
+clean:: mostlyclean
rm -f $(LIBCODY.O) $(LIBCODY.O:.o=.d)
rm -f libcody.a
--
2.33.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libcody: add mostlyclean Makefile target
2021-10-26 9:47 ` Martin Liška
@ 2021-10-27 19:34 ` Eric Gallager
2021-10-28 14:56 ` Jeff Law
1 sibling, 0 replies; 5+ messages in thread
From: Eric Gallager @ 2021-10-27 19:34 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches, Nathan Sidwell
On Tue, Oct 26, 2021 at 5:47 AM Martin Liška <mliska@suse.cz> wrote:
>
> On 10/25/21 18:10, Eric Gallager wrote:
> > On Mon, Oct 25, 2021 at 7:35 AM Martin Liška <mliska@suse.cz> wrote:
> >>
> >> Hello.
> >>
> >> The patch adds missing Makefile mostlyclean.
> >>
> >> Ready to be installed?
> >> Thanks,
> >> Martin
> >>
> >
> > Generally the way the various "*clean" targets are arranged, in order
> > of cleanliness, from least clean to most clean, is:
> > mostlyclean
> > clean
> > distclean
> > maintainer-clean
> > ...with each target depending on the previous one in the order. So
> > thus, instead of mostlyclean depending on clean, it'd be the other way
> > around, with clean depending on mostlyclean. See how the gcc/
> > subdirectory does it, for example. See the "Standard Targets for
> > Users" section of the GNU Coding Standards:
> > https://www.gnu.org/prep/standards/html_node/Standard-Targets.html#Standard-Targets
>
> Thank you for the explanation.
>
> There's updated version of the patch.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
Hi, the patch looks ok to me, although I can't approve it... Who is
the libcody maintainer, anyways? Nathan? Should that be listed in the
MAINTAINERS file?
Thanks,
Eric Gallager
> Thanks,
> Martin
>
> >
> >> PR other/102657
> >>
> >> libcody/ChangeLog:
> >>
> >> * Makefile.in: Add mostlyclean Makefile target.
> >> ---
> >> libcody/Makefile.in | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/libcody/Makefile.in b/libcody/Makefile.in
> >> index b8b45a2e310..d8f1e8216d4 100644
> >> --- a/libcody/Makefile.in
> >> +++ b/libcody/Makefile.in
> >> @@ -111,7 +111,7 @@ maintainer-clean:: distclean
> >> clean::
> >> rm -f $(shell find $(srcdir) -name '*~')
> >>
> >> -.PHONY: all check clean distclean maintainer-clean
> >> +.PHONY: all check clean distclean maintainer-clean mostlyclean
> >>
> >> CXXFLAGS/ := -I$(srcdir)
> >> LIBCODY.O := buffer.o client.o fatal.o netclient.o netserver.o \
> >> @@ -127,6 +127,8 @@ clean::
> >> rm -f $(LIBCODY.O) $(LIBCODY.O:.o=.d)
> >> rm -f libcody.a
> >>
> >> +mostlyclean: clean
> >> +
> >> CXXFLAGS/fatal.cc = -DSRCDIR='"$(srcdir)"'
> >>
> >> fatal.o: Makefile revision
> >> --
> >> 2.33.1
> >>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libcody: add mostlyclean Makefile target
2021-10-26 9:47 ` Martin Liška
2021-10-27 19:34 ` Eric Gallager
@ 2021-10-28 14:56 ` Jeff Law
1 sibling, 0 replies; 5+ messages in thread
From: Jeff Law @ 2021-10-28 14:56 UTC (permalink / raw)
To: Martin Liška, Eric Gallager; +Cc: gcc-patches
On 10/26/2021 3:47 AM, Martin Liška wrote:
> On 10/25/21 18:10, Eric Gallager wrote:
>> On Mon, Oct 25, 2021 at 7:35 AM Martin Liška <mliska@suse.cz> wrote:
>>>
>>> Hello.
>>>
>>> The patch adds missing Makefile mostlyclean.
>>>
>>> Ready to be installed?
>>> Thanks,
>>> Martin
>>>
>>
>> Generally the way the various "*clean" targets are arranged, in order
>> of cleanliness, from least clean to most clean, is:
>> mostlyclean
>> clean
>> distclean
>> maintainer-clean
>> ...with each target depending on the previous one in the order. So
>> thus, instead of mostlyclean depending on clean, it'd be the other way
>> around, with clean depending on mostlyclean. See how the gcc/
>> subdirectory does it, for example. See the "Standard Targets for
>> Users" section of the GNU Coding Standards:
>> https://www.gnu.org/prep/standards/html_node/Standard-Targets.html#Standard-Targets
>>
>
> Thank you for the explanation.
>
> There's updated version of the patch.
>
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>
> Ready to be installed?
> Thanks,
> Martin
>
>>
>>> PR other/102657
>>>
>>> libcody/ChangeLog:
>>>
>>> * Makefile.in: Add mostlyclean Makefile target.
>>> ---
>>> libcody/Makefile.in | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/libcody/Makefile.in b/libcody/Makefile.in
>>> index b8b45a2e310..d8f1e8216d4 100644
>>> --- a/libcody/Makefile.in
>>> +++ b/libcody/Makefile.in
>>> @@ -111,7 +111,7 @@ maintainer-clean:: distclean
>>> clean::
>>> rm -f $(shell find $(srcdir) -name '*~')
>>>
>>> -.PHONY: all check clean distclean maintainer-clean
>>> +.PHONY: all check clean distclean maintainer-clean mostlyclean
>>>
>>> CXXFLAGS/ := -I$(srcdir)
>>> LIBCODY.O := buffer.o client.o fatal.o netclient.o netserver.o \
>>> @@ -127,6 +127,8 @@ clean::
>>> rm -f $(LIBCODY.O) $(LIBCODY.O:.o=.d)
>>> rm -f libcody.a
>>>
>>> +mostlyclean: clean
>>> +
>>> CXXFLAGS/fatal.cc = -DSRCDIR='"$(srcdir)"'
>>>
>>> fatal.o: Makefile revision
>>> --
>>> 2.33.1
>>>
>
> 0001-libcody-add-mostlyclean-Makefile-target.patch
>
> From fcad6039f910b49dfc4022d3b1eeb993025dabca Mon Sep 17 00:00:00 2001
> From: Martin Liska <mliska@suse.cz>
> Date: Mon, 25 Oct 2021 16:32:55 +0200
> Subject: [PATCH] libcody: add mostlyclean Makefile target
>
> PR other/102657
>
> libcody/ChangeLog:
>
> * Makefile.in: Add mostlyclean Makefile target.
OK
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-28 14:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 14:34 [PATCH] libcody: add mostlyclean Makefile target Martin Liška
2021-10-25 16:10 ` Eric Gallager
2021-10-26 9:47 ` Martin Liška
2021-10-27 19:34 ` Eric Gallager
2021-10-28 14:56 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).