From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by sourceware.org (Postfix) with ESMTPS id D773A3858CDB for ; Mon, 23 Oct 2023 05:57:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D773A3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D773A3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::e31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698040681; cv=none; b=GAdp8vt0oQ6QcaeKG3tZsjjbUHhQCGQpGGhhyZLJFqV2Xj4m+63mBL1zDX48JxwzXqD3AK8pO5ivYrEcqy1Lr7pu1GUnFoPbyhQ67Wocb5GQazX8Sto349JhsvfTFcWx5Pxy5GYIzzJKBWyvllX+L4bjOTS6LuqQYm5rFinCnmk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698040681; c=relaxed/simple; bh=+NFF0nsSOmZQDJwdEOkY4FPIlDcZcM+5/NAsaq4FKSY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fQInxAdnFOEWjp9jQv2lCrUi85V66nWetAG7RD9v+kCyJ7BO0RFmjP2eKMdtyJdjE19OCa228XNTvle9l7Xie3BeC7Cx8sw5pbA/bwnAGGUyp6rI9AAYXBG9G7aB5or8pcfJeSZoK6foWwppoL8wIvrKGFLF9VtMbRStJfysqT0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-vs1-xe31.google.com with SMTP id ada2fe7eead31-457ee0df54eso1183114137.0 for ; Sun, 22 Oct 2023 22:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; t=1698040679; x=1698645479; darn=gcc.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=olj4Ne+2AOWwNE8v3hyg3EZFoQVha3xKszrDOPQmZhg=; b=D+cFCgh9MGCSwrFeO9BIYXRDOBxT1yLgRvYuNgL1LnCNYO+z7jiTRLXfbljMLtgNuc fwAtdGCiFHHyGzJGB8B/5zA/Up7KzPKDSl/WUNt0DNqA1Mb9/YPWPFNty3TUS9CAG42l LcEs9rYrZaKXto2kCLT1JtznSR8aY8l4wnwI2rVV2XnFenaeNuXLIAI33V0Htumu1cwb POK1YEAZ/eplixvQI6aDeimr8MRgqRzEdhbJpDkNE3HmoBC9C+aRN8/h8/Gp2YmQy7tT yP6Jta1cF/g/tq9d/ggx+YHlEngXtW3ETLpth8V2GbaL6Ar5DAFxg6gc1nHvpo4cf9hn u8sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698040679; x=1698645479; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=olj4Ne+2AOWwNE8v3hyg3EZFoQVha3xKszrDOPQmZhg=; b=bx3T+VPrZ1DzAmPX7btf5PozliWSnUHbTHIZFK+EpFR+ybqWfQBYs6w3JENvB/aHVG +nPK1SSZVrlwtYJ7UW1Dhg/NkXZGqLlJjJ/W9NYDqvG1xn0fr3+Z+eMCZqUA81zY+C7f qb4zqGVqE6RbCTvEhoRSSAlM7n3B8rcyVibCznBHHy8liR7n1NMcEIvy3gis748qoj50 1qHEHvVZ76PRtHeP1mho766a1q8b4a/OL97BYzHxRQNMnpiMydO6Djggu3DnT2aHyGsD vFBZJISFZv+WVgPeqyJQ59sje/k0JHsazC8aFqWwZQceznPQhTQCQKCfKhwhtHfAcB31 VbeQ== X-Gm-Message-State: AOJu0YxYMALUsnCxzVTqhpUKwsO+31fdaDCeVwZtN750zLTZGQVAbzpo hoLXyLE33NnrW2xks8Qoo4nAFxSq+NSGdYsyTH+6rQ== X-Google-Smtp-Source: AGHT+IHR72iYbwV+WGRcF83qeukULyYK8dj/kvHi1c4C+KFWru5WmSt1sYW3VONNFBx6zDx8JaqZaD6y+pc06pX6ofs= X-Received: by 2002:a67:e112:0:b0:457:6858:af77 with SMTP id d18-20020a67e112000000b004576858af77mr6814891vsl.26.1698040679227; Sun, 22 Oct 2023 22:57:59 -0700 (PDT) MIME-Version: 1.0 References: <87zg0bhzep.fsf@oldenburg.str.redhat.com> In-Reply-To: From: Eric Gallager Date: Mon, 23 Oct 2023 01:57:48 -0400 Message-ID: Subject: Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE To: rep.dot.nop@gmail.com Cc: gcc-patches@gcc.gnu.org, Jeff Law , Andrew Pinski , Florian Weimer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Oct 22, 2023 at 4:03=E2=80=AFPM wrote: > > On 22 October 2023 21:45:12 CEST, Jeff Law wrote: > > > > > >On 10/22/23 10:09, Andrew Pinski wrote: > >> On Sun, Oct 22, 2023 at 12:47=E2=80=AFAM Florian Weimer wrote: > >>> > >>> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. > >>> Defining the macro avoids an implicit function declaration. > >> > >> This does not help targets that don't use glibc though. > >> Note for builtins testsuite there is a lib-fputs.c file which will > >> define a fputs_unlock which is how it will link even if the libc does > >> not define a fputs_unlock. > >But isn't fputs_unlocked glibc specific to begin with? ie, the test rea= lly doesn't make sense AFAICT on non-glibc targets. > > I think uClibc had it too, at least at one point in the past. > gnulib has these portability notes about fputs_unlocked: https://www.gnu.org/software/gnulib/manual/html_node/fputs_005funlocked.htm= l Unfortunately, it only lists the platforms that *don't* have it, not the ones that *do* have it, so I'm afraid its notes aren't actually that helpful after all... oh well, never mind...