From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 2FE513858D3C for ; Tue, 12 Oct 2021 19:56:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2FE513858D3C Received: by mail-wr1-x435.google.com with SMTP id o20so864623wro.3 for ; Tue, 12 Oct 2021 12:56:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+7rYiSqhUElGGoXJ/FQmyXnw94/Hftf+HBR8skcSUlk=; b=tv9tcj3qrqqkjJf/BgstsbnC9umQhk0TMd1v2D5ruicuIh8qst4A3vtDoe6ARNo4f5 79NRLKtSPCeObKDw6ET4SS6kiDUDtFjEyGfY5MeUDvPDasK/Aen3cGGeKJ3O16e+dW8Y hObgAQ9aOhg4EXM1HFd8iQkoVi/LQ6VyAl1CYX+Psxzm+9SN+KnwZrwmEDNRRcn4i7kl Uzs5OfCgX1/A58C/qAQkU925Um8dHbclNqhIKvxkZj0Jz4nUUDAVgh+1Jq18YHYaM0cu xdNT14zVPSBWJ2pNUtmcbN5RYViw0Dq9Fuj0TPzWUc7wZTY/49g4YyfceuvBlNTuImiu jjSg== X-Gm-Message-State: AOAM533SjyHJ8sTXfHapBxmhfdiEn083GvBI5ygG2KwRKamldNzPzCHL P79z2RQHba+14B9figAiBTJJYoxGSWc9RTg/5ThGDw== X-Google-Smtp-Source: ABdhPJzMWuArCYBvBxHQVzcxhPNEv/k45leSWnzK+MwDkHz77xBO6ZHIj2sqKnKZ9fUet8rGrnIWiPE8eF6iVOpMXtA= X-Received: by 2002:adf:a505:: with SMTP id i5mr34820660wrb.38.1634068594860; Tue, 12 Oct 2021 12:56:34 -0700 (PDT) MIME-Version: 1.0 References: <98b7d7ad-3869-f44f-c95c-289da8cb2828@gmail.com> In-Reply-To: <98b7d7ad-3869-f44f-c95c-289da8cb2828@gmail.com> From: Eric Gallager Date: Tue, 12 Oct 2021 15:56:23 -0400 Message-ID: Subject: Re: [PATCH] Allow `make tags` to work from top-level directory To: Jeff Law Cc: Jeff Law , gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Oct 2021 19:56:38 -0000 On Tue, Oct 12, 2021 at 9:18 AM Jeff Law wrote: > > > > On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: > > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager wrote: > >> On 10/13/16, Jeff Law wrote: > >>> On 10/06/2016 07:21 AM, Eric Gallager wrote: > >>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS > >>>> targets in their Makefiles. The attached patch causes them to be > >>>> skipped when running `make tags`. > >>>> > >>>> ChangeLog entry: > >>>> > >>>> 2016-10-06 Eric Gallager > >>>> > >>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing > >>>> TAGS target. > >>>> * Makefile.in: Regenerate. > >>>> > >>> OK. Please install. > >>> > >>> Thanks, > >>> Jeff > >>> > >> > >> I'm still waiting to hear back from about my request > >> for copyright assignment, which I'll need to get sorted out before I > >> can start committing stuff (like this patch). > >> > >> Thanks, > >> Eric > > Update: In the intervening years, I got my copyright assignment filed > > and have recently become able to commit again; is your old approval > > from 2016 still valid, Jeff, or do I need a re-approval? > > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html > It's still valid. Just re-test and commit. > > jeff While re-testing, it seems that the `etags` command on my computer can't be found any longer; I'm thinking gcc/Makefile.in should be updated to stop hardcoding etags and use a variable that can be overridden instead... should I do a separate patch for that, or combine it with this one?