* [PATCH] Allow `make tags` to work from top-level directory @ 2016-10-06 13:21 Eric Gallager 2016-10-13 18:38 ` Jeff Law 0 siblings, 1 reply; 8+ messages in thread From: Eric Gallager @ 2016-10-06 13:21 UTC (permalink / raw) To: gcc-patches [-- Attachment #1: Type: text/plain, Size: 348 bytes --] The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS targets in their Makefiles. The attached patch causes them to be skipped when running `make tags`. ChangeLog entry: 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing TAGS target. * Makefile.in: Regenerate. [-- Attachment #2: patch-Makefile.diff --] [-- Type: text/plain, Size: 4622 bytes --] Makefile.def | 9 ++++++--- Makefile.in | 62 +++++++++--------------------------------------------------- 2 files changed, 15 insertions(+), 56 deletions(-) diff --git a/Makefile.def b/Makefile.def index 4eea342..942b147 100644 --- a/Makefile.def +++ b/Makefile.def @@ -81,7 +81,8 @@ host_modules= { module= itcl; }; host_modules= { module= ld; bootstrap=true; }; host_modules= { module= libbacktrace; bootstrap=true; }; host_modules= { module= libcpp; bootstrap=true; }; -host_modules= { module= libdecnumber; bootstrap=true; }; +host_modules= { module= libdecnumber; bootstrap=true; + missing=TAGS; }; host_modules= { module= libgui; }; host_modules= { module= libiberty; bootstrap=true; extra_configure_flags='@extra_host_libiberty_configure_flags@';}; @@ -151,11 +152,13 @@ target_modules = { module= liboffloadmic; extra_configure_flags='@extra_liboffloadmic_configure_flags@'; }; target_modules = { module= libssp; lib_path=.libs; }; target_modules = { module= newlib; }; -target_modules = { module= libgcc; bootstrap=true; no_check=true; }; +target_modules = { module= libgcc; bootstrap=true; no_check=true; + missing=TAGS; }; target_modules = { module= libbacktrace; }; target_modules = { module= libquadmath; }; target_modules = { module= libgfortran; }; -target_modules = { module= libobjc; }; +target_modules = { module= libobjc; + missing=TAGS; }; target_modules = { module= libgo; }; target_modules = { module= libtermcap; no_check=true; missing=mostlyclean; diff --git a/Makefile.in b/Makefile.in index 3046489..1bd20b8 100644 --- a/Makefile.in +++ b/Makefile.in @@ -24399,23 +24399,8 @@ maybe-TAGS-libdecnumber: @if libdecnumber maybe-TAGS-libdecnumber: TAGS-libdecnumber -TAGS-libdecnumber: \ - configure-libdecnumber - @[ -f ./libdecnumber/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(HOST_EXPORTS) \ - for flag in $(EXTRA_HOST_FLAGS) ; do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - echo "Doing TAGS in libdecnumber"; \ - (cd $(HOST_SUBDIR)/libdecnumber && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libdecnumber doesn't support TAGS. +TAGS-libdecnumber: @endif libdecnumber @@ -43600,24 +43585,8 @@ maybe-TAGS-target-libgcc: @if target-libgcc maybe-TAGS-target-libgcc: TAGS-target-libgcc -TAGS-target-libgcc: \ - configure-target-libgcc - @: $(MAKE); $(unstage) - @[ -f $(TARGET_SUBDIR)/libgcc/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(NORMAL_TARGET_EXPORTS) \ - echo "Doing TAGS in $(TARGET_SUBDIR)/libgcc"; \ - for flag in $(EXTRA_TARGET_FLAGS); do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - (cd $(TARGET_SUBDIR)/libgcc && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libgcc doesn't support TAGS. +TAGS-target-libgcc: @endif target-libgcc @@ -45432,24 +45401,8 @@ maybe-TAGS-target-libobjc: @if target-libobjc maybe-TAGS-target-libobjc: TAGS-target-libobjc -TAGS-target-libobjc: \ - configure-target-libobjc - @: $(MAKE); $(unstage) - @[ -f $(TARGET_SUBDIR)/libobjc/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(NORMAL_TARGET_EXPORTS) \ - echo "Doing TAGS in $(TARGET_SUBDIR)/libobjc"; \ - for flag in $(EXTRA_TARGET_FLAGS); do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - (cd $(TARGET_SUBDIR)/libobjc && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libobjc doesn't support TAGS. +TAGS-target-libobjc: @endif target-libobjc @@ -47871,6 +47824,9 @@ maintainer-clean-target-libffi: @endif target-libffi + + + .PHONY: configure-target-zlib maybe-configure-target-zlib maybe-configure-target-zlib: @if gcc-bootstrap ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2016-10-06 13:21 [PATCH] Allow `make tags` to work from top-level directory Eric Gallager @ 2016-10-13 18:38 ` Jeff Law 2016-10-13 20:44 ` Eric Gallager 0 siblings, 1 reply; 8+ messages in thread From: Jeff Law @ 2016-10-13 18:38 UTC (permalink / raw) To: Eric Gallager, gcc-patches On 10/06/2016 07:21 AM, Eric Gallager wrote: > The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS > targets in their Makefiles. The attached patch causes them to be > skipped when running `make tags`. > > ChangeLog entry: > > 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> > > * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing > TAGS target. > * Makefile.in: Regenerate. > OK. Please install. Thanks, Jeff ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2016-10-13 18:38 ` Jeff Law @ 2016-10-13 20:44 ` Eric Gallager 2021-10-11 22:05 ` Eric Gallager 0 siblings, 1 reply; 8+ messages in thread From: Eric Gallager @ 2016-10-13 20:44 UTC (permalink / raw) To: Jeff Law; +Cc: gcc-patches On 10/13/16, Jeff Law <law@redhat.com> wrote: > On 10/06/2016 07:21 AM, Eric Gallager wrote: >> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS >> targets in their Makefiles. The attached patch causes them to be >> skipped when running `make tags`. >> >> ChangeLog entry: >> >> 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> >> >> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing >> TAGS target. >> * Makefile.in: Regenerate. >> > OK. Please install. > > Thanks, > Jeff > I'm still waiting to hear back from <assign@gnu.org> about my request for copyright assignment, which I'll need to get sorted out before I can start committing stuff (like this patch). Thanks, Eric ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2016-10-13 20:44 ` Eric Gallager @ 2021-10-11 22:05 ` Eric Gallager 2021-10-12 13:18 ` Jeff Law 0 siblings, 1 reply; 8+ messages in thread From: Eric Gallager @ 2021-10-11 22:05 UTC (permalink / raw) To: Jeff Law; +Cc: gcc-patches On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: > > On 10/13/16, Jeff Law <law@redhat.com> wrote: > > On 10/06/2016 07:21 AM, Eric Gallager wrote: > >> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS > >> targets in their Makefiles. The attached patch causes them to be > >> skipped when running `make tags`. > >> > >> ChangeLog entry: > >> > >> 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> > >> > >> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing > >> TAGS target. > >> * Makefile.in: Regenerate. > >> > > OK. Please install. > > > > Thanks, > > Jeff > > > > > I'm still waiting to hear back from <assign@gnu.org> about my request > for copyright assignment, which I'll need to get sorted out before I > can start committing stuff (like this patch). > > Thanks, > Eric Update: In the intervening years, I got my copyright assignment filed and have recently become able to commit again; is your old approval from 2016 still valid, Jeff, or do I need a re-approval? Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html Thanks, Eric ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2021-10-11 22:05 ` Eric Gallager @ 2021-10-12 13:18 ` Jeff Law 2021-10-12 19:56 ` Eric Gallager 0 siblings, 1 reply; 8+ messages in thread From: Jeff Law @ 2021-10-12 13:18 UTC (permalink / raw) To: Eric Gallager, Jeff Law; +Cc: gcc-patches On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: >> On 10/13/16, Jeff Law <law@redhat.com> wrote: >>> On 10/06/2016 07:21 AM, Eric Gallager wrote: >>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS >>>> targets in their Makefiles. The attached patch causes them to be >>>> skipped when running `make tags`. >>>> >>>> ChangeLog entry: >>>> >>>> 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> >>>> >>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing >>>> TAGS target. >>>> * Makefile.in: Regenerate. >>>> >>> OK. Please install. >>> >>> Thanks, >>> Jeff >>> >> >> I'm still waiting to hear back from <assign@gnu.org> about my request >> for copyright assignment, which I'll need to get sorted out before I >> can start committing stuff (like this patch). >> >> Thanks, >> Eric > Update: In the intervening years, I got my copyright assignment filed > and have recently become able to commit again; is your old approval > from 2016 still valid, Jeff, or do I need a re-approval? > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html It's still valid. Just re-test and commit. jeff ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2021-10-12 13:18 ` Jeff Law @ 2021-10-12 19:56 ` Eric Gallager 2021-10-12 21:03 ` Eric Gallager 2021-10-14 16:26 ` Jeff Law 0 siblings, 2 replies; 8+ messages in thread From: Eric Gallager @ 2021-10-12 19:56 UTC (permalink / raw) To: Jeff Law; +Cc: Jeff Law, gcc-patches On Tue, Oct 12, 2021 at 9:18 AM Jeff Law <jeffreyalaw@gmail.com> wrote: > > > > On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: > > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: > >> On 10/13/16, Jeff Law <law@redhat.com> wrote: > >>> On 10/06/2016 07:21 AM, Eric Gallager wrote: > >>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS > >>>> targets in their Makefiles. The attached patch causes them to be > >>>> skipped when running `make tags`. > >>>> > >>>> ChangeLog entry: > >>>> > >>>> 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> > >>>> > >>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing > >>>> TAGS target. > >>>> * Makefile.in: Regenerate. > >>>> > >>> OK. Please install. > >>> > >>> Thanks, > >>> Jeff > >>> > >> > >> I'm still waiting to hear back from <assign@gnu.org> about my request > >> for copyright assignment, which I'll need to get sorted out before I > >> can start committing stuff (like this patch). > >> > >> Thanks, > >> Eric > > Update: In the intervening years, I got my copyright assignment filed > > and have recently become able to commit again; is your old approval > > from 2016 still valid, Jeff, or do I need a re-approval? > > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html > It's still valid. Just re-test and commit. > > jeff While re-testing, it seems that the `etags` command on my computer can't be found any longer; I'm thinking gcc/Makefile.in should be updated to stop hardcoding etags and use a variable that can be overridden instead... should I do a separate patch for that, or combine it with this one? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2021-10-12 19:56 ` Eric Gallager @ 2021-10-12 21:03 ` Eric Gallager 2021-10-14 16:26 ` Jeff Law 1 sibling, 0 replies; 8+ messages in thread From: Eric Gallager @ 2021-10-12 21:03 UTC (permalink / raw) To: Jeff Law; +Cc: Jeff Law, gcc-patches [-- Attachment #1: Type: text/plain, Size: 2007 bytes --] On Tue, Oct 12, 2021 at 3:56 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: > > On Tue, Oct 12, 2021 at 9:18 AM Jeff Law <jeffreyalaw@gmail.com> wrote: > > > > > > > > On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: > > > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: > > >> On 10/13/16, Jeff Law <law@redhat.com> wrote: > > >>> On 10/06/2016 07:21 AM, Eric Gallager wrote: > > >>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS > > >>>> targets in their Makefiles. The attached patch causes them to be > > >>>> skipped when running `make tags`. > > >>>> > > >>>> ChangeLog entry: > > >>>> > > >>>> 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> > > >>>> > > >>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing > > >>>> TAGS target. > > >>>> * Makefile.in: Regenerate. > > >>>> > > >>> OK. Please install. > > >>> > > >>> Thanks, > > >>> Jeff > > >>> > > >> > > >> I'm still waiting to hear back from <assign@gnu.org> about my request > > >> for copyright assignment, which I'll need to get sorted out before I > > >> can start committing stuff (like this patch). > > >> > > >> Thanks, > > >> Eric > > > Update: In the intervening years, I got my copyright assignment filed > > > and have recently become able to commit again; is your old approval > > > from 2016 still valid, Jeff, or do I need a re-approval? > > > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html > > It's still valid. Just re-test and commit. > > > > jeff > > While re-testing, it seems that the `etags` command on my computer > can't be found any longer; I'm thinking gcc/Makefile.in should be > updated to stop hardcoding etags and use a variable that can be > overridden instead... should I do a separate patch for that, or > combine it with this one? Well, anyways, this is what I've ended up committing for now: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=4ca446a46bef8c127d7aaeb2d4bb4625edc7f84e [-- Attachment #2: patch-Makefile.diff --] [-- Type: application/octet-stream, Size: 6390 bytes --] diff --git a/Makefile.def b/Makefile.def index e015a7aaeb7..d70020d743d 100644 --- a/Makefile.def +++ b/Makefile.def @@ -89,8 +89,10 @@ host_modules= { module= libcody; bootstrap=true; missing= info; missing= install-pdf; missing= install-html; - missing= install-info; }; -host_modules= { module= libdecnumber; bootstrap=true; }; + missing= install-info; + missing=TAGS; }; +host_modules= { module= libdecnumber; bootstrap=true; + missing=TAGS; }; host_modules= { module= libgui; }; host_modules= { module= libiberty; bootstrap=true; extra_configure_flags='@extra_host_libiberty_configure_flags@';}; @@ -134,7 +136,8 @@ host_modules= { module= libtermcap; no_check=true; missing=distclean; missing=maintainer-clean; }; host_modules= { module= utils; no_check=true; }; -host_modules= { module= c++tools; }; +host_modules= { module= c++tools; + missing=TAGS; }; host_modules= { module= gnattools; }; host_modules= { module= lto-plugin; bootstrap=true; extra_configure_flags='--enable-shared @extra_linker_plugin_flags@ @extra_linker_plugin_configure_flags@'; @@ -160,11 +163,13 @@ target_modules = { module= liboffloadmic; extra_configure_flags='@extra_liboffloadmic_configure_flags@'; }; target_modules = { module= libssp; lib_path=.libs; }; target_modules = { module= newlib; }; -target_modules = { module= libgcc; bootstrap=true; no_check=true; }; +target_modules = { module= libgcc; bootstrap=true; no_check=true; + missing=TAGS; }; target_modules = { module= libbacktrace; }; target_modules = { module= libquadmath; }; target_modules = { module= libgfortran; }; -target_modules = { module= libobjc; }; +target_modules = { module= libobjc; + missing=TAGS; }; target_modules = { module= libgo; }; target_modules = { module= libphobos; lib_path=src/.libs; }; diff --git a/Makefile.in b/Makefile.in index 9219ebfb02b..27e8a680d10 100644 --- a/Makefile.in +++ b/Makefile.in @@ -25921,23 +25921,8 @@ maybe-TAGS-libcody: @if libcody maybe-TAGS-libcody: TAGS-libcody -TAGS-libcody: \ - configure-libcody - @[ -f ./libcody/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(HOST_EXPORTS) \ - for flag in $(EXTRA_HOST_FLAGS) ; do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - echo "Doing TAGS in libcody"; \ - (cd $(HOST_SUBDIR)/libcody && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libcody doesn't support TAGS. +TAGS-libcody: @endif libcody @@ -26987,23 +26972,8 @@ maybe-TAGS-libdecnumber: @if libdecnumber maybe-TAGS-libdecnumber: TAGS-libdecnumber -TAGS-libdecnumber: \ - configure-libdecnumber - @[ -f ./libdecnumber/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(HOST_EXPORTS) \ - for flag in $(EXTRA_HOST_FLAGS) ; do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - echo "Doing TAGS in libdecnumber"; \ - (cd $(HOST_SUBDIR)/libdecnumber && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libdecnumber doesn't support TAGS. +TAGS-libdecnumber: @endif libdecnumber @@ -38319,24 +38289,8 @@ maybe-TAGS-c++tools: @if c++tools maybe-TAGS-c++tools: TAGS-c++tools -TAGS-c++tools: \ - configure-c++tools - @: $(MAKE); $(unstage) - @[ -f ./c++tools/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(HOST_EXPORTS) \ - for flag in $(EXTRA_HOST_FLAGS) ; do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - echo "Doing TAGS in c++tools"; \ - (cd $(HOST_SUBDIR)/c++tools && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# c++tools doesn't support TAGS. +TAGS-c++tools: @endif c++tools @@ -48225,24 +48179,8 @@ maybe-TAGS-target-libgcc: @if target-libgcc maybe-TAGS-target-libgcc: TAGS-target-libgcc -TAGS-target-libgcc: \ - configure-target-libgcc - @: $(MAKE); $(unstage) - @[ -f $(TARGET_SUBDIR)/libgcc/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(NORMAL_TARGET_EXPORTS) \ - echo "Doing TAGS in $(TARGET_SUBDIR)/libgcc"; \ - for flag in $(EXTRA_TARGET_FLAGS); do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - (cd $(TARGET_SUBDIR)/libgcc && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libgcc doesn't support TAGS. +TAGS-target-libgcc: @endif target-libgcc @@ -50057,24 +49995,8 @@ maybe-TAGS-target-libobjc: @if target-libobjc maybe-TAGS-target-libobjc: TAGS-target-libobjc -TAGS-target-libobjc: \ - configure-target-libobjc - @: $(MAKE); $(unstage) - @[ -f $(TARGET_SUBDIR)/libobjc/Makefile ] || exit 0; \ - r=`${PWD_COMMAND}`; export r; \ - s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \ - $(NORMAL_TARGET_EXPORTS) \ - echo "Doing TAGS in $(TARGET_SUBDIR)/libobjc"; \ - for flag in $(EXTRA_TARGET_FLAGS); do \ - eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export \1|"`; \ - done; \ - (cd $(TARGET_SUBDIR)/libobjc && \ - $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \ - "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \ - "RANLIB=$${RANLIB}" \ - "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" "WINDMC=$${WINDMC}" \ - TAGS) \ - || exit 1 +# libobjc doesn't support TAGS. +TAGS-target-libobjc: @endif target-libobjc ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] Allow `make tags` to work from top-level directory 2021-10-12 19:56 ` Eric Gallager 2021-10-12 21:03 ` Eric Gallager @ 2021-10-14 16:26 ` Jeff Law 1 sibling, 0 replies; 8+ messages in thread From: Jeff Law @ 2021-10-14 16:26 UTC (permalink / raw) To: Eric Gallager; +Cc: Jeff Law, gcc-patches On 10/12/2021 1:56 PM, Eric Gallager wrote: > On Tue, Oct 12, 2021 at 9:18 AM Jeff Law <jeffreyalaw@gmail.com> wrote: >> >> >> On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote: >>> On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager <egall@gwmail.gwu.edu> wrote: >>>> On 10/13/16, Jeff Law <law@redhat.com> wrote: >>>>> On 10/06/2016 07:21 AM, Eric Gallager wrote: >>>>>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS >>>>>> targets in their Makefiles. The attached patch causes them to be >>>>>> skipped when running `make tags`. >>>>>> >>>>>> ChangeLog entry: >>>>>> >>>>>> 2016-10-06 Eric Gallager <egall@gwmail.gwu.edu> >>>>>> >>>>>> * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing >>>>>> TAGS target. >>>>>> * Makefile.in: Regenerate. >>>>>> >>>>> OK. Please install. >>>>> >>>>> Thanks, >>>>> Jeff >>>>> >>>> I'm still waiting to hear back from <assign@gnu.org> about my request >>>> for copyright assignment, which I'll need to get sorted out before I >>>> can start committing stuff (like this patch). >>>> >>>> Thanks, >>>> Eric >>> Update: In the intervening years, I got my copyright assignment filed >>> and have recently become able to commit again; is your old approval >>> from 2016 still valid, Jeff, or do I need a re-approval? >>> Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html >> It's still valid. Just re-test and commit. >> >> jeff > While re-testing, it seems that the `etags` command on my computer > can't be found any longer; I'm thinking gcc/Makefile.in should be > updated to stop hardcoding etags and use a variable that can be > overridden instead... should I do a separate patch for that, or > combine it with this one? I think this will be simple enough that either way will be fine. jeff ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-10-14 16:26 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-10-06 13:21 [PATCH] Allow `make tags` to work from top-level directory Eric Gallager 2016-10-13 18:38 ` Jeff Law 2016-10-13 20:44 ` Eric Gallager 2021-10-11 22:05 ` Eric Gallager 2021-10-12 13:18 ` Jeff Law 2021-10-12 19:56 ` Eric Gallager 2021-10-12 21:03 ` Eric Gallager 2021-10-14 16:26 ` Jeff Law
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).