From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa34.google.com (mail-vk1-xa34.google.com [IPv6:2607:f8b0:4864:20::a34]) by sourceware.org (Postfix) with ESMTPS id 192803857825 for ; Fri, 6 May 2022 01:30:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 192803857825 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gwmail.gwu.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gwmail.gwu.edu Received: by mail-vk1-xa34.google.com with SMTP id e144so2916670vke.9 for ; Thu, 05 May 2022 18:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gwmail.gwu.edu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=dsK6Ze9Z2cFXTkZ8hby14qDFqP13jjJ5PDtrX1Pg368=; b=Pg+2W0PNn/INmW9nQnuDuEb/EZg9/cCf3rh2TaBwfcU193SGs7b7grXyfList+a7EM /16VWIqdHjiQF76U1tn998MfgMqowxRDFEj4LssWpiU7lTQCEv5pYLFP5h/1UmzGr2KJ XsskvZNrMgEmX9wQmQO4P4lu99+u9n93yRnDrGvGx9Dy/4F2t4g7a5sEgX1YtMSCfChs sI42lk2L2do1dcpyqCmnHjhwU0llWa5eRMh7wFsHhdaO9RF2qYgp8vTZUrpfqgCbv984 mXzIpUt7qpNCvnE1FPp5pgXzgQWE9QhQF3ECBUp2Oy1dUJ0DzlWGGeEHdhppAYifzuZz ZmRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=dsK6Ze9Z2cFXTkZ8hby14qDFqP13jjJ5PDtrX1Pg368=; b=dfcg2Pi1HG9JNcsgIJnODLa3uaX1353p7vS5MBVjbTHeA5qTh1C32cOYuCzNl5XAtu 56GEYrquz3/AGE8EXJzXE7SjszBVtQ03Rncraolr47f+15w7HFx04+9uoYLo7Kfysiyf tOtNylsNSEwZedk+MBCahL1PMNyh3qGRQCO4BaBuQill5CwKL/SgmET6lfrICbDe9QlG Rr5HripcV8JsvYi6SoneW5SlIUz/xe8+MoGZL+j/KAk0LGpejU1jTz8AC9V/wXE3s0O4 VELSHv6sPJfk2/hx5Ts16QgdKKTiasqVsMGqFQc1QJ/qMpDJqLiWJWbV5AMqbMUNC1hx 9kBg== X-Gm-Message-State: AOAM532Q6D9tiLLZy9oenPs+kWpKab013Ngu2gaPFthVifNXOVFXL7ow Aib5q4qQe4LdBFjw+p6VowK0kd6xD7xh9gYZCDbciw== X-Google-Smtp-Source: ABdhPJwTujnYO8+qbUop4TInPRAjvFcVPe8JFAQx+DrOjwb5T7bJ6rim1mvvYAhtAvpN/nAer6GQqvDHBLfZtCEK+ls= X-Received: by 2002:a1f:2c4b:0:b0:345:698:582a with SMTP id s72-20020a1f2c4b000000b003450698582amr353089vks.25.1651800653065; Thu, 05 May 2022 18:30:53 -0700 (PDT) MIME-Version: 1.0 References: <657a408d-7d92-0714-5528-230e3f17ad93@suse.cz> In-Reply-To: From: Eric Gallager Date: Thu, 5 May 2022 21:30:41 -0400 Message-ID: Subject: Re: [PATCH] Remove non-ANSI C path in ansidecl.h. To: Richard Biener Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2022 01:30:55 -0000 On Thu, May 5, 2022 at 8:27 AM Richard Biener via Gcc-patches wrote: > > On Thu, May 5, 2022 at 2:19 PM Martin Li=C5=A1ka wrote: > > > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > > > Ready to be installed? > > Thanks, > > Martin > > > > include/ChangeLog: > > > > * ansidecl.h (PTR): Remove Not ANCI C part. > > --- > > include/ansidecl.h | 16 +--------------- > > 1 file changed, 1 insertion(+), 15 deletions(-) > > > > diff --git a/include/ansidecl.h b/include/ansidecl.h > > index 4275c9b9cbd..f42c6afc7e9 100644 > > --- a/include/ansidecl.h > > +++ b/include/ansidecl.h > > @@ -89,21 +89,7 @@ So instead we use the macro below and test it agains= t specific values. */ > > # endif > > #endif > > > > -#else /* Not ANSI C. */ > > - > > -#define PTR char * > > - > > -/* some systems define these in header files for non-ansi mode */ > > -#undef const > > -#undef volatile > > -#undef signed > > -#undef inline > > -#define const > > -#define volatile > > -#define signed > > -#define inline > > - > > -#endif /* ANSI C. */ > > You'd have to ask the sourceware side as well (binutils), but for sure > either the > guarding #if should be removed or the #else path should contain an #error= . Maybe just make it a #warning for one release, and then if no one complains, turn it into an #error in the following release? > > Richard. > > > +#endif > > > > /* Define macros for some gcc attributes. This permits us to use the > > macros freely, and know that they will come into play for the > > -- > > 2.36.0 > >