From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x931.google.com (mail-ua1-x931.google.com [IPv6:2607:f8b0:4864:20::931]) by sourceware.org (Postfix) with ESMTPS id 789453857C69 for ; Mon, 1 Aug 2022 15:40:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 789453857C69 Received: by mail-ua1-x931.google.com with SMTP id 5so4713844uay.5 for ; Mon, 01 Aug 2022 08:40:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5k4pljIwYu/Oae9ylQtx8ZzL4me/k29c/hqi61BuYU0=; b=kTpC/m4nWgi9xUIZ/kIYt3B/LZBQm5XN9X0lhRLldMeVdO8/VjLgLGw5Ls+2NW+p8Z sI7IZT/WKv0SWcytprF3CrYfp/Jwgjh8igRsf8M4g0bQIFofp3GXGRU3GoiRakXG+a3o StpNlv7HTXRmjPEIVIzdiPrECn8Yq7EEoN8eE7uT8ae4x94tj/na9Hseh+6g8fSqw6VR HbJcwvRXwAO2xiX1tAEDw75u9GPEyMZJ8cf8vTDmiggdEQQULLd2h6/d1ZM7NVV926I4 a7SGJMbQWJZchB+ov3lkJqVDDeSjEev9eICp4U4u08LbYn5B9LFUxjW2qyeWXWnrSsfR g9Cg== X-Gm-Message-State: ACgBeo0Uth+4ehkXeSfnQoi7+akMU90bdR2l4jkO1ickImUqAxn4MbR1 OgJ92SDfZ9cQLrRMwz4dv6T4SQZLnBp67T8HyF+ndg== X-Google-Smtp-Source: AA6agR78FIsUfW2PYd7MYEH/e1Jpn44TdAIaoj10t8aqBEj5EurU+l+/nduiKm/zKORNVlhCIUqXn6UvTRX0x45lqsY= X-Received: by 2002:ab0:2150:0:b0:384:ba63:69f9 with SMTP id t16-20020ab02150000000b00384ba6369f9mr6359473ual.100.1659368446842; Mon, 01 Aug 2022 08:40:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Gallager Date: Mon, 1 Aug 2022 11:40:35 -0400 Message-ID: Subject: Re: [PATCH] configure: respect --with-build-time-tools [PR43301] To: Andreas Schwab Cc: Eric Gallager via Gcc-patches , Paolo Bonzini , aoliva@gcc.gnu.org, neroden@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2022 15:40:49 -0000 On Mon, Aug 1, 2022 at 3:54 AM Andreas Schwab wrote: > > On Jul 31 2022, Eric Gallager via Gcc-patches wrote: > > > It just makes the configure script respect the --with-build-time-tools > > flag. > > Why does it make any difference? > See the original bug report: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=43301 > > diff --git a/configure b/configure > > index 65d7078dbe7..4d46b94ebc4 100755 > > --- a/configure > > +++ b/configure > > @@ -12850,7 +12850,9 @@ fi > > # Check whether --with-build-time-tools was given. > > if test "${with_build_time_tools+set}" = set; then : > > withval=$with_build_time_tools; case x"$withval" in > > - x/*) ;; > > + x/*) > > + with_build_time_tools=$withval > > This just reassigns the value that was retrieved a couple of lines > above from the very same variable. > Oh, ok, so I guess this isn't necessary after all? In which case we can just close 43301 as INVALID then? > -- > Andreas Schwab, SUSE Labs, schwab@suse.de > GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 > "And now for something completely different."