From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66013 invoked by alias); 27 Jul 2015 22:16:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 65996 invoked by uid 89); 27 Jul 2015 22:16:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yk0-f173.google.com Received: from mail-yk0-f173.google.com (HELO mail-yk0-f173.google.com) (209.85.160.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 27 Jul 2015 22:16:51 +0000 Received: by ykfw194 with SMTP id w194so81252670ykf.0 for ; Mon, 27 Jul 2015 15:16:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=YXMyYmNC+yvqGN8IisdBJNLJxbsnxs2qj3kx8ONUsT0=; b=jQcFAb05D0iIWtjNrdBMtDFIft7dPGrk+H9bhie/E/qYMXr6PvbMi6b22ylIriKJWr q/pniBEZO2f9TaeWKpJpzHe1ozLNNTmr6GMJXtoTG6tHdEwNhPuvgGxW3MnFjkPYDPKX T08LW9ZZyklmD5yZ8XMaQJvz40CyUM9/yQAl28aNpCbbBZ0g/MYK3DH61PWr/gx0IVDb V0UaIBmB0jNN38Jdbenhu4CcUTd8Z7uKQWnwvulKGPlUaVw6IRyY9KRV7Xewnc5yzeRc q7pBASMpL2J1Ho4Xxx2RczXyEQk15gw1BT+JFMB4CgeWLTML2ZG/BQxtjP8G731pa19h ly4w== X-Gm-Message-State: ALoCoQlMwArPNK8xI/hJfrS++LIN3knEGWtZXaTHs4qNle43nRxFxSb4EftQXfn3psvkANDxu3jb MIME-Version: 1.0 X-Received: by 10.170.121.141 with SMTP id n135mr33186586ykb.125.1438035409231; Mon, 27 Jul 2015 15:16:49 -0700 (PDT) Received: by 10.37.116.142 with HTTP; Mon, 27 Jul 2015 15:16:49 -0700 (PDT) In-Reply-To: <559AD9A7.1080007@redhat.com> References: <559AD9A7.1080007@redhat.com> Date: Mon, 27 Jul 2015 22:33:00 -0000 Message-ID: Subject: Re: [patch] [fixincludes] Ignore .DS_Store junk files when running make check From: Eric Gallager To: Jeff Law Cc: Andreas Schwab , gcc-patches , bkorb@gnu.org Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2015-07/txt/msg02304.txt.bz2 On 7/6/15, Jeff Law wrote: > On 07/05/2015 04:58 PM, Eric Gallager wrote: >> I was just matching the code that was already used there... should the >> lines to ignore the CVS and .svn folders be re-written into the style >> you propose, too? > Might as well have a consistent style. Embedding them into the "find" > ought to be marginally faster than a pipeline of fgrep processes. > > jeff > Okay, I tried embedding "! -name CVS/ ! -name .svn/" into the find command, too, but that just led to warnings such as: find: warning: Unix filenames usually don't contain slashes (though pathnames do). That means that '-name `CVS/'' will probably evaluate to false all the time on this system. You might find the '-wholename' test more useful, or perhaps '-samefile'. Alternatively, if you are using GNU grep, you could use 'find ... -print0 | grep -FzZ `CVS/''. find: warning: Unix filenames usually don't contain slashes (though pathnames do). That means that '-name `.svn/'' will probably evaluate to false all the time on this system. You might find the '-wholename' test more useful, or perhaps '-samefile'. Alternatively, if you are using GNU grep, you could use 'find ... -print0 | grep -FzZ `.svn/''. I'm not really sure which of these alternatives to go with... cc-ing the fixincludes maintainer to see which he wants to go with...