From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by sourceware.org (Postfix) with ESMTPS id 357AC385840E for ; Fri, 12 May 2023 21:56:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 357AC385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91727658F9 for ; Fri, 12 May 2023 21:56:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 000FEC4339C for ; Fri, 12 May 2023 21:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683928612; bh=pfrWnKGqIQXFQXrNXE2QZoVe+Cb2cknvTUSVNRUJF1c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JRzFvRA8vqnt3ey0YNtEd7ebJDDCFdR2bn7U+qw+/qI0AURed4MOyeq0EUeCtHoJ2 5p8q5n3OZDSsTl0ceSftuE1EDmLiZbe0GHtoX4nhxq2KINPchi0ktrz17KIlRAmjJ1 cCofJVgtFj4LuZdqrJ3PrrAelCqcCuhYpKyTKu974Nu6dtafl8HytbzB9lE4/WjtWE doECbPkZnzI4VU0+TFMiFv/iR0fNM9AWnYs8Y1CwLKj9xt5oJu3Nu6hNRiJTdw9Dqe tFzwYQLjQQ/pCa/weMs31CJria+fT7ycymvYmnhISEBrg7LUI74MR+eTTPfSwtvT6P ePp1zn5UZ+BAg== Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ac8d9399d5so96254961fa.1 for ; Fri, 12 May 2023 14:56:51 -0700 (PDT) X-Gm-Message-State: AC+VfDwVSF/MSfXgiJtEW+NMQafhtScjHxEMblKzgE53hXx77g9hWeaV lxSZREzX5jSPQ9PIMiu8IRZbegO3NFxx0vG127g= X-Google-Smtp-Source: ACHHUZ4NbvdkujfsGqsMDRwLpOYyIvRcv46ZCWTWWfBlMqZX3VdbvdT+1qXgyqnmRLVe1gmXBFEpVMK+fm4FWDKepSo= X-Received: by 2002:a2e:8883:0:b0:2a8:e53f:c174 with SMTP id k3-20020a2e8883000000b002a8e53fc174mr4475710lji.26.1683928610043; Fri, 12 May 2023 14:56:50 -0700 (PDT) MIME-Version: 1.0 References: <20230509085835.1143661-1-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Fri, 12 May 2023 23:56:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] i386: Honour -mdirect-extern-access when calling __fentry__ To: Uros Bizjak Cc: "H.J. Lu" , gcc-patches@gcc.gnu.org, keescook@chromium.org, Jakub Jelinek , Richard Biener , Hou Wenlong Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 12 May 2023 at 19:05, Uros Bizjak wrote: > > On Fri, May 12, 2023 at 4:07=E2=80=AFPM Ard Biesheuvel = wrote: > > > > > > > Note that the GOT reference in question is in fact a data refer= ence: we > > > > > > explicitly load the address of __fentry__ from the GOT, which a= mounts to > > > > > > eager binding, rather than emitting a PLT call that could bind = eagerly, > > > > > > lazily or directly at link time. > > > > > > > > > > > > gcc/ChangeLog: > > > > > > > > > > > > * config/i386/i386.cc (x86_function_profiler): Take > > > > > > ix86_direct_extern_access into account when generatin= g calls > > > > > > to __fentry__() > > > > > > > > > > HJ, is the patch OK with you? > > > > > > > > LGTM. > > > > > > OK then. > > > > > > > Thanks all. Is anything expected of me at this point? > > Do you have write access to the repository? If not I can commit the > patch for you Yes, please. , but you should state this [1] in your patch submission. > > [1] https://gcc.gnu.org/contribute.html > Signed-off-by: Ard Biesheuvel Thanks,