From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5127C3858404 for ; Fri, 10 Dec 2021 02:14:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5127C3858404 Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-294-LnlRXOzuPPy_UeMpJK0rVg-1; Thu, 09 Dec 2021 21:14:48 -0500 X-MC-Unique: LnlRXOzuPPy_UeMpJK0rVg-1 Received: by mail-oi1-f198.google.com with SMTP id s4-20020a05680810c400b002bf76bbfa9bso5167561ois.19 for ; Thu, 09 Dec 2021 18:14:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2zqWHNLjsRgEtxf4yaA2MAyBPrLC0WcV7qLrYqoHkmE=; b=gcgPjkzZi1QydQVx29sDhRDyPo06PG/uz4lBJKuJ2h/DqB2hJgvlA5JdY7LCdjrd9x X/fO/eBPWJZ41RT5d3fLhT+4s2GKiYuEeimDjO6my80b4+MYQR9l3aAIWuHvMKW1qyC1 Lct7Ju+Cll9lYXPwCI4JUlLLrMpsCsaSiFqHb3/nHiVkIqrIH+KMYiinm/IJydGs3ffs 8kF5wQl8zMQSvIwoXEjfynHGLWvZpsrapkXQwk5Z6URWwhf5leUbchEYpXcZ8p4/nbL/ PBVohJeSCA3h+zDUgEVBRtpm2SqOuomlxkUWw+fjJXsDnKjM8whtZVjN6Fi1YIBqHFm5 aO1g== X-Gm-Message-State: AOAM532Mjeq5ea+z42bcuoP4tQ2gcMYWJi8xvgEs8ymfxr623jXaUWCl rlLkrMn81dgtjEGuXrw5m3iBAO4188VvV5lKlZ7+3SgR9JFI3IArAXtSGfWBdzXDShcWrUfSYfB WaXrbmt6J9DkM2PMCE19OYpKC/NPtvCujNw== X-Received: by 2002:aca:a941:: with SMTP id s62mr9834612oie.87.1639102488024; Thu, 09 Dec 2021 18:14:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvQmFKtku6PZ29p2EaXu7k9Fh/Ln969z6EVMwBntG3CoyyJRhOipPgPO92atHWCPwrVtGd4oajccVha2M3QBo= X-Received: by 2002:aca:a941:: with SMTP id s62mr9834600oie.87.1639102487828; Thu, 09 Dec 2021 18:14:47 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Thomas Rodgers Date: Thu, 9 Dec 2021 18:14:36 -0800 Message-ID: Subject: Re: libstdc++: Make atomic::wait() const [PR102994] To: Jonathan Wakely Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 02:14:51 -0000 Tested uild-x86_64-pc-linux-gnu, pushed to trunk and gcc-11. On Thu, Nov 25, 2021 at 1:24 PM Jonathan Wakely wrote: > On Wed, 24 Nov 2021 at 01:27, Thomas Rodgers wrote: > > > > const qualification was also missing in the free functions for > wait/wait_explicit/notify_one/notify_all. Revised patch attached. > > Please tweak the whitespace in the new test: > > > +test1(const std::atomic &a, char*p) > > The '&' should be on the type not the variable, and there should be a > space before 'p': > > > +test1(const std::atomic& a, char* p) > > OK for trunk and gcc-11 with that tweak, thanks! > >