From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 644683858D1E for ; Mon, 26 Jun 2023 18:58:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 644683858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687805883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6XbJkL8ZueWrRehiMkTJoF7vBzb+frgVdcAzUqQG8ZM=; b=MVJKSH3ogsmmnbD1AVahqRLtPl1DZFW09E6AbMW140NFBBtBMkWDW5A0xXB1yFGI54Znla 4wIxfBOnkuK4iSAof128yaRtxFqv5CMCB2jmlEo75FgLUIh5uHIdpb4uDp/6FSl+t0BMoX wqJkQB/xGpLv1Qdyt/n7Ex6wzbXx7kQ= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-gbjYmUrVPMG43VEsgmB18w-1; Mon, 26 Jun 2023 14:58:01 -0400 X-MC-Unique: gbjYmUrVPMG43VEsgmB18w-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-262f872fdcdso609667a91.1 for ; Mon, 26 Jun 2023 11:58:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687805880; x=1690397880; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Zc01isBH/iJY72BsfEQHhXT0rbI6TkxLTYTeX6caF/Q=; b=J2XBNRcBooRD8DjP6h+cKjBxRrjKujMbZrlUbVvzU1DVWjqMGmvfm14/wUxHZgtwrZ 3NZd82pijJhUUqjRHtXBgP9zkCc4RzDpaPjKNvrqbF4CQ3Je6u8W7r/0CqhkJ4N74Ij/ VuLMptmU8/CC4OkoaAswybYtRc+wqvvpTP7dtyZYUck3xEOdYVr2t6IK4FnrMq3rVa4B PIN7R5zjno6o+DV8cu1OFHZbfeLYatzsGsqO1G8e9FaM1kmGuYi8DPyPcOcpLDiBRlYX QUHdMfTpA2Ay0+KA+QdI3wd/7r6Kjdj3lOaAw1SQU8mIkq/rUI97sMyIbaprDHGEM1vk KJxg== X-Gm-Message-State: AC+VfDykuDe9/XaSFwWd3d2fmTzwSWXo7lRfopWTweuY07XWyJH0Ueyf vEu0ryhDQ8E0838MQM91Lo3Ie1G9nVXlXMywWtQN0ariSRruR5FyN93V2mjghtilU7nkGa+OfX7 RAm3/ZzAkFcu27yT9H2ajHYI6Rs0DqsKKWg== X-Received: by 2002:a17:90a:f2c7:b0:263:d04:ef62 with SMTP id gt7-20020a17090af2c700b002630d04ef62mr720805pjb.27.1687805880494; Mon, 26 Jun 2023 11:58:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7puupRMcUFcpqWszUHyYylxMh6NXnEl06hq0Xud+2xbQiG8iSKeAi7OWM2qKnBlFCrSq55eYEIZP6EG5SldA8= X-Received: by 2002:a17:90a:f2c7:b0:263:d04:ef62 with SMTP id gt7-20020a17090af2c700b002630d04ef62mr720793pjb.27.1687805880227; Mon, 26 Jun 2023 11:58:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Thomas Rodgers Date: Mon, 26 Jun 2023 11:57:49 -0700 Message-ID: Subject: Re: [PATCH] libstdc++: Synchronize PSTL with upstream To: Jonathan Wakely Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000f0f3ac05ff0cede1" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f0f3ac05ff0cede1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, May 17, 2023 at 12:32=E2=80=AFPM Jonathan Wakely wrote: > -template > - _OutputIterator > -__brick_generate_n(_OutputIterator __first, _Size __count, _Generator > __g, /* is_vector =3D */ std::true_type) noexcept > +template > > Missing uglification on Size. > > +_RandomAccessIterator > +__brick_generate_n(_RandomAccessIterator __first, Size __count, > _Generator __g, > + /* is_vector =3D */ std::true_type) noexcept > { > return __unseq_backend::__simd_generate_n(__first, __count, __g); > } > > -template > - _OutputIterator > -__brick_generate_n(_OutputIterator __first, _Size __count, _Generator > __g, /* is_vector =3D */ std::false_type) noexcept > +template > > Missing uglification on OutputIterator and Size. > > +OutputIterator > +__brick_generate_n(OutputIterator __first, Size __count, _Generator __g, > /* is_vector =3D */ std::false_type) noexcept > > > -template _BinaryOperation> > -_ForwardIterator2 > -__brick_adjacent_difference(_ForwardIterator1 __first, _ForwardIterator1 > __last, _ForwardIterator2 __d_first, > - _BinaryOperation __op, /*is_vector=3D*/std::true_type) noexcept > +template class BinaryOperation> > > Missing uglification on BinaryOperation. > > +_RandomAccessIterator2 > +__brick_adjacent_difference(_RandomAccessIterator1 __first, > _RandomAccessIterator1 __last, > + _RandomAccessIterator2 __d_first, > BinaryOperation __op, > + /*is_vector=3D*/std::true_type) noexcept > > > The above problems exist on the declaration and the definitions. > > > --- a/libstdc++-v3/include/pstl/glue_execution_defs.h > +++ b/libstdc++-v3/include/pstl/glue_execution_defs.h > @@ -18,8 +18,8 @@ namespace std > { > // Type trait > using __pstl::execution::is_execution_policy; > -#if _PSTL_CPP14_VARIABLE_TEMPLATES_PRESENT > -# if __INTEL_COMPILER > +#if defined(_PSTL_CPP14_VARIABLE_TEMPLATES_PRESENT) > +# if defined(__INTEL_COMPILER) > template > constexpr bool is_execution_policy_v =3D is_execution_policy::value; > # else > > Pre-existing, but that T should be _Tp, but it only affects the Intel > compiler branch, so meh. > > Please fix these and report them upstream too. > Ack. > > All the actual code changes look good. > > I think I'd prefer if __pattern_partial_sort_copy used > std::uninitialized_copy instead of a loop and placement-new, but that > doesn't need to hold this up. We could optimize some uses of > std::conjunction and std::conditional to use our own __and_ and > __conditional, but I'm not sure it's worth diverging from upstream to do > that. > > Please fix the naming bugs noted above and push to trunk, thanks! > There were a handful of additional missed uglifications in - * libstdc++-v3/include/pstl/glue_algorithm_impl.h * libstdc++-v3/include/pstl/unseq_backend_simd.h That are in this commit, but not in the patch as reviewed. Tested x86_64-linux. Pushed to trunk. > > +Reviewed-by: Jonathan Wakely > > > > > > --000000000000f0f3ac05ff0cede1--