From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24440 invoked by alias); 27 Sep 2011 06:52:40 -0000 Received: (qmail 24432 invoked by uid 22791); 27 Sep 2011 06:52:39 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f175.google.com (HELO mail-iy0-f175.google.com) (209.85.210.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Sep 2011 06:52:16 +0000 Received: by iadx2 with SMTP id x2so6345705iad.20 for ; Mon, 26 Sep 2011 23:52:15 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.28.205 with SMTP id n13mr3321137ibc.47.1317106335552; Mon, 26 Sep 2011 23:52:15 -0700 (PDT) Received: by 10.231.118.153 with HTTP; Mon, 26 Sep 2011 23:52:15 -0700 (PDT) In-Reply-To: References: Date: Tue, 27 Sep 2011 07:48:00 -0000 Message-ID: Subject: Re: MIPS Fix PR18141 From: Dinar Temirbulatov To: Dinar Temirbulatov , gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Content-Type: multipart/mixed; boundary=001517740bdc4315f804ade6b718 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01689.txt.bz2 --001517740bdc4315f804ade6b718 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1100 hi, Richard On Mon, Sep 26, 2011 at 11:50 AM, Richard Sandiford wrote: > Dinar Temirbulatov writes: >> I found typo in the patch instead of checking *set_after !=3D 0 it was >> set_after !=3D 0, =A0here is corrected version of patch. I retested the >> patch without typo on mipsel-unknown-linux-gnu with no new >> regressions. > > But my point was that *set_after should always be nonnull if *delayed_reg > is. =A0So we shouldn't need that check anyway. oh, sorry that I missed that. > The patch looks OK otherwise apart from formatting (the formatting should > be the same as in the version I suggested before: > > =A0else if (*delayed_reg !=3D 0 > =A0 =A0 =A0 =A0 =A0&& reg_referenced_p (*delayed_reg, pattern) > =A0 =A0 =A0 =A0 =A0&& !(recog_memoized (insn) =3D=3D CODE_FOR_load_highdf > =A0 =A0 =A0 =A0 =A0 =A0 =A0 && recog_memoized (*set_after) =3D=3D CODE_FO= R_load_lowdf)) > I prepared the new version of patch, re-tested new version on again on mipsel-unknown-linux-gnu with no new regressions. thanks, Dinar. --001517740bdc4315f804ade6b718 Content-Type: text/x-patch; charset=US-ASCII; name="fix.patch" Content-Disposition: attachment; filename="fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt2j1y9d0 Content-length: 4571 ZGlmZiAtcnVOcCBnY2MtMjAxMTA5MTItb3JpZy9nY2MvY29uZmlnL21pcHMv bWlwcy5jIGdjYy0yMDExMDkxMi1maXhlZC9nY2MvY29uZmlnL21pcHMvbWlw cy5jCi0tLSBnY2MtMjAxMTA5MTItb3JpZy9nY2MvY29uZmlnL21pcHMvbWlw cy5jCTIwMTEtMDktMTIgMTc6MjI6MjcuNTc2NDU3MTIxICswNDAwCisrKyBn Y2MtMjAxMTA5MTItZml4ZWQvZ2NjL2NvbmZpZy9taXBzL21pcHMuYwkyMDEx LTA5LTI3IDA3OjU3OjI4LjA4NzM2NjE2MyArMDQwMApAQCAtMTQ2NTksMjAg KzE0NjU5LDIwIEBAIG1pcHNfb3JwaGFuZWRfaGlnaF9wYXJ0X3AgKGh0YWJf dCBodGFiLAogICAgSU5TTiBhbmQgYSBwcmV2aW91cyBpbnN0cnVjdGlvbiwg YXZvaWQgaXQgYnkgaW5zZXJ0aW5nIG5vcHMgYWZ0ZXIKICAgIGluc3RydWN0 aW9uIEFGVEVSLgogCi0gICAqREVMQVlFRF9SRUcgYW5kICpISUxPX0RFTEFZ IGRlc2NyaWJlIHRoZSBoYXphcmRzIHRoYXQgYXBwbHkgYXQKLSAgIHRoaXMg cG9pbnQuICBJZiAqREVMQVlFRF9SRUcgaXMgbm9uLW51bGwsIElOU04gbXVz dCB3YWl0IGEgY3ljbGUKLSAgIGJlZm9yZSB1c2luZyB0aGUgdmFsdWUgb2Yg dGhhdCByZWdpc3Rlci4gICpISUxPX0RFTEFZIGNvdW50cyB0aGUKLSAgIG51 bWJlciBvZiBpbnN0cnVjdGlvbnMgc2luY2UgdGhlIGxhc3QgaGlsbyBoYXph cmQgKHRoYXQgaXMsCi0gICB0aGUgbnVtYmVyIG9mIGluc3RydWN0aW9ucyBz aW5jZSB0aGUgbGFzdCBNRkxPIG9yIE1GSEkpLgorICAgKkRFTEFZRURfUkVH LCAqU0VUX0FGVEVSIGFuZCAqSElMT19ERUxBWSBkZXNjcmliZSB0aGUgaGF6 YXJkcyB0aGF0IAorICAgYXBwbHkgYXQgdGhpcyBwb2ludC4gIElmICpERUxB WUVEX1JFRyBhbmQgKlNFVF9BRlRFUiBpcyBub24tbnVsbCwgCisgICBJTlNO IG11c3Qgd2FpdCBhIGN5Y2xlIGJlZm9yZSB1c2luZyB0aGUgdmFsdWUgb2Yg dGhhdCByZWdpc3Rlci4gIAorICAgKkhJTE9fREVMQVkgY291bnRzIHRoZSBu dW1iZXIgb2YgaW5zdHJ1Y3Rpb25zIHNpbmNlIHRoZSBsYXN0IGhpbG8gaGF6 YXJkIAorICAgKHRoYXQgaXMsIHRoZSBudW1iZXIgb2YgaW5zdHJ1Y3Rpb25z IHNpbmNlIHRoZSBsYXN0IE1GTE8gb3IgTUZISSkuCiAKLSAgIEFmdGVyIGlu c2VydGluZyBub3BzIGZvciBJTlNOLCB1cGRhdGUgKkRFTEFZRURfUkVHIGFu ZCAqSElMT19ERUxBWQotICAgZm9yIHRoZSBuZXh0IGluc3RydWN0aW9uLgor ICAgQWZ0ZXIgaW5zZXJ0aW5nIG5vcHMgZm9yIElOU04sIHVwZGF0ZSAqREVM QVlFRF9SRUcsICpTRVRfQUZURVIKKyAgIGFuZCAqSElMT19ERUxBWSBmb3Ig dGhlIG5leHQgaW5zdHJ1Y3Rpb24uCiAKICAgIExPX1JFRyBpcyBhbiBydHgg Zm9yIHRoZSBMTyByZWdpc3RlciwgdXNlZCBpbiBkZXBlbmRlbmNlIGNoZWNr aW5nLiAgKi8KIAogc3RhdGljIHZvaWQKIG1pcHNfYXZvaWRfaGF6YXJkIChy dHggYWZ0ZXIsIHJ0eCBpbnNuLCBpbnQgKmhpbG9fZGVsYXksCi0JCSAgIHJ0 eCAqZGVsYXllZF9yZWcsIHJ0eCBsb19yZWcpCisJCSAgIHJ0eCAqZGVsYXll ZF9yZWcsIHJ0eCBsb19yZWcsIHJ0eCAqc2V0X2FmdGVyKQogewogICBydHgg cGF0dGVybiwgc2V0OwogICBpbnQgbm9wcywgbmluc25zOwpAQCAtMTQ2OTYs NyArMTQ2OTYsMTAgQEAgbWlwc19hdm9pZF9oYXphcmQgKHJ0eCBhZnRlciwg cnR4IGluc24sCiAgICAgIGNsb2JiZXIgaGkgYW5kIGxvLiAgKi8KICAgaWYg KCpoaWxvX2RlbGF5IDwgMiAmJiByZWdfc2V0X3AgKGxvX3JlZywgcGF0dGVy bikpCiAgICAgbm9wcyA9IDIgLSAqaGlsb19kZWxheTsKLSAgZWxzZSBpZiAo KmRlbGF5ZWRfcmVnICE9IDAgJiYgcmVnX3JlZmVyZW5jZWRfcCAoKmRlbGF5 ZWRfcmVnLCBwYXR0ZXJuKSkKKyAgZWxzZSBpZiAoKmRlbGF5ZWRfcmVnICE9 IDAgCisJICAgICYmIHJlZ19yZWZlcmVuY2VkX3AgKCpkZWxheWVkX3JlZywg cGF0dGVybikKKwkgICAgJiYgIShyZWNvZ19tZW1vaXplZCAoaW5zbikgPT0g Q09ERV9GT1JfbG9hZF9oaWdoZGYKKwkgICAgICAgJiYgcmVjb2dfbWVtb2l6 ZWQgKCpzZXRfYWZ0ZXIpID09IENPREVfRk9SX2xvYWRfbG93ZGYpKQogICAg IG5vcHMgPSAxOwogICBlbHNlCiAgICAgbm9wcyA9IDA7CkBAIC0xNDcxMCw2 ICsxNDcxMyw3IEBAIG1pcHNfYXZvaWRfaGF6YXJkIChydHggYWZ0ZXIsIHJ0 eCBpbnNuLAogICAvKiBTZXQgdXAgdGhlIHN0YXRlIGZvciB0aGUgbmV4dCBp bnN0cnVjdGlvbi4gICovCiAgICpoaWxvX2RlbGF5ICs9IG5pbnNuczsKICAg KmRlbGF5ZWRfcmVnID0gMDsKKyAgKnNldF9hZnRlciA9IDA7CiAgIGlmIChJ TlNOX0NPREUgKGluc24pID49IDApCiAgICAgc3dpdGNoIChnZXRfYXR0cl9o YXphcmQgKGluc24pKQogICAgICAgewpAQCAtMTQ3MjQsNiArMTQ3MjgsNyBA QCBtaXBzX2F2b2lkX2hhemFyZCAocnR4IGFmdGVyLCBydHggaW5zbiwKIAlz ZXQgPSBzaW5nbGVfc2V0IChpbnNuKTsKIAlnY2NfYXNzZXJ0IChzZXQpOwog CSpkZWxheWVkX3JlZyA9IFNFVF9ERVNUIChzZXQpOworCSpzZXRfYWZ0ZXIg PSBpbnNuOwogCWJyZWFrOwogICAgICAgfQogfQpAQCAtMTQ3MzYsNyArMTQ3 NDEsNyBAQCBtaXBzX2F2b2lkX2hhemFyZCAocnR4IGFmdGVyLCBydHggaW5z biwKIHN0YXRpYyB2b2lkCiBtaXBzX3Jlb3JnX3Byb2Nlc3NfaW5zbnMgKHZv aWQpCiB7Ci0gIHJ0eCBpbnNuLCBsYXN0X2luc24sIHN1Ymluc24sIG5leHRf aW5zbiwgbG9fcmVnLCBkZWxheWVkX3JlZzsKKyAgcnR4IGluc24sIGxhc3Rf aW5zbiwgc3ViaW5zbiwgbmV4dF9pbnNuLCBsb19yZWcsIGRlbGF5ZWRfcmVn LCBzZXRfYWZ0ZXI7CiAgIGludCBoaWxvX2RlbGF5OwogICBodGFiX3QgaHRh YjsKIApAQCAtMTQ4MTEsNyArMTQ4MTYsNyBAQCBtaXBzX3Jlb3JnX3Byb2Nl c3NfaW5zbnMgKHZvaWQpCiAJCQlJTlNOX0NPREUgKHN1Ymluc24pID0gQ09E RV9GT1Jfbm9wOwogCQkgICAgICB9CiAJCSAgICBtaXBzX2F2b2lkX2hhemFy ZCAobGFzdF9pbnNuLCBzdWJpbnNuLCAmaGlsb19kZWxheSwKLQkJCQkgICAg ICAgJmRlbGF5ZWRfcmVnLCBsb19yZWcpOworCQkJCSAgICAgICAmZGVsYXll ZF9yZWcsIGxvX3JlZywgJnNldF9hZnRlcik7CiAJCSAgfQogCSAgICAgIGxh c3RfaW5zbiA9IGluc247CiAJICAgIH0KQEAgLTE0ODMyLDcgKzE0ODM3LDcg QEAgbWlwc19yZW9yZ19wcm9jZXNzX2luc25zICh2b2lkKQogCSAgICAgIGVs c2UKIAkJewogCQkgIG1pcHNfYXZvaWRfaGF6YXJkIChsYXN0X2luc24sIGlu c24sICZoaWxvX2RlbGF5LAotCQkJCSAgICAgJmRlbGF5ZWRfcmVnLCBsb19y ZWcpOworCQkJCSAgICAgJmRlbGF5ZWRfcmVnLCBsb19yZWcsICZzZXRfYWZ0 ZXIpOwogCQkgIGxhc3RfaW5zbiA9IGluc247CiAJCX0KIAkgICAgfQo= --001517740bdc4315f804ade6b718 Content-Type: application/octet-stream; name=ChangeLog Content-Disposition: attachment; filename=ChangeLog Content-Transfer-Encoding: base64 X-Attachment-Id: f_gt2j2yuz1 Content-length: 354 ICAgICAgICBQUiB0YXJnZXQvMTgxNDEKCSogZ2NjL2NvbmZpZy9taXBzL21p cHMuYyAobWlwc19hdm9pZF9oYXphcmQpIEFkZCBzZXRfYWZ0ZXIgcGFyYW1l dGVyLgoJRG9uJ3QgaW5zZXJ0IG5vcCBiZXR3ZWVuIENPREVfRk9SX2xvYWRf bG93ZGYgQ09ERV9GT1JfbG9hZF9oaWdoZGYgaW4gCgljYXNlIG9mIHRoZSBz YW1lIHJlZ2lzdGVyLiAobWlwc19yZW9yZ19wcm9jZXNzX2luc25zKSBBZGQg YW5kIGhhbmRsZSAKCXNldF9hZnRlciBwYXJhbWV0ZXIuCg== --001517740bdc4315f804ade6b718--