From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by sourceware.org (Postfix) with ESMTPS id C72643858D3C for ; Wed, 11 Jan 2023 05:55:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C72643858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2a.google.com with SMTP id 16so14072178ybc.0 for ; Tue, 10 Jan 2023 21:55:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=h95GJzlmykSjTdRYn9dqTAnSO+62IL6eTwpHPsCUx70=; b=gSRZlDuWfLETUzo6PoRMkjcrLn+T5H+pmq6EoyKy0yvywJS8gDYakPLs9UfDVGmUdZ AF3kDouChp37d7zLRragp9H0SRp+/FjQ3zBTxRQtdk3NPjrmUTgKlN9KDpuZjRa1SkSx plVuLDffh+l0LevAMvS3zGuPWAA9aBA5dKHrdcxWEUTWKxfL2RAKwZQkiym9pXFWrl0m PdYYRPxXT8ovbZAKzRnAEFIk3Gb0owlObbTel815WiCIfuWT6Vx6cPvFbdp6rTvwhitM QCKFcr8ZRlsd6WjTXL75/lH86Ml47jUhlHdj7m84Cb93SiioL3I6k+YiC4Vhchb8REQu bLbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h95GJzlmykSjTdRYn9dqTAnSO+62IL6eTwpHPsCUx70=; b=OmK/yj7Nk03Dypc+lsNRZ9vGm6NVeOvpRmLX4UfctyI7pXd3IcS1C7ujAq+m6A9eDa FuacH6tD4R9YiAPRYdK4MLZ2z4otVZMS5YEfm50couRfkJ3ZV/kfLUPtAlavSeBkIk6E vSAVad8EZLHHLubJ91rByQVgXHZWXerJL/X4eVjv4fNoiFRcHD0yQjXbRlusfKN8xgpp Ipuk9ZlRiFgclkLHzd/8OhsbuxVtO9CiNqPh0WX3ZY+qUgcqUSkjk2QWWxN2/tRJtyuY nyoC7PKcA/jltxnCjsgo+GtmvMiORDy1n6jjZE+bJpodYgFH/kdb0i6TQk1FOJGIxUDS yN5Q== X-Gm-Message-State: AFqh2kqk6c0UZI3Cie51z2jyVbIWqWeEpHgOiheyELkHy4oj9WEHsSc5 F7/lQLDyxfHYG2AgRUyboTra9FPzEqb96tiFcqI= X-Google-Smtp-Source: AMrXdXu5OQ4OE2lme8MK8iOL4+Ojs5FHZEBWEzZ4AhuuVRGgJTpRaAD5a7hwLg8PQdjHukTIXzXAHDQzZc+BnVDtGnI= X-Received: by 2002:a25:3257:0:b0:7b8:b82c:ab5d with SMTP id y84-20020a253257000000b007b8b82cab5dmr1394484yby.377.1673416549138; Tue, 10 Jan 2023 21:55:49 -0800 (PST) MIME-Version: 1.0 References: <2203c450-66c4-f100-2fc1-ab7e45cc008f.ref@yahoo.co.jp> <2203c450-66c4-f100-2fc1-ab7e45cc008f@yahoo.co.jp> In-Reply-To: <2203c450-66c4-f100-2fc1-ab7e45cc008f@yahoo.co.jp> From: Max Filippov Date: Tue, 10 Jan 2023 21:55:38 -0800 Message-ID: Subject: Re: [PATCH] xtensa: Make instruction cost estimation for size more accurate To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 9, 2023 at 7:34 PM Takayuki 'January June' Suwa wrote: > > Until now, we applied COSTS_N_INSNS() (multiplying by 4) after dividing > the instruction length by 3, so we couldn't express the difference less > than modulo 3 in insn cost for size (e.g. 11 Bytes and 12 bytes cost the > same). > > This patch fixes that. > > ;; 2 bytes > addi.n a2, a2, -1 ; cost 3 > > ;; 3 bytes > addmi a2, a2, 1024 ; cost 4 > > ;; 4 bytes > movi.n a3, 80 ; cost 5 > bnez.n a2, a3, .L4 > > ;; 5 bytes > srli a2, a3, 1 ; cost 7 > add.n a2, a2, a2 > > ;; 6 bytes > ssai 8 ; cost 8 > src a4, a2, a3 > > :: 3 + 4 bytes > l32r a2, .L5 ; cost 9 > > ;; 11 bytes ; cost 15 > ;; 12 bytes ; cost 16 > > gcc/ChangeLog: > > * config/xtensa/xtensa.cc (xtensa_insn_cost): > Let insn cost for size be obtained by applying COSTS_N_INSNS() > to instruction length and then dividing by 3. > --- > gcc/config/xtensa/xtensa.cc | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) Regtested for target=xtensa-linux-uclibc, no new regressions. Committed to master. -- Thanks. -- Max