From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id CBA5B3834F0B for ; Thu, 26 May 2022 17:04:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBA5B3834F0B Received: by mail-oi1-x229.google.com with SMTP id l84so2793889oif.10 for ; Thu, 26 May 2022 10:04:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w9crHlhmGq8QKpwY0hcrBIN+fvdhVpHGxmQA0azf1gA=; b=k173dZCOguYaXeUXxWEHm0wR6oqbilBuKcUMsA2qc7EoSmSLiB7pf29vj4oHjEruCu Hfw8OKVHyqsTdEm7IqQ6QOlaHMBKVhcwGgBV4Ow9atSDy/eB1yQyUm1MtQshfGkmRG09 GQoQxstIhWPfakzXR0YUWg/e/EXhHh6bgxqIJ9LwJlt79ShE9jk2oIoQcPI4+tTmkeBt EqiY0DhnrLuSn3VWoMkBKutrh9Ltn1ahchIEE3HUeTK4xJ6LbmiSfM2PbjK+0KD0yG3p 63fAuygxrth2gQPf3wOcHmsP3Kenfc7gyFztXFO0BNXZvdC4RnTwaHzAosZRvMIolluP U/Dw== X-Gm-Message-State: AOAM533ajnHsBw9VDF3ZIe0AQRtLp+IytXJ3Wl6UOxaKa8svAdjdbmnI bkXB5jQEuhZJZoTDBrDHIwa3/NWLQSgYVjSSq/Y= X-Google-Smtp-Source: ABdhPJx1MiTlACfWcPXsF7tOVEtjnYNp8oRg3FCns+ZXbDpVD8Atx2pAvuXrhC82yyeJ2AWwQo6GPDdaLFqLRxQVhc4= X-Received: by 2002:a05:6808:1913:b0:32b:7840:e93c with SMTP id bf19-20020a056808191300b0032b7840e93cmr1760551oib.210.1653584662144; Thu, 26 May 2022 10:04:22 -0700 (PDT) MIME-Version: 1.0 References: <0934250f-8808-0176-94f7-a6c7d37288b5@yahoo.co.jp> In-Reply-To: <0934250f-8808-0176-94f7-a6c7d37288b5@yahoo.co.jp> From: Max Filippov Date: Thu, 26 May 2022 10:04:11 -0700 Message-ID: Subject: Re: [PATCH 5/5] xtensa: Improve bswap[sd]i2 insn patterns To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 17:04:24 -0000 On Fri, May 13, 2022 at 6:35 AM Takayuki 'January June' Suwa wrote: > > This patch makes bswap[sd]i2 better register allocation, and reconstructs > bswapsi2 in order to take advantage of GIMPLE manual byte-swapping > recognition. > > gcc/ChangeLog: > > * gcc/config/xtensa/xtensa.md (bswapsi2): New expansion pattern. > (bswapsi2_internal): Revise the template and condition, and add > detection code for preceding the same insn in order to omit a > "SSAI 8" instruction of the latter. > (bswapdi2): Suppress built-in insn expansion with the corresponding > library call when optimizing for size. > > gcc/testsuite/ChangeLog: > > * gcc.target/xtensa/bswap-O1.c: New. > * gcc.target/xtensa/bswap-O2.c, gcc.target/xtensa/bswap-Os.c: > Ditto. > --- > gcc/config/xtensa/xtensa.md | 77 +++++++++++++++++----- > gcc/testsuite/gcc.target/xtensa/bswap-O1.c | 37 +++++++++++ > gcc/testsuite/gcc.target/xtensa/bswap-O2.c | 37 +++++++++++ > gcc/testsuite/gcc.target/xtensa/bswap-Os.c | 37 +++++++++++ > 4 files changed, 172 insertions(+), 16 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/xtensa/bswap-O1.c > create mode 100644 gcc/testsuite/gcc.target/xtensa/bswap-O2.c > create mode 100644 gcc/testsuite/gcc.target/xtensa/bswap-Os.c This patch breaks the test gcc.target/xtensa/bswap.c, but since it introduces three other tests that cover the same area I've dropped that test. I've regtested it for target=xtensa-linux-uclibc, there's no new regressions, but I have a question: what guarantees that no instruction that changes the SAR register can be moved between two adjacent bswapsi2_internal instructions? -- Thanks. -- Max