From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by sourceware.org (Postfix) with ESMTPS id 084D13858D3C for ; Tue, 8 Nov 2022 10:06:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 084D13858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb2d.google.com with SMTP id k13so12961709ybk.2 for ; Tue, 08 Nov 2022 02:06:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EY6hlTE4i4VeG1vo97nqQLUCxtYO3c5gawee0n0CN6Y=; b=SOKK4oFMOkrKFl2pzrVZKAC+WahDOTbkThnPbhoGvFsECdE6fJFHllVCXaJPtBvEaW edtrYSY1QLUy69i+P6iUPgKFe5PUInEcfaTdTOkEb9lwPSQXrWhcz26Yfj8l4JqTcq5X E20AHx01/YWlRN/z3K+lxaMpzNqPfO7SvOinl9JxMxNcJcJsNz9+NBh2ai+uKKtajPe5 LUNSCyTjdX8r6/LpM5FbQZRHfLTciuV2R5sS3QLFb+K8g8mLZaktxTN0oMtlcEXFyCon 21ekaxfNxIk33aFods6gRBKPrmtY2lFXCq+q+HZ79I8u06H5G5zGFyMkdjQ8H0Ia1c68 bz0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EY6hlTE4i4VeG1vo97nqQLUCxtYO3c5gawee0n0CN6Y=; b=Oy8yJHxI16xE4bzOEr0QRhhVigFrM3qBDesl7WsP+ZGIpaEhjsIgl546JfB2+tpiCi n44P9ZefecXPaiqX6ThIaz15T7tKoJD6k/dQYy1KnJmv7kQ0tYqRHM/esAluDSQjnYhR IQ8lt1EorGDgUWGMAWfEl3/FoIt//6VKrTQaLtmCoE4tJELPhiUYOGCEymtE2+jNNIlP xjWgGCMVuGfhsa5/ZD4xSfVbgYPi/Vhxc4YNyXTTT7+J1v6bkpeU/vBVia26Y9Cp9WIG 4Iwrd0W9jucjRoE/wJ2AQ1KfITGIsIFDuI7jcAgaa23NoDSsBWai3pPX1uyQ3zj7JcMH CVLQ== X-Gm-Message-State: ACrzQf2IOWnx+Qr9xIVM12ASFDPvJ7c7r4A773J1bjDpCY9DgtaXzwXv FzeEvfJqvOC2CfTFpqaIGFNHRNALShurWkyo8Ag= X-Google-Smtp-Source: AMsMyM5iKkbEM9+GlFmAr+6qdsHMmt1uXHznUo8c7Uy4uI/3t2c0T1O9EpQpDR+eWqXWCwouLWf6/6RH54MQZtyDHtI= X-Received: by 2002:a25:580b:0:b0:6cb:cff0:7018 with SMTP id m11-20020a25580b000000b006cbcff07018mr54056727ybb.497.1667901962419; Tue, 08 Nov 2022 02:06:02 -0800 (PST) MIME-Version: 1.0 References: <20221107094645.3718427-1-jcmvbkbc@gmail.com> In-Reply-To: From: Max Filippov Date: Tue, 8 Nov 2022 02:05:50 -0800 Message-ID: Subject: Re: [RFA] gcc: fix PR rtl-optimization/107482 To: Vladimir Makarov Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,GIT_PATCH_0,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Nov 7, 2022 at 12:52 PM Vladimir Makarov wrote: > even better patch: > > diff --git a/gcc/ira-color.cc b/gcc/ira-color.cc > index 4a1a325e8e3..ffe73b61c45 100644 > --- a/gcc/ira-color.cc > +++ b/gcc/ira-color.cc > @@ -2209,8 +2209,8 @@ assign_hard_reg (ira_allocno_t a, bool retry_p) > restore_costs_from_copies (a); > ALLOCNO_HARD_REGNO (a) = best_hard_regno; > ALLOCNO_ASSIGNED_P (a) = true; > - if (best_hard_regno >= 0) > - update_costs_from_copies (a, true, ! retry_p); > + if (best_hard_regno >= 0 && !retry_p) > + update_costs_from_copies (a, true, true); > ira_assert (ALLOCNO_CLASS (a) == aclass); > /* We don't need updated costs anymore. */ > ira_free_allocno_updated_costs (a); > ... > Please, check that my proposed patch works and commit it in the case of > success. Thank you for taking a look and suggesting a better fix. I've tested your version for target=xtensa-linux-uclibc, it fixes the issue without new regressions. I've committed the fix to the master branch and will backport it to gcc-10, -11 and -12 in a few days. -- Thanks. -- Max