From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 79921385624A for ; Thu, 16 Jun 2022 00:02:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79921385624A Received: by mail-oi1-x230.google.com with SMTP id p129so44700oig.3 for ; Wed, 15 Jun 2022 17:02:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ICQBaDNmhe3+Fv30RB0kYSgmG0X/BkEunTewnTuOXvs=; b=zFI6VAMvZN4AtzB2Tmv59XDJftV+c1T657TAQi3vAqcLJ2A52flaLOXEUaD1NIEHqm P/Uwk8K4wKqNT615BHvxHmtzbHRorfkuBcIZkOS1HGZZ9T4LsofCPuG8WJzKqEjzcPwU xHOhpzYGuSRI+iZfS2knlwBKP5pE9edwojyAzkAdZHKvDaS1NTubSA7XFHVsV+RflC/6 sdSofXatxo36TEuFJM1sqne5mylldT9IvpBN0R+JzPutO8zgspLT3Isg7+ZIYFC+P0hd E8E9F5keuUPMmtJSKtPyZCmK4OLS93xJ6zlyw0st0kI7vxAlnVjFXowq7D5a64f+D9+V c/dw== X-Gm-Message-State: AOAM5314ra/gcBPv8MSojetZGOkIo1b5VTbZ5MIVpejUFAcOb9asjIGo o3sNi2T5fy4C3LCR8W82TqDw2DoMvjRIzmXWQdU= X-Google-Smtp-Source: ABdhPJymx3cxy5KHvA5VRHc991UKMr26qRCtAlzvt5613xpQ5pLqkba/QT2P9ppiuAhXgr7s1iqAIedFaXaZPoFVLhE= X-Received: by 2002:aca:3203:0:b0:32e:b45e:131b with SMTP id y3-20020aca3203000000b0032eb45e131bmr6435113oiy.210.1655337739860; Wed, 15 Jun 2022 17:02:19 -0700 (PDT) MIME-Version: 1.0 References: <0ebde82d-4449-c731-1656-0e1b29d5ed9c@yahoo.co.jp> In-Reply-To: <0ebde82d-4449-c731-1656-0e1b29d5ed9c@yahoo.co.jp> From: Max Filippov Date: Wed, 15 Jun 2022 17:02:10 -0700 Message-ID: Subject: Re: [PATCH 4/5] xtensa: Eliminate unwanted reg-reg moves during DFmode input reloads To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2022 00:02:21 -0000 On Mon, Jun 13, 2022 at 8:54 PM Takayuki 'January June' Suwa wrote: > > When spilled DFmode registers are reloaded in, once loaded into a pair of > SImode regs and then copied from that regs. Such unwanted reg-reg moves > seems not to be eliminated at the "cprop_hardreg" stage, despite no problem > in output reloads. > > Luckily it is easy to resolve such inefficiencies, with the use of peephole2 > pattern. > > gcc/ChangeLog: > > * config/xtensa/predicates.md (reload_operand): > New predicate. > * config/xtensa/xtensa.md: New peephole2 pattern. > --- > gcc/config/xtensa/predicates.md | 13 +++++++++++++ > gcc/config/xtensa/xtensa.md | 31 +++++++++++++++++++++++++++++++ > 2 files changed, 44 insertions(+) Regtested for target=xtensa-linux-uclibc, no new regressions. Committed to master. -- Thanks. -- Max