From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 183B9386DC51 for ; Tue, 14 Jun 2022 00:32:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 183B9386DC51 Received: by mail-ot1-x330.google.com with SMTP id h15-20020a9d600f000000b0060c02d737ecso5525186otj.1 for ; Mon, 13 Jun 2022 17:32:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=076rJtv06T0LToMY4v9E+M4oNMjVgTQ3NDGCJUc2MZU=; b=wOcqiBPeR+LjjDrq1tb6NWHyCjG8LNuZ0X+tizQEyT3I9Kqtnrn3i+m7/47HjljKJG DEgdRFiFtZTqlQ/t48YtcrNeJHFBBzDt3E8F74K0TE6NctfnV6wLs7GjaXZNbNw1xxMs ZCfTZtuJFkjywVsX16xivv+XKDiaTxtjPWi7y0kbgU6mXmXFSK+HoJ5LWJdZgJzj89yi 4xpbhBgUPYltUq4hdQnmiKHGo9dy9IcXdxMWxtYbt/u6VtiKBjefU6G2WmFoBaJP/9/I pH7gg/ghd89SyZgXLdTbzQhm4mq195YaiNhJ5uQMBfCl9h3wQ5SOrnnT3t8R1Q5kYS// 10zA== X-Gm-Message-State: AOAM533+e0wXikJ7N+PnqIeIQ0QfPUJUuyctz/lZDSj6MG1U9Flvuff4 XHnEuhiJVHCUiUYSEwKoEfyv4+Yad6jSeWgpWWo= X-Google-Smtp-Source: ABdhPJwGBDZv1utDOhi7kHx9q1TaTyVDXNZhMVDGVpsCSqJHUVgxMF33TFZ1cjUkldfEpWt3yBNP/KElAaphh1v847I= X-Received: by 2002:a9d:6456:0:b0:60b:1c99:bd6a with SMTP id m22-20020a9d6456000000b0060b1c99bd6amr1061048otl.384.1655166746216; Mon, 13 Jun 2022 17:32:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Max Filippov Date: Mon, 13 Jun 2022 17:32:15 -0700 Message-ID: Subject: Re: [PATCH 2/4] xtensa: Simplify conditional branch/move insn patterns To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2022 00:32:28 -0000 On Sat, Jun 11, 2022 at 11:43 PM Takayuki 'January June' Suwa wrote: > > No need to describe the "false side" conditional insn patterns anymore. > > gcc/ChangeLog: > > * config/xtensa/xtensa-protos.h (xtensa_emit_branch): > Remove the first argument. > (xtensa_emit_bit_branch): Remove it because now called only from the > output statement of *bittrue insn pattern. > * config/xtensa/xtensa.cc (gen_int_relational): Remove the last > argument 'p_invert', and make so that the condition is reversed by > itself as needed. > (xtensa_expand_conditional_branch): Share the common path, and remove > condition inversion code. > (xtensa_emit_branch, xtensa_emit_movcc): Simplify by removing the > "false side" pattern. > (xtensa_emit_bit_branch): Remove it because of the abovementioned > reason, and move the function body to *bittrue insn pattern. > * config/xtensa/xtensa.md (*bittrue): Transplant the output > statement from removed xtensa_emit_bit_branch(). > (*bfalse, *ubfalse, *bitfalse, *maskfalse): Remove the "false side" > insn patterns. > --- > gcc/config/xtensa/xtensa-protos.h | 3 +- > gcc/config/xtensa/xtensa.cc | 111 ++++++++++------------------ > gcc/config/xtensa/xtensa.md | 117 ++++++++---------------------- > 3 files changed, 70 insertions(+), 161 deletions(-) Regtested for target=xtensa-linux-uclibc, no new regressions. Committed to master. -- Thanks. -- Max