From: Max Filippov <jcmvbkbc@gmail.com>
To: "Takayuki 'January June' Suwa" <jjsuwa_sys3175@yahoo.co.jp>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH v2] xtensa: Prepare the transition from Reload to LRA
Date: Mon, 17 Oct 2022 20:14:29 -0700 [thread overview]
Message-ID: <CAMo8BfJOUHfuQHrk4jVsVVZCPZi5TC7_G+BHbevWvPspqJ159Q@mail.gmail.com> (raw)
In-Reply-To: <b1609279-d845-30a1-1ec6-ed0ca6c60a68@yahoo.co.jp>
On Mon, Oct 17, 2022 at 7:57 PM Takayuki 'January June' Suwa
<jjsuwa_sys3175@yahoo.co.jp> wrote:
> On 2022/10/16 14:03, Max Filippov wrote:
> > There's also the following runtime failures, but only on call0 configuration:
> >
> > +FAIL: gcc.c-torture/execute/20010122-1.c -O1 execution test
> > +FAIL: gcc.c-torture/execute/20010122-1.c -O2 execution test
> > +FAIL: gcc.c-torture/execute/20010122-1.c -O3 -g execution test
> > +FAIL: gcc.c-torture/execute/20010122-1.c -Os execution test
> > +FAIL: gcc.c-torture/execute/20010122-1.c -O2 -flto -fno-use-linker-plugin -flto-partition=none execution test
>
> both assembler outputs with and without this patch are identical on my side
Interesting. In -O1 test I see the following difference that is going to affect
the return value of the corresponding functions:
--- gcc-13-3308-gb4a4c6382b14-call0-le/20010122-1.s 2022-10-17
20:07:32.390363204 -0700
+++ gcc-13-3309-g851636ecd015-call0-le/20010122-1.s 2022-10-17
20:06:36.613785546 -0700
@@ -143,13 +143,10 @@
test2:
addi sp, sp, -16
s32i.n a0, sp, 12
- s32i.n a12, sp, 8
- mov.n a12, a0
l32r a2, .LC6
callx0 a2
- mov.n a2, a12
+ mov.n a2, a0
l32i.n a0, sp, 12
- l32i.n a12, sp, 8
addi sp, sp, 16
ret.n
.size test2, .-test2
@@ -161,13 +158,10 @@
test3:
addi sp, sp, -16
s32i.n a0, sp, 12
- s32i.n a12, sp, 8
- mov.n a12, a0
l32r a2, .LC7
callx0 a2
- mov.n a2, a12
+ mov.n a2, a0
l32i.n a0, sp, 12
- l32i.n a12, sp, 8
addi sp, sp, 16
ret.n
.size test3, .-test3
@@ -258,14 +252,11 @@
test8:
addi sp, sp, -16
s32i.n a0, sp, 12
- s32i.n a12, sp, 8
- mov.n a12, a0
l32r a2, .LC12
callx0 a2
l32r a2, .LC13
- s32i.n a12, a2, 0
+ s32i.n a0, a2, 0
l32i.n a0, sp, 12
- l32i.n a12, sp, 8
addi sp, sp, 16
ret.n
.size test8, .-test8
--
Thanks.
-- Max
next prev parent reply other threads:[~2022-10-18 3:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 1:35 [PATCH] lower-subreg, expr: Mitigate inefficiencies derived from "(clobber (reg X))" followed by "(set (subreg (reg X)) (...))" Takayuki 'January June' Suwa
2022-08-03 7:52 ` Richard Sandiford
2022-08-03 11:17 ` Takayuki 'January June' Suwa
2022-08-04 9:49 ` Richard Sandiford
2022-08-04 12:35 ` Takayuki 'January June' Suwa
2022-08-05 16:20 ` Jeff Law
2022-10-14 11:06 ` [PATCH] xtensa: Prepare the transition from Reload to LRA Takayuki 'January June' Suwa
2022-10-16 5:03 ` Max Filippov
2022-10-18 2:57 ` [PATCH v2] " Takayuki 'January June' Suwa
2022-10-18 3:14 ` Max Filippov [this message]
2022-10-18 12:16 ` Max Filippov
2022-10-19 8:16 ` [PATCH v3] " Takayuki 'January June' Suwa
2022-10-19 11:31 ` Max Filippov
2022-10-25 20:09 ` Jan-Benedict Glaw
2022-10-26 3:23 ` Takayuki 'January June' Suwa
2022-10-26 6:27 ` [PATCH] xtensa: Fix out-of-bounds array access Takayuki 'January June' Suwa
2022-10-26 17:05 ` Max Filippov
2022-08-05 16:12 ` [PATCH] lower-subreg, expr: Mitigate inefficiencies derived from "(clobber (reg X))" followed by "(set (subreg (reg X)) (...))" Jeff Law
2022-08-03 17:23 ` Jeff Law
2022-08-04 9:39 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfJOUHfuQHrk4jVsVVZCPZi5TC7_G+BHbevWvPspqJ159Q@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jjsuwa_sys3175@yahoo.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).