From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 204A9384D16F for ; Sat, 11 Jun 2022 09:05:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 204A9384D16F Received: by mail-ot1-x334.google.com with SMTP id l9-20020a056830268900b006054381dd35so930089otu.4 for ; Sat, 11 Jun 2022 02:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1RhEJG9uviOm3nG0Dt1LsrkY19g08f/bmEIFgmKXFfw=; b=Z8N4Mbl1MPKgE3N/0rJX5xyqeR0cxgvyDNVjhkwlO1e9XFE2OGxb3+ivoOZrNUGzcT t0uQad48sJv9iriyPsAHKNi7bBNUdSoCAFFDAPTKHTaBgLRhaEoFDaEVoV6Aha7vh8zb dxHDKQhrVENQ80DPi/4HqaepHIZ7vi/ZpV/dwT54yHsH+r5AN/COotOVgWhGRSqHksby oNOlkk6Y45eJrrctpqm2iZlJbffoKyUiT24j9wsbTF2OCWdkU3TU61CLfY+jReYGyVZ6 Unvuy8FA4XLBe0MdNS1xfhUA7lm6GNBh8idR+pnmSC+ffW8RiIkm1O8Jr0SLusRrCU9A fX8g== X-Gm-Message-State: AOAM532NZYEZSc6B2w4ORJIzJ2cwdSuv5bTea3eKRvMx0X6PePT8zfs3 NUKvj9i499EQQVcUFc/batVKDZNAECjSobYwXbI= X-Google-Smtp-Source: ABdhPJyzt4C4NrdiZqVmFBhuTdUrlO5hW5Vdampi9/vyhlS7ig61Kja1s7Shp76tvtudqBCtI/xW1ghA+IvmGiCev7E= X-Received: by 2002:a9d:5c01:0:b0:60b:f1fc:3a04 with SMTP id o1-20020a9d5c01000000b0060bf1fc3a04mr14943756otk.204.1654938347534; Sat, 11 Jun 2022 02:05:47 -0700 (PDT) MIME-Version: 1.0 References: <200341ff-4907-c6da-07cb-86b9b4588f84@yahoo.co.jp> <0b7a3a36-cbdf-e812-4c04-533b15c9963b@yahoo.co.jp> In-Reply-To: <0b7a3a36-cbdf-e812-4c04-533b15c9963b@yahoo.co.jp> From: Max Filippov Date: Sat, 11 Jun 2022 02:05:36 -0700 Message-ID: Subject: Re: [PATCH v2 4/4] xtensa: Improve constant synthesis for both integer and floating-point To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2022 09:05:49 -0000 On Sat, Jun 11, 2022 at 1:31 AM Takayuki 'January June' Suwa wrote: > > this change results in a bunch of ICEs in the tests like this: > > during RTL pass: split2 > > gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c: In function 'f': > > gcc/gcc/testsuite/gcc.c-torture/compile/20120727-1.c:13:1: internal > > compiler error: in gen_split_5, at config/xtensa/xtensa.md:1186 > [from config/xtensa/xtensa.md] > if (GET_MODE (x) == SFmode) > REAL_VALUE_TO_TARGET_SINGLE (*CONST_DOUBLE_REAL_VALUE (x), l[0]); > else if (GET_MODE (x) == DFmode) > REAL_VALUE_TO_TARGET_DOUBLE (*CONST_DOUBLE_REAL_VALUE (x), l); > else > gcc_unreachable (); // line 1186 > x = gen_rtx_REG (SImode, REGNO (operands[0])); > > umm, i don't know how 'XEXP (operands[1], 0)' can be neither SFmode nor > DFmode... > please tell me that test piece of code, and/or apply the below patch and > reply what the compiler print to stderr: > > --- gcc/config/xtensa/xtensa.md > +++ gcc/config/xtensa/xtensa.md > @@ -1183,7 +1183,10 @@ > else if (GET_MODE (x) == DFmode) > REAL_VALUE_TO_TARGET_DOUBLE (*CONST_DOUBLE_REAL_VALUE (x), l); > else > - gcc_unreachable (); > + { > + print_rtl_single (stderr, x); > + gcc_unreachable (); > + } > x = gen_rtx_REG (SImode, REGNO (operands[0])); > if (! xtensa_constantsynth (x, l[i])) > emit_move_insn (x, GEN_INT (l[i])); > It prints (symbol_ref/f:SI ("*.LC1") [flags 0x2] ) -- Thanks. -- Max