From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by sourceware.org (Postfix) with ESMTPS id 1DDEF3858C2C for ; Sun, 13 Nov 2022 03:47:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DDEF3858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-yb1-xb36.google.com with SMTP id r3so9935889yba.5 for ; Sat, 12 Nov 2022 19:47:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x4NMsKaMH3uvvykMcpAhTnRbmRSGsnh61pC67IBZIBE=; b=W2/u8dBX0UwtOvKHLt32VI8CXqRuj5aD4kyqqRsVL2PVRGpkEjilduzHU1V8kZeuA9 Dr0hBT/AnSnUTTpyF3bSEwl/Z+D2EPEyR3KtM7nHYSjxHQpHwKN7XmE0RLRHPL7m12QR pdFUCkPhk4THd0yTlYccoFCVCqxAsEFGrZJ+y18DxVeIy9q89w0Q//JurOdoMZbTEZc3 GPXNuOwHUKm4D+GV9XE96flaKDLrHo6yPEUwA/kz9qyILpGAlzt/n6OyWg2F+X9IHSZi CV9vGRWOkNcxz1w7qCySN/R6IirNEx8nSjGrAg3jlQ4eOti6mlVEQWDAsqUwdInvInOp Tt4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x4NMsKaMH3uvvykMcpAhTnRbmRSGsnh61pC67IBZIBE=; b=Dy09kIw7/zN0r+1V+L7vYRRQytj+pPvMkmiFSeMAfHNvbgORzrK78yKNcYPLiIHyka Qi8Esc+DtEpTThYywvRn9+eyhMxyxh+pcHd0e/rZFr4colrN5j3vG2xxXtiS9t1XCfHD C15XTFd7WQsof43iU6vjaDy3M/cj/lXjthBr6r/oqZX7rSNW/hNhZXrehmrlBCIN5o0Y Js2MGlkjhzClA3IZRmA1sMT/53QDTF4yzSgQHl2v1WIbrIrc/1DCpcaOAreRJJAXUybE Aq5+xmq6at29nMMNugyL+2lDFVnv5Bo2/9tcARsmP80xlhMBmI/nSRfO4mYt2KnG0wXj BW0w== X-Gm-Message-State: ANoB5pnatmtt5Rtu5gKxUDddaBBD18EDdjpQU7j7pvXUXcmVc0YcuolO E09ojP+/nN4B0bAx9BpTxyvecu5EV6HQ7Hzu+0s= X-Google-Smtp-Source: AA0mqf6mDiF7hIFDf6bXAxJtCELOduq8DLsfcy6xiWewg9N3gkcq++Gu0v4ZulevxazXzMEGfloLuJjGl6CY5WFGSdw= X-Received: by 2002:a25:aa46:0:b0:6de:5b33:4a29 with SMTP id s64-20020a25aa46000000b006de5b334a29mr7671522ybi.485.1668311260478; Sat, 12 Nov 2022 19:47:40 -0800 (PST) MIME-Version: 1.0 References: <20221111194356.3922768-1-jcmvbkbc@gmail.com> <80a301f3-6b42-cbad-77b9-cc219eed54ce@gmail.com> In-Reply-To: <80a301f3-6b42-cbad-77b9-cc219eed54ce@gmail.com> From: Max Filippov Date: Sat, 12 Nov 2022 19:47:28 -0800 Message-ID: Subject: Re: [PATCH] gcc: m68k: fix PR target/107645 To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Andreas Schwab Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Nov 12, 2022 at 11:42 AM Jeff Law wrote: > ISTM that we'd need to strip the unspec and process its argument > instead. I tried that first, the result was more ICEs because that pattern wasn't recognized at later stages. Then I read the change to the comment over the symbolic_operand predicate: https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=gcc/config/m68k/predicates.md;h=6ca261fb92a2b7ecd53a0356d06410e2c0d70965;hp=417989f6d6c408fa82af9f9649a204b9a754d1dc;hb=75df395f15f2;hpb=676fd528c9990a4f1046b51d40059893c3a71490 and that made me think that the intention was to not recognize the unspecs in that predicate. -- Thanks. -- Max