From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 98D20385C6D4 for ; Thu, 20 Jul 2023 17:55:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98D20385C6D4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-262ef07be72so524878a91.1 for ; Thu, 20 Jul 2023 10:55:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689875728; x=1690480528; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ue89hvEK0Mst6CCw5xdETRzYsWLrU8xtn5VoSOeDvKw=; b=GzKjKNOLHmAMwVsw5zp2WcsCqWxDJ82VtLQdzWKi/NIdMW8SPDNUP4siAX0PiH3Ch9 enEu2bR8uXZUQRQj2QjchFg3N1V9S+fWQYT+pTXwoFahkZ9kXIB/f3Pmjo7D0wSeKJyC +9Y0FfW4jUNCRwwitkVPgAq+MaOHQ1e87FOnowS9c1gw6ueUZrNmoABNYOQBVw8R3e4D 5L92G0cbfmjXkPJqdCvuLTMEJlmQ4FHTYDGNfZczFsiMo6ENeclDfFvdJRbJYos9ZbXG EWBDghxMqibNzVEHgS00juzBynz5w6WnaE8x+vJu9NGIcFuIZVferRN3drTrljCWiEod QtBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689875728; x=1690480528; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ue89hvEK0Mst6CCw5xdETRzYsWLrU8xtn5VoSOeDvKw=; b=EDHBbbAjG2UjZr10amVgAM2ZYaNFJJk+ph/GOxp4GOCRIeuKr670+6VZJ7sGt2E1ib QhGhJ7KVy6gW/09bE4K/3CjDPz7+hSGE/f5Mjev/NkgCGswepTE9H2xGrHUomh/vo9Av t3qwQ3PRn1EI14alGf0Zz+0WJCNeY5rgbeSN+Gkm45SdkaP2UWHhawk6XbsmQnqfWZne d0cXeL84dUYscpmZTyRAQsxyIeBlsacpvngqQNEedmkSZZo8B65AQwfar6f4wYwMNMcV GquTktrl9cAcl81GJk54oK112VaBYyzKDc2IN62R1yHFl/o4cPeKxdHYJNo/XKVgnwjX pP4A== X-Gm-Message-State: ABy/qLY24UnvZsnmgPP6UUfPt7I8SrByTIW9HzhAnb1n78OKBiTGjci2 3NrYGsWIIHd2vIWkQG5E/IMDSN/ycfJ4wRAyAgCNQYgIEoY= X-Google-Smtp-Source: APBJJlEvLKIar6TeRsQTtN4rPS30uCVVh1Xr/cKVZgJE9WkZuiJspv5/lo8cCM8bl5Z+9ApWI2rD70+coXDFJm8JGhI= X-Received: by 2002:a17:90a:a50c:b0:262:b22b:8ab5 with SMTP id a12-20020a17090aa50c00b00262b22b8ab5mr37101pjq.17.1689875728646; Thu, 20 Jul 2023 10:55:28 -0700 (PDT) MIME-Version: 1.0 References: <485a6a6c62a8632d9e3ac44b2d8fd935c0e0a78b.camel@espressif.com> <764ac77b1311325242c0c2ab709fa31f5bf62f8f.camel@espressif.com> <029d8b9742bb413668a4d16209b0dd924277f3e1.camel@espressif.com> In-Reply-To: <029d8b9742bb413668a4d16209b0dd924277f3e1.camel@espressif.com> From: Max Filippov Date: Thu, 20 Jul 2023 10:55:17 -0700 Message-ID: Subject: Re: [PATCH 2/3] gcc: xtensa: use dynconfig settings as builtin-macros To: Alexey Lapshin Cc: "gcc-patches@gcc.gnu.org" , Alexey Gerenkov , Ivan Grokhotkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jul 20, 2023 at 10:45=E2=80=AFAM Alexey Lapshin wrote: > > On Thu, 2023-07-20 at 08:25 -0700, Max Filippov wrote: > > But it defines them with their respective values. > > Just notice that it adds two leading underscores in front of the names. > > Why builtin macros were defined with prefix? > With this approach I also need define it somewhere: > > #define XTHAL_ABI_WINDOWED __XTHAL_ABI_WINDOWED > #define XTHAL_ABI_CALL0 __XTHAL_ABI_CALL0 > ..... > > Or add prefix to macros in existing code that also looks not good.. > > I want to get idea why toolchain can't have builtin macros with the same = names? Because 1) it will break existing code and 2) it's just not nice to pollute the namespace. --=20 Thanks. -- Max