From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id DAF44383F940 for ; Sun, 12 Jun 2022 07:52:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DAF44383F940 Received: by mail-oi1-x230.google.com with SMTP id bl34so4432607oib.1 for ; Sun, 12 Jun 2022 00:52:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RX5XoHyfU56PwLOoQAzf1Z4JP6EsQn3BAE70Xcg1n1Q=; b=m6xMuN5t6ysO2PdeXHKOHd3A7mBkIYKXBfLZGpdJkYyWF9E2Zorhvv6IuDuy1tg9SR L86xG1ylqLccrOEFdbWPPBweKVM+/Qu4fB6BikMtz7MD13sMk3WgoKdSuMmslYOtGx3o hUMHyrwdQ2Xsa4/jEtvDhZwcEb8zsXsmgAsMm1a6SK+CX+Ie2o0uum69PGFZylXlj2+k NIL3phC8BDmg5qPKzm3Gy6Qj/nbRNmrLrjQBPoSVV7ltuYum0/WrndglNLc6Qs2xu6MZ yMPbCfrXQP4p4C1okvY6IAHrOpPoE9IpL9OVHKOvjONPRnZZLeBzkU8Ml9R+TZUHgZfE V2Ew== X-Gm-Message-State: AOAM5327VChgeiw37h5/d3BJMTPcy8iniXR4EksE98yGSJ7khNbkAUbw VI6NUTTJpaCRFN4LybeX+T/xg3BttvH7tVdt3Sk= X-Google-Smtp-Source: ABdhPJx6GVxaILSEsozGB71HRSgVis+ah0TmGJtdN87NEyQeqqtU+jCkw4EkxExJof8xQe4iSOpWqQpS9KzXV8JBFRE= X-Received: by 2002:a05:6808:1202:b0:2f9:c7b4:fd56 with SMTP id a2-20020a056808120200b002f9c7b4fd56mr3850151oil.55.1655020322148; Sun, 12 Jun 2022 00:52:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Max Filippov Date: Sun, 12 Jun 2022 00:51:50 -0700 Message-ID: Subject: Re: [PATCH 2/4] xtensa: Simplify conditional branch/move insn patterns To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2022 07:52:04 -0000 On Sat, Jun 11, 2022 at 11:43 PM Takayuki 'January June' Suwa wrote: > > No need to describe the "false side" conditional insn patterns anymore. > > gcc/ChangeLog: > > * config/xtensa/xtensa-protos.h (xtensa_emit_branch): > Remove the first argument. > (xtensa_emit_bit_branch): Remove it because now called only from the > output statement of *bittrue insn pattern. > * config/xtensa/xtensa.cc (gen_int_relational): Remove the last > argument 'p_invert', and make so that the condition is reversed by > itself as needed. > (xtensa_expand_conditional_branch): Share the common path, and remove > condition inversion code. > (xtensa_emit_branch, xtensa_emit_movcc): Simplify by removing the > "false side" pattern. > (xtensa_emit_bit_branch): Remove it because of the abovementioned > reason, and move the function body to *bittrue insn pattern. > * config/xtensa/xtensa.md (*bittrue): Transplant the output > statement from removed xtensa_emit_bit_branch(). > (*bfalse, *ubfalse, *bitfalse, *maskfalse): Remove the "false side" > insn patterns. > --- > gcc/config/xtensa/xtensa-protos.h | 3 +- > gcc/config/xtensa/xtensa.cc | 111 ++++++++++------------------ > gcc/config/xtensa/xtensa.md | 117 ++++++++---------------------- > 3 files changed, 70 insertions(+), 161 deletions(-) This patch is whitespace-damaged. Please resend. -- Thanks. -- Max