From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id B7F073858D1E for ; Mon, 13 Mar 2023 23:09:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7F073858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id i5so14703248pla.2 for ; Mon, 13 Mar 2023 16:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678748953; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F4wsjITdNX/Lgrb6h3IXHrSzVNrcpqScQAeipjbI3hc=; b=W5iQHiiy10qUVQdxmwbWLvBCPTtni9h1nZtbYwmztKSipLbpBHfC2qUON/9FJ9aMWm 0aeJTLDbCTsl1cN7gTc77yQ86MpCCVLJHGm/gTLKfxcKaqjszfUzzo88Kb1qiMorI1yg Dlu3yNaPRRuelDBOiOHrO+4YvxNhH+PJY3de5w5tyPOdThyU5Lt+H04PT9zwfnoEwLt4 3jyQUuvAZbEiLzoyl+HZ+SDI+2cg4U7H/8h1IXTLgAy+jdBuDsCHE8UYFgZpvs/Pc/cz NYVB3k+LJ4vtyjUa0wK5ASIh4+B4cfmoAsjVLcphjbmtt84BJDScaOE2niZK8IfwTU21 Jalg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678748953; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F4wsjITdNX/Lgrb6h3IXHrSzVNrcpqScQAeipjbI3hc=; b=mNtRwRZ1zmJxFOTPr85yCX+PGHz0MdRTebWRvXlkLIYk4P8hAJAt2rS3G5zUGgtiJQ 3y5oNoCkOHv/sLRCypd5Catz7Ehk6m1z89tbXDPsvOjY96C1t7dPKs+TqpJPXdfWg2qY VuSyzQlQ8KP0Ut5tn77IF/Kz7kuZdKrsPtR+EX7LQn6FLQtQjYbkYn+WgU1D3BicoxbK 680CwbjG+MaqLtVE1Yhupga9suwo6zTQ8Yjd1im/+qworBgV1jZNmkHdHwlTQy4Y5NNx K9jikfRibsx/ZwXmlEbxBHFlj7RZT74IxL4UyykZ5PWgeIMNgd/bPEWzrllLdGW1iipT qDBg== X-Gm-Message-State: AO0yUKWbMLJGSaUIqAdQi4CiKM1J8pLoR2w7dgIufyK9WbkQU/cie7OK RML+0G3XYeA60e/Uhb31u65XR7MV15mwRmn0GOA= X-Google-Smtp-Source: AK7set+MC+N7CPoSs4WLAP39JNXgF037egkW4IwjEu0yVA0tOOiVHeDsv5kTrQ0P5EhSU8LFBdrSgxf1+egiD9RCLIY= X-Received: by 2002:a17:90a:6804:b0:237:9cbe:22ad with SMTP id p4-20020a17090a680400b002379cbe22admr12931709pjj.5.1678748953553; Mon, 13 Mar 2023 16:09:13 -0700 (PDT) MIME-Version: 1.0 References: <8a826036-e109-9ffb-7048-b5bbaab22590.ref@yahoo.co.jp> <8a826036-e109-9ffb-7048-b5bbaab22590@yahoo.co.jp> In-Reply-To: <8a826036-e109-9ffb-7048-b5bbaab22590@yahoo.co.jp> From: Max Filippov Date: Mon, 13 Mar 2023 16:09:02 -0700 Message-ID: Subject: Re: [PATCH] xtensa: Fix for enabling LRA To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Suwa-san, On Tue, Mar 7, 2023 at 10:04=E2=80=AFPM Takayuki 'January June' Suwa wrote: > > This patch makes LRA well with some exceptions > (e.g. MI thunk generation due to pretending reload_completed). > > gcc/ChangeLog: > > * config/xtensa/constraints.md (R, T, U): > Change define_constraint to define_memory_constraint. > * config/xtensa/xtensa.cc (xtensa_legitimate_constant_p): > Add short-circuit path for integer load instructions when > lra_in_progress. > * config/xtensa/xtensa.md (movsf): > Use can_create_pseudo_p() rather reload_in_progress and > reload_completed. > --- > gcc/config/xtensa/constraints.md | 26 ++++++++------------------ > gcc/config/xtensa/xtensa.cc | 4 ++++ > gcc/config/xtensa/xtensa.md | 2 +- > 3 files changed, 13 insertions(+), 19 deletions(-) this change introduces the following build- and runtime regressions when tested without -mlra: +FAIL: gcc.c-torture/execute/builtins/sprintf.c execution, -O1 +FAIL: gcc.c-torture/execute/builtins/sprintf.c execution, -Og -g +FAIL: gcc.c-torture/execute/builtins/vsnprintf-chk.c execution, -O1 +FAIL: gcc.c-torture/execute/builtins/vsprintf-chk.c execution, -O1 +FAIL: gcc.c-torture/execute/stdarg-1.c -O2 execution test +FAIL: gcc.c-torture/execute/stdarg-1.c -O3 -g execution test +FAIL: gcc.c-torture/execute/stdarg-1.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: gcc.c-torture/execute/strct-stdarg-1.c -O2 (internal compiler error: in xtensa_output_integer_literal_parts, at config/xtensa/xtensa.cc:3201) +FAIL: gcc.c-torture/execute/strct-stdarg-1.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (internal compiler error: in xtensa_output_integer_literal_parts, at config/xtensa/xtensa.cc:3201) +FAIL: gcc.c-torture/execute/strct-stdarg-1.c -O3 -g (internal compiler error: in xtensa_output_integer_literal_parts, at config/xtensa/xtensa.cc:3201) +FAIL: gcc.c-torture/execute/strct-stdarg-1.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone (internal compiler error: in xtensa_output_integer_literal_parts, at config/xtensa/xtensa.cc:3201) +FAIL: gcc.c-torture/execute/strct-stdarg-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (internal compiler error: in xtensa_output_integer_literal_parts, at config/xtensa/xtensa.cc:3201) +FAIL: gcc.c-torture/execute/va-arg-pack-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test +FAIL: gcc.dg/atomic/c11-atomic-exec-4.c -O1 execution test +FAIL: gcc.dg/strcmpopt_6.c execution test +FAIL: c-c++-common/torture/builtin-arith-overflow-14.c -O2 execution te= st +FAIL: c-c++-common/torture/builtin-arith-overflow-14.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: c-c++-common/torture/builtin-arith-overflow-3.c -O2 execution tes= t +FAIL: c-c++-common/torture/builtin-arith-overflow-3.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: c-c++-common/torture/builtin-arith-overflow-p-14.c -O2 execution = test +FAIL: c-c++-common/torture/builtin-arith-overflow-p-14.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: c-c++-common/torture/builtin-shufflevector-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test +FAIL: gcc.dg/torture/vec-cvt-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test +FAIL: gcc.dg/tree-ssa/forwprop-39.c (test for excess errors) +FAIL: gcc.dg/tree-ssa/forwprop-39.c scan-tree-dump-not forwprop1 "COMPLEX_= EXPR" +FAIL: gcc.dg/tree-ssa/forwprop-39.c scan-tree-dump-not optimized "REALPART_EXPR" +FAIL: c-c++-common/torture/builtin-arith-overflow-14.c -O2 execution te= st +FAIL: c-c++-common/torture/builtin-arith-overflow-14.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: c-c++-common/torture/builtin-arith-overflow-3.c -O2 execution tes= t +FAIL: c-c++-common/torture/builtin-arith-overflow-3.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: c-c++-common/torture/builtin-arith-overflow-p-14.c -O2 execution = test +FAIL: c-c++-common/torture/builtin-arith-overflow-p-14.c -O2 -flto -fno-use-linker-plugin -flto-partition=3Dnone execution test +FAIL: c-c++-common/torture/builtin-shufflevector-1.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects execution test --=20 Thanks. -- Max