From: Max Filippov <jcmvbkbc@gmail.com>
To: Max Filippov <jcmvbkbc@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@linaro.org>
Subject: Re: [PATCH] fix PR translation/82185
Date: Mon, 11 Sep 2017 21:59:00 -0000 [thread overview]
Message-ID: <CAMo8BfKrDqP4TBMgN6LmBkBBuWrajs5dxD4tHZhwFCLMeSvfZA@mail.gmail.com> (raw)
In-Reply-To: <871sncdiix.fsf@linaro.org>
Hi Richard,
On Mon, Sep 11, 2017 at 2:36 PM, Richard Sandiford
<richard.sandiford@linaro.org> wrote:
> Max Filippov <jcmvbkbc@gmail.com> writes:
>> 2017-09-11 Max Filippov <jcmvbkbc@gmail.com>
>> gcc/
>> * expmed.c (emit_store_flag_int): Initialize rtx tem.
>
> LGTM, thanks, but I can't approve it.
>
> This makes the later "tem = 0;" redundant, so perhaps it would make
> sense to delete that too? There again, it was redundant before the
> split as well.
>
> An alternative would be to only test tem when we've done something
> with it, as below, but I don't know if that's better or a step backwards.
this works for me too, so whichever fix you like better.
--
Thanks.
-- Max
next prev parent reply other threads:[~2017-09-11 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 21:16 Max Filippov
2017-09-11 21:37 ` Richard Sandiford
2017-09-11 21:59 ` Max Filippov [this message]
2017-09-11 22:37 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8BfKrDqP4TBMgN6LmBkBBuWrajs5dxD4tHZhwFCLMeSvfZA@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).