From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2b.google.com (mail-oo1-xc2b.google.com [IPv6:2607:f8b0:4864:20::c2b]) by sourceware.org (Postfix) with ESMTPS id 24CCD393BC09 for ; Sat, 11 Jun 2022 00:12:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24CCD393BC09 Received: by mail-oo1-xc2b.google.com with SMTP id e13-20020a4a884d000000b004154e612440so162834ooi.0 for ; Fri, 10 Jun 2022 17:12:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hsUuvpmzS170NXWNF6kYYGOMaaa1txT0EUPUyZSv8yo=; b=EnuNyEzic7GRpjXz6oY/8vJYv6CoC+dLp8wot8aZ+ZkyQ9DDMMPwFNYZ72Djvwj9n+ aHZy8fRUjnxvwflILYxzSpQI2zDfjZ/QuTSvc08qPfFdUsvOuYypvZGN0BV4VUQ9xHeB JJOhSTlxgv0mpimCgiSHUuONTpupC5yzf0LUAhOixVozdc/y1szNBEmcVikkurqoZGEM 8u2nSwQwVvJqLAxVVovF8uXKemF2AEiXMtI5ycYtnlYgvrHmxPZ+rhtPBVfi6BK8IAhW nCg0t57WyTS3V6hC/3YVt7v+C89icPuyXZDYkWOYHhk88D+GypN9sOBoLFmF+vdUBMCd sqfw== X-Gm-Message-State: AOAM532uPlr4z7J144op6t6FOMgmqovPJ+cd0TEz2NDeDjevhpkn6Msz ivlz5eDcZoJJF1KYIVnacpmioL0CQ6tmW0xD+Q8= X-Google-Smtp-Source: ABdhPJxt1UUn28ZvJtz3R5JOX6AibATXYpkfClVk7Pao3cJjN3Rbf8ZU/yGo86qD/HtoIrSiEeCHr82KJUol6eXVHDg= X-Received: by 2002:a4a:dc98:0:b0:41b:abda:21b8 with SMTP id g24-20020a4adc98000000b0041babda21b8mr6572802oou.47.1654906373448; Fri, 10 Jun 2022 17:12:53 -0700 (PDT) MIME-Version: 1.0 References: <842bf876-2f00-7216-b6f4-e625a13868dc@yahoo.co.jp> In-Reply-To: <842bf876-2f00-7216-b6f4-e625a13868dc@yahoo.co.jp> From: Max Filippov Date: Fri, 10 Jun 2022 17:12:42 -0700 Message-ID: Subject: Re: [PATCH 2/4] xtensa: Consider the Loop Option when setmemsi is expanded to small loop To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2022 00:12:55 -0000 Hi Suwa-san, On Thu, Jun 9, 2022 at 9:26 PM Takayuki 'January June' Suwa wrote: > > Now apply to almost any size of aligned block under such circumstances. > > gcc/ChangeLog: > > * config/xtensa/xtensa.cc (xtensa_expand_block_set_small_loop): > Pass through the block length / loop count conditions if > zero-overhead looping is configured and active, > --- > gcc/config/xtensa/xtensa.cc | 65 +++++++++++++++++++++++++------------ > 1 file changed, 45 insertions(+), 20 deletions(-) This change results in a bunch of ICEs in tests that look like this: gcc/gcc/testsuite/gcc.c-torture/compile/memtst.c: In function 'main': gcc/gcc/testsuite/gcc.c-torture/compile/memtst.c:28:1: error: unrecognizable insn: (insn 7 6 8 2 (set (reg:SI 45) (plus:SI (reg:SI 44) (const_int 262144 [0x40000]))) "gcc/gcc/testsuite/gcc.c-torture/compile/memtst.c":23:3 -1 (nil)) during RTL pass: vregs gcc/gcc/testsuite/gcc.c-torture/compile/memtst.c:28:1: internal compiler error: in extract_insn, at recog.cc:2791 0x6a21cf _fatal_insn(char const*, rtx_def const*, char const*, int, char const*) gcc/gcc/rtl-error.cc:108 0x6a2252 _fatal_insn_not_found(rtx_def const*, char const*, int, char const*) gcc/gcc/rtl-error.cc:116 0x693824 extract_insn(rtx_insn*) gcc/gcc/recog.cc:2791 0xb27647 instantiate_virtual_regs_in_insn gcc/gcc/function.cc:1611 0xb27647 instantiate_virtual_regs gcc/gcc/function.cc:1985 0xb27647 execute gcc/gcc/function.cc:2034 -- Thanks. -- Max