From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 4625F382B5E9 for ; Thu, 9 Jun 2022 22:12:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4625F382B5E9 Received: by mail-ot1-x32d.google.com with SMTP id g17-20020a9d6491000000b0060c0f0101ffso6103739otl.7 for ; Thu, 09 Jun 2022 15:12:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f3sgdVjOzpZJdlCXDB1f7C6/skyWjLWFjE7GfrV1npg=; b=iKdSocqhoWGRWXO/DkQRakzxg6kgkX5CjmmLegM4FYGRdhQMsByPEeeO44j1dADhld JjnAl2jeDuYl5KbUN7B3lpjEv9muqI0PIOKUVrT0PXAG2+eD1GmbDuZiWnlFTQ7snhfQ YU2lKgsUyyHcK2+D9yp6Ubnvw/pDXxyZ0vlnYUtNom7G/uJT1opoAIKv41OmWBA8I1BX FEhNuBqPtB+9wmgMvxlWnm+vVGcb8LpKSfPQkf35wyBlRgWPH94Oj6LtYDYoORD/Ra3e bvUr9SDWB5UsLZHyKFoep2eWxzXSg98qyLPlImMJW3gI1iwEXeJB8I3PkSPkNMJxd1RA mRag== X-Gm-Message-State: AOAM5319ask9M+yxxzrIOm5iF7NwDyk9QKHrwSPwvjHjrtFF3Z7ahrZk uqzZx2LsOJ2oLNXb887h0KDPsJCsGYYU0XsmWmg= X-Google-Smtp-Source: ABdhPJzpa6o2KCtKiA/hI+WFTrGqtOe6lgetgj2/dyEN0pDJ9DgNKnVPZdRt1TULS90BJ+UEMiYVCYMQ5DpeRrI/OnQ= X-Received: by 2002:a9d:6456:0:b0:60b:1c99:bd6a with SMTP id m22-20020a9d6456000000b0060b1c99bd6amr17488092otl.384.1654812751618; Thu, 09 Jun 2022 15:12:31 -0700 (PDT) MIME-Version: 1.0 References: <9835da53-f201-fe51-c9a5-dcf9d7297941@yahoo.co.jp> In-Reply-To: <9835da53-f201-fe51-c9a5-dcf9d7297941@yahoo.co.jp> From: Max Filippov Date: Thu, 9 Jun 2022 15:12:21 -0700 Message-ID: Subject: Re: [PATCH 2/4] xtensa: Make one_cmplsi2 optimizer-friendly To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, FROM_LOCAL_NOVOWEL, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2022 22:12:34 -0000 On Sun, May 29, 2022 at 4:00 AM Takayuki 'January June' Suwa wrote: > > In Xtensa ISA, there is no single machine instruction that calculates unary > bitwise negation. But a few optimizers assume that bitwise negation can be > done by a single insn. > > As a result, '((x < 0) ? ~x : x)' cannot be optimized to '(x ^ (x >> 31))' > ever before, for example. > > This patch relaxes such limitation, by putting the insn expansion off till > the split pass. > > gcc/ChangeLog: > > * config/xtensa/xtensa.md (one_cmplsi2): > Rearrange as an insn_and_split pattern. > > gcc/testsuite/ChangeLog: > > * gcc.target/xtensa/one_cmpl_abs.c: New. > --- > gcc/config/xtensa/xtensa.md | 26 +++++++++++++------ > .../gcc.target/xtensa/one_cmpl_abs.c | 9 +++++++ > 2 files changed, 27 insertions(+), 8 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/xtensa/one_cmpl_abs.c Regtested for target=xtensa-linux-uclibc, no new regressions. Committed to master. -- Thanks. -- Max