From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 738C13858D1E for ; Tue, 21 Feb 2023 01:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 738C13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id n20so1519864pfu.12 for ; Mon, 20 Feb 2023 17:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7xi9e1vMFE+p7zTqV6jr8DrVGnSwqT+YSnTdCHQjkNw=; b=CSos4kzrOxrFhm+7WdhXxYjqEbTeHOr8JbYpIXNrKzLQfOE5uSnssjHFhT+A04FbFz MHZCtbRUzQtnvAV124nkXtBztrX8qe8aQ9RIhkeN2wnAR4f2ZS0SMYItwFGLE/DWD82Z P5y+DMbPzHSQTZOOXXJQHRqEgCi/hW5E8seLMup3zesykjmDFCnQOGvzosNsVk3uDF9y 8mza9FtGg9Xe5W4QilfWEwT9BOM5BZ8gAb0DmL3+ftmYObRKpXyhuI1k5sl8LgPPysZW p3nTua1a0Sl42UmCmRg+RaOmOXKFU1BiBnubGC3UBN5neLuXkwnjPGAToPBBcJQPsTY0 nzbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7xi9e1vMFE+p7zTqV6jr8DrVGnSwqT+YSnTdCHQjkNw=; b=AUM62GWTzs4ZIamsB/gKW8AqFAWMwl/K1Vx1jFulnyDbMsllXmBNDSaLLK2sP0IfsA P3BaFSp8uNHmiFSHTZbB/CyHrEvd26FADWZBUlM8cPVWk1ml2N9XsZPSScXC1LghvU9z isWSLobxdlaR/sf4egNGHKBpOQLR0bRUcbpMvlujgLDa2CVylmavWMZyl9geITqGx1Im IfpThwLleemaKMBoDXmieNRYcvKk9U+IZMCGcHI929jBkoj2U42YFrKeNUR+IPY85Wed PhYFLVJCni6gDLVNvLpnsB5e6ZBvY8qFiQ8jugpia9eqspxRtvH4mX9KsilecHHP5b5V FdRA== X-Gm-Message-State: AO0yUKXPqwzTobdr46cuvm35zQyXrhsVYoxoNYif3LltZ1T+X7SX49AC EJeIxNp0HQKLmKCBLOeRdPy6RPa0s3Y4pjEMEPY= X-Google-Smtp-Source: AK7set/gbenpG43+GsfWNoyn2HsXaLKf/uWeZ4QsWSkU2PkGHvqVzF8/F7AJa0iOAw2zcNXPKOKBo4ltYb4XE9Jhl+s= X-Received: by 2002:a63:3543:0:b0:4fd:5105:eb93 with SMTP id c64-20020a633543000000b004fd5105eb93mr408644pga.3.1676943262800; Mon, 20 Feb 2023 17:34:22 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Max Filippov Date: Mon, 20 Feb 2023 17:34:11 -0800 Message-ID: Subject: Re: [PATCH] xtensa: Enforce return address saving when -Og is specified To: "Takayuki 'January June' Suwa" Cc: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_ENVFROM,HK_RANDOM_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 17, 2023 at 8:54 PM Takayuki 'January June' Suwa wrote: > > Leaf function often omits saving its return address to the stack slot, > and this feature often makes debugging very confusing, especially for > stack dump analysis. > > gcc/ChangeLog: > > * config/xtensa/xtensa.cc (xtensa_call_save_reg): Change to return > true if register A0 (return address register) when -Og is specified. > --- > gcc/config/xtensa/xtensa.cc | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Regtested for target=xtensa-linux-uclibc, no new regressions. Committed to master. -- Thanks. -- Max