From: Joern Rennecke <joern.rennecke@embecosm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, jlaw@ventanamicro.com
Subject: Re: [RFA] New pass for sign/zero extension elimination
Date: Mon, 27 Nov 2023 18:19:53 +0000 [thread overview]
Message-ID: <CAMqJFCpAtAtH52iLisyRqEBQ2Mx7m=r0EywpGpjxBL1==q9hAQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 42 bytes --]
You are applying PATTERN to an INSN_LIST.
[-- Attachment #2: tmp.txt --]
[-- Type: text/plain, Size: 2461 bytes --]
diff --git a/gcc/ext-dce.cc b/gcc/ext-dce.cc
index 52032b50951..4523654538c 100644
--- a/gcc/ext-dce.cc
+++ b/gcc/ext-dce.cc
@@ -122,10 +122,9 @@ safe_for_live_propagation (rtx_code code)
optimziation phase during use handling will be. */
static void
-ext_dce_process_sets (rtx insn, bitmap livenow, bitmap live_tmp)
+ext_dce_process_sets (rtx insn, rtx pat, bitmap livenow, bitmap live_tmp)
{
subrtx_iterator::array_type array;
- rtx pat = PATTERN (insn);
FOR_EACH_SUBRTX (iter, array, pat, NONCONST)
{
const_rtx x = *iter;
@@ -377,7 +376,7 @@ binop_implies_op2_fully_live (rtx_code code)
eliminated in CHANGED_PSEUDOS. */
static void
-ext_dce_process_uses (rtx insn, bitmap livenow, bitmap live_tmp,
+ext_dce_process_uses (rtx insn, rtx pat, bitmap livenow, bitmap live_tmp,
bool modify, bitmap changed_pseudos)
{
/* A nonlocal goto implicitly uses the frame pointer. */
@@ -389,7 +388,6 @@ ext_dce_process_uses (rtx insn, bitmap livenow, bitmap live_tmp,
}
subrtx_var_iterator::array_type array_var;
- rtx pat = PATTERN (insn);
FOR_EACH_SUBRTX_VAR (iter, array_var, pat, NONCONST)
{
/* An EXPR_LIST (from call fusage) ends in NULL_RTX. */
@@ -640,15 +638,16 @@ ext_dce_process_bb (basic_block bb, bitmap livenow,
bitmap live_tmp = BITMAP_ALLOC (NULL);
/* First process any sets/clobbers in INSN. */
- ext_dce_process_sets (insn, livenow, live_tmp);
+ ext_dce_process_sets (insn, PATTERN (insn), livenow, live_tmp);
/* CALL_INSNs need processing their fusage data. */
if (GET_CODE (insn) == CALL_INSN)
- ext_dce_process_sets (CALL_INSN_FUNCTION_USAGE (insn),
+ ext_dce_process_sets (insn, CALL_INSN_FUNCTION_USAGE (insn),
livenow, live_tmp);
/* And now uses, optimizing away SIGN/ZERO extensions as we go. */
- ext_dce_process_uses (insn, livenow, live_tmp, modify, changed_pseudos);
+ ext_dce_process_uses (insn, PATTERN (insn), livenow, live_tmp, modify,
+ changed_pseudos);
/* And process fusage data for the use as well. */
if (GET_CODE (insn) == CALL_INSN)
@@ -663,7 +662,7 @@ ext_dce_process_bb (basic_block bb, bitmap livenow,
if (global_regs[i])
bitmap_set_range (livenow, i * 4, 4);
- ext_dce_process_uses (CALL_INSN_FUNCTION_USAGE (insn),
+ ext_dce_process_uses (insn, CALL_INSN_FUNCTION_USAGE (insn),
livenow, live_tmp, modify, changed_pseudos);
}
next reply other threads:[~2023-11-27 18:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 18:19 Joern Rennecke [this message]
2023-11-28 5:51 ` Jeff Law
-- strict thread matches above, loose matches on Subject: below --
2023-11-29 17:37 Joern Rennecke
2023-11-29 19:13 ` Jivan Hakobyan
2023-11-30 15:37 ` Jeff Law
2023-11-27 17:36 Joern Rennecke
2023-11-27 17:57 ` Joern Rennecke
2023-11-27 20:03 ` Richard Sandiford
2023-11-27 20:18 ` Jeff Law
2023-11-28 13:36 ` Joern Rennecke
2023-11-28 14:09 ` Joern Rennecke
2023-11-30 17:33 ` Jeff Law
2023-11-28 13:13 ` Joern Rennecke
2023-11-28 5:50 ` Jeff Law
2023-11-20 0:47 Jeff Law
2023-11-20 1:22 ` Oleg Endo
2023-11-20 2:51 ` Jeff Law
2023-11-20 2:57 ` Oleg Endo
2023-11-20 2:23 ` Xi Ruoyao
2023-11-20 2:46 ` Jeff Law
2023-11-20 2:52 ` Jeff Law
2023-11-20 3:32 ` Xi Ruoyao
2023-11-20 3:48 ` Jeff Law
2023-11-20 18:26 ` Richard Sandiford
2023-11-22 17:59 ` Jeff Law
2023-11-27 20:15 ` Richard Sandiford
2023-11-20 18:56 ` Dimitar Dimitrov
2023-11-22 22:23 ` Jeff Law
2023-11-26 16:42 ` rep.dot.nop
2023-11-27 16:14 ` Jeff Law
2023-11-27 11:30 ` Andrew Stubbs
2023-11-27 16:16 ` Jeff Law
2023-12-01 1:08 ` Hans-Peter Nilsson
2023-12-01 15:09 ` Jeff Law
2023-12-01 16:17 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMqJFCpAtAtH52iLisyRqEBQ2Mx7m=r0EywpGpjxBL1==q9hAQ@mail.gmail.com' \
--to=joern.rennecke@embecosm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jlaw@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).