From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id A21883858D28 for ; Thu, 5 Jan 2023 16:27:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A21883858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-pg1-x529.google.com with SMTP id h192so20008956pgc.7 for ; Thu, 05 Jan 2023 08:27:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=bI4He4UxXI2p0H3YhErrhpXFXtNezZw0IpTIARWnc64=; b=DU5AANi3YGzPjKoD/zhocBKraCV5QvYPlM7HONXOR7yA225prjgzBQq9Hq0A0pPwiz CT3UYUlg4cRoE/VedI228r9jyTewCwklVMl467HTNLM2YzN8vhfO2fTiYcLLvkQGIWrB fdBId9gdsGt2gBZtWEJBqY3ZgO/oeFrki3ZiY7YApqOuT+txwa7hACj/NiHZnB+KzKBy +HAWypKIPTeNCaQDV38zj+ZwSySG39UIr4w/+sOL0kpSnj8b4eteJLgEoY5uHgyOxo3W 2zuv0Fblb0IEUxde4qFUBlS7W973ys87/gpftr+ffgxzn/bnq5/RRUpUcUvW7RkpMTfk FobA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bI4He4UxXI2p0H3YhErrhpXFXtNezZw0IpTIARWnc64=; b=Aq/cRx/E8BTTR1iHB1GWwwoh8W0zm6qvkokhHXgDadaslx9WBTrti/aqgGLKsIPbBY SanNk2e9b95l1gH3E90XQDOVKQrKBHNoG3DCA+fk3RYwgx3a3bvgVS+KX4uwVDI8jp8R MOeutv9BH74JGOOgrLOO960LPNcqdBwovkRpSre0zNg+YQD34LvZ7I+H1A3isvp3o2vz xGq5m0F3LO30p0GgRnf56SEprr8zgJKzLBJQBkVOwYqlH+RdAcmYts+/9hvNrZTL0fz5 H4CQ0uzngGxb4SUHE69HCQuVJyhriXo5/2WP3vQRLkH37h7s9HwEQOWRKrQDLRKD7Xvb NDHw== X-Gm-Message-State: AFqh2krw042GA76T2CSLMB++1KWZPn1oOyxSmYMo9Q7mgprki/QuBp8y ykQg80MpZn1VyAFJ+6NCLYsIV2I3be9si3O4yIrewdFeoBe8ri2r X-Google-Smtp-Source: AMrXdXsBnQt8BOtsUdAOTg4llFacgsl7iQKZrPMeA/f6r8/OLk7Nq3V38IY4F0s22gpOtIbt8/2omjZ1EZbLkCXvfiY= X-Received: by 2002:a62:8383:0:b0:580:d409:3964 with SMTP id h125-20020a628383000000b00580d4093964mr2897811pfe.79.1672936024517; Thu, 05 Jan 2023 08:27:04 -0800 (PST) MIME-Version: 1.0 From: Joern Rennecke Date: Thu, 5 Jan 2023 16:26:53 +0000 Message-ID: Subject: Re: [PATCH v4 02/34] RISC-V: Add vlex_2.c To: GCC Patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 1, 2022 at 02:28:45 GMT 2022, zhongjuzhe wrote: > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/rvv/intrinsic/vlex_2.c: New test. These intrinsic test cases look like they have been machine generated. And if they aren't, they probably should (have) be(en). I've been working on stabilizing a tree with the rvv patches merged, and found a number of tests had diverged in intrinsic function naming, arguments taken, and/or return type. Fixing this all with global replaces in dozens of files is quite messy. It would be preferable if such issues could be fixed by adjusting a generator file, and just re-generating the generated files. That's one of the reasons why the GPL makes a point of asking to include source code. Even if that is not strictly required for the testsuite for license reasons, it makes good sense to do that for maintenance reasons. The generator file should then also add a note where in the source tree to find the generator file, and, where appropriate, notes which part(s) of the generator file is/are responsible for generating the test case.