From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77427 invoked by alias); 3 Nov 2015 14:06:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 77331 invoked by uid 89); 3 Nov 2015 14:06:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=unavailable version=3.3.2 X-HELO: mail-yk0-f178.google.com Received: from mail-yk0-f178.google.com (HELO mail-yk0-f178.google.com) (209.85.160.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 03 Nov 2015 14:06:42 +0000 Received: by ykek133 with SMTP id k133so16833499yke.2 for ; Tue, 03 Nov 2015 06:06:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LWcG/KI7Oi/Egdoe2rlOdfaV9OshKOtNvKQ0frKvrqk=; b=Gt9YrC1OjrQUZCgVVSOD1sS7hKwTyf+0CoXUtUjqfa7cgUkFlfLuY3cKCUrsRo/+RY Z02hJrQquwt203bRJX+itJxPS4HCRY8C9dcy7nl3k66wNWnxVMtOo3ssHE18ZkFnWuoa MIk3cCqgIUvtaAKO46MslxVD0yvkHZoDGZSb8NDLfa4ihEl5qvvLI255fbCtaI72xV/q 1CQPXnPO0Clm6fs1V8MceTG7HtVOw9bbOfShBfCoIA0tPVx+IsQnnErI98/is92GPQw6 x/lk78Awwr5HBC7QXjk5fNLLKLKDD0V/YCnG6gl1ojlm04fa/ai76g8wZIipswa0bTr4 3yvg== X-Gm-Message-State: ALoCoQkSrrMuMe4zNYzc14tAlYuLA0xWhl2CggWx74ylUOsVM3ahAqFqytv9lYESOYsvHUf1UWE7 MIME-Version: 1.0 X-Received: by 10.31.151.16 with SMTP id z16mr18978787vkd.14.1446559600382; Tue, 03 Nov 2015 06:06:40 -0800 (PST) Received: by 10.31.190.15 with HTTP; Tue, 3 Nov 2015 06:06:40 -0800 (PST) In-Reply-To: <5638B5EA.9080303@oracle.com> References: <1446554133-3090-1-git-send-email-aurelio.remonda@tallertechnologies.com> <5638B5EA.9080303@oracle.com> Date: Tue, 03 Nov 2015 14:06:00 -0000 Message-ID: Subject: Re: [PATCH] Add configure flag for operator new (std::nothrow) From: Aurelio Remonda To: Paolo Carlini Cc: "libstdc++" , gcc-patches@gcc.gnu.org, Jonathan Wakely Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-11/txt/msg00207.txt.bz2 On Tue, Nov 3, 2015 at 10:26 AM, Paolo Carlini w= rote: > Hi, > > On 11/03/2015 01:35 PM, Aurelio Remonda wrote: >> >> diff --git a/ChangeLog b/ChangeLog >> index 5b16ca2..a1cd0d3 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,12 @@ >> +2015-10-30 Aurelio Remonda >> + >> + * libstdc++-v3/acinclude.m4: add >> enable_new_opnt_no_allocation_retry >> + flag definition. >> + * libstdc++-v3/configure.ac: add option flag >> + GLIBCXX_ENABLE_NEW_OPNT_NO_ALLOCATION_RETRY >> + * libstdc++-v3/libsupc++/new_opnt.cc use the defined macro >> + * libstdc++-v3/doc/xml/manual/configure.xml >> + > > Three minor comments. First, ChangeLog entries aren't normally submitted = as > part of the patch. Second, since the ChangeLog is under libstdc++-v3, the > ChangeLog entries should not have libstdc++-v3 in the paths (eg, just * > acinclude.m4: ...). Ok, so ChangeLog modifications should be another patch? >Finally, since you are touching acinclude.m4 you should > normally run autoreconf, mention in the ChangeLog the changed regenerated > files and eventually commit those changes too (like the ChangeLog entries, > those aren't normally part of the posted patch) About the three issues, y= ou > have plenty of examples in the mailing list. I have a problem with autoreconf, when i run it with autoconf 2.69 it says i need exactly autoconf 2.64 so i install it and try to do autoreconf with 2.64 and this is what i get: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ autoreconf configure.ac:74: error: Autoconf version 2.65 or higher is required You can see i am using my recently installed autoconf: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ which autoconf /home/aurelio-remonda/autoconf-2.64/install/bin/autoconf I even try 2.65: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ which autoreconf /home/aurelio-remonda/autoconf-2.65/install/bin/autoreconf and got this: aurelio-remonda@Remonda-PC:~/gcc/libstdc++-v3$ autoreconf configure.ac:4: error: Please use exactly Autoconf 2.64 instead of 2.65. ../config/override.m4:12: _GCC_AUTOCONF_VERSION_CHECK is expanded from... configure.ac:4: the top level autom4te: /usr/bin/m4 failed with exit status: 1 aclocal: error: echo failed with exit status: 1 autoreconf: aclocal failed with exit status: 1 So i changed the version here: /src/gcc/libstdc++-v3/configure.ac:3 AC_PREREQ(2.69) And here: /src/config/override.m4:59 m4_if(m4_defn([m4_PACKAGE_VERSION]), [2.69] And did the autoreconf with 2.69 and that worked. But Jonathan told me that i don't have to make those changes. --=20 Aurelio Remonda Software Engineer San Lorenzo 47, 3rd Floor, Office 5 C=C3=B3rdoba, Argentina Phone: +54-351-4217888 / 4218211