From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26641 invoked by alias); 30 Jul 2013 19:50:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 26616 invoked by uid 89); 30 Jul 2013 19:50:55 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-wg0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 30 Jul 2013 19:50:54 +0000 Received: by mail-wg0-f46.google.com with SMTP id k13so6376303wgh.25 for ; Tue, 30 Jul 2013 12:50:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=aP6yT0VADVWFzNQTlxWHnXh/Ym87V/KBXw0DzNvWRbE=; b=H1kn8DJkL+7x2477am480P2JNTEFb5Kr6j3PqoIXp6bkmsUB0SfjkAjXfWzJan+uLN vGbCbYXotKu6+nAlRTH1pwfAfx/BKOqQbFky1kISD7axsGAhBiMrp8vFMemBKBK3vr7i kqpp6iEJW5DLInQaPOp7O2QetU1PzDftuf+IhIYNX91GAxBr6ILR7AAs2xkEfOAWUi0Z KHGgnkXQj9tN7tt9/OJrs0X0R9A8vZEZNUSa2kwHYr7FpjpHUaNo295oyak67/4lxJjj V0alNzDl5T4L6/YsP7bzuYWdPzC96EGtvldMPgertNUCS1qoAhlcouYimoduyPycVP7r 7Caw== MIME-Version: 1.0 X-Received: by 10.180.89.101 with SMTP id bn5mr2002816wib.45.1375213846346; Tue, 30 Jul 2013 12:50:46 -0700 (PDT) Received: by 10.194.170.231 with HTTP; Tue, 30 Jul 2013 12:50:46 -0700 (PDT) In-Reply-To: References: Date: Tue, 30 Jul 2013 19:58:00 -0000 Message-ID: Subject: Re: [Google] Fix profiledbootstrap failure From: Dinar Temirbulatov To: Xinliang David Li Cc: Teresa Johnson , GCC Patches , Rong Xu Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQnA/rOpHyBboW+ZYAsRXCNv9w61tPjIOZyVXecLdxbFakvXgtWFXuix58marGAWhjVyUU38 X-SW-Source: 2013-07/txt/msg01505.txt.bz2 >I need to understand why this affects profile bootstrap -- is this due >to file name conflict? Yes, It is simple. During the profiledbootstrap on x86_64 platform for libiberty the compiler picks an incorrect profile from the current directory(non-pic version), while compiling pic version, and profiledbootstrap fails. Here is log: if [ x"-fpic" !=3D x ]; then \ /home/dinar/bugz/x86_64/build-gcc-4_8-svn-orig/./prev-gcc/xgcc -B/home/dinar/bugz/x86_64/bisect/build-gcc-4_8-svn-orig/./prev-gcc/ -B/tmp/x86_64-unknown-linux-gnu/bin/ -B/tmp/x86_64-unknown-linux-gnu/bin/ -B/tmp/x86_64-unknown-linux-gnu/lib/ -isystem /tmp/x86_64-unknown-linux-gnu/include -isystem /tmp/x86_64-unknown-linux-gnu/sys-include -c -DHAVE_CONFIG_H -g -O2 -fprofile-use -I. -I../../gcc-4_8-svn-orig/libiberty/../include -W -Wall -Wwrite-strings -Wc++-compat -Wstrict-prototypes -pedantic -fpic ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c -o pic/dwarfnames.o; \ else true; fi yes ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c:75:0: error: the control flow of function =91get_DW_CFA_name=92 does not match its profile data (counter =91arcs=92) [-Werror=3Dcoverage-mismatch] ^ ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c:75:0: note: use -Wno-error=3Dcoverage-mismatch to tolerate the mismatch but performance may drop if the function is hot ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c: In function =91get_DW_ATE_na= me=92: ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c:75:0: error: the control flow of function =91get_DW_ATE_name=92 does not match its profile data (counter =91arcs=92) [-Werror=3Dcoverage-mismatch] ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c:75:0: note: use -Wno-error=3Dcoverage-mismatch to tolerate the mismatch but performance may drop if the function is hot ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c: In function =91get_DW_OP_nam= e=92: ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c:75:0: error: the control flow of function =91get_DW_OP_name=92 does not match its profile data (counter =91arcs=92) [-Werror=3Dcoverage-mismatch] ../../gcc-4_8-svn-orig/libiberty/dwarfnames.c:75:0: note: use -Wno-error=3Dcoverage-mismatch to tolerate the mismatch but performance may drop if the function is hot thanks, Dinar. On Tue, Jul 30, 2013 at 11:02 PM, Xinliang David Li wr= ote: > I need to understand why this affects profile bootstrap -- is this due > to file name conflict? > > The fix is wrong -- please do not remove the parameter. If it is a > problem, a better fix is to change the default parameter value to 0. > > David > > > On Tue, Jul 30, 2013 at 11:56 AM, Teresa Johnson w= rote: >> cc'ing Rong and David since this came from LIPO support. >> >> The patch as-is removes the one use of PARAM_GCOV_DEBUG (which is on >> by default) without removing the parameter itself. What is the failure >> mode you see from this code? >> >> Thanks, >> Teresa >> >> On Tue, Jul 30, 2013 at 11:50 AM, Dinar Temirbulatov >> wrote: >>> Hello >>> >>> This change allows to complete profiledbootstrap on the google gcc-4.8 >>> branch, tested with make bootstrap with no new regressions. OK for >>> google 4.8? >>> thanks, Dinar. >> >> >> >> -- >> Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413